Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows path separator #443

Merged
merged 3 commits into from
Jun 25, 2020
Merged

fix: windows path separator #443

merged 3 commits into from
Jun 25, 2020

Conversation

Shinigami92
Copy link
Contributor

Short description of what this resolves:

In windows files are separated with \ instead of /
This fix implemented a detection for windows and fix the unix style / for windows reports

Proposed changes:

Use \ as file separator in windows

@Shinigami92 Shinigami92 added the bug Functionality that does not work as intended/expected label Jun 1, 2020
@Shinigami92 Shinigami92 self-assigned this Jun 1, 2020
@Shinigami92 Shinigami92 merged commit 8048600 into master Jun 25, 2020
@Shinigami92 Shinigami92 deleted the fix/windows-path-separator branch June 25, 2020 19:46
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
## [0.14.1](v0.14.0...v0.14.1) (2020-06-25)

### Bug Fixes

* windows path separator ([#443](#443)) ([8048600](8048600))
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fisker
Copy link
Contributor

fisker commented Jun 26, 2020

Why not use path.sep?

@Shinigami92
Copy link
Contributor Author

@fisker Could you explain or create a PR for that?
I currently don't know where to use path.sep in a correct way 🤔
Maybe we can do something here:

base += `${globPath.basename}/`

But I' curios if it is better to find every single place instead of just correct the one already working location

fisker added a commit to fisker/HTMLHint that referenced this pull request Jun 26, 2020
fisker added a commit to fisker/HTMLHint that referenced this pull request Jun 26, 2020
Shinigami92 pushed a commit that referenced this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants