Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated dependencies #645

Closed
aravindvnair99 opened this issue May 16, 2021 · 8 comments
Closed

Deprecated dependencies #645

aravindvnair99 opened this issue May 16, 2021 · 8 comments
Assignees

Comments

@aravindvnair99
Copy link

$ npm i -g htmlhint@latest
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
@thedaviddias
Copy link
Member

Hey @aravindvnair99, thanks for pointing that out. The repo is going to be updated in the coming days. Hopefully, you will not see these messages in the near future.

@stale
Copy link

stale bot commented Jul 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Jul 25, 2021
@aravindvnair99
Copy link
Author

Hey @aravindvnair99, thanks for pointing that out. The repo is going to be updated in the coming days. Hopefully, you will not see these messages in the near future.

@thedaviddias Any updates?

@stale stale bot removed the bot:stale Issue marked as stale because there was no activity label Jul 25, 2021
@aravindvnair99
Copy link
Author

As of today, 25th July 2021:

$ npm i -g htmlhint@latest
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142

added 75 packages, and audited 76 packages in 11s

5 packages are looking for funding
  run `npm fund` for details

4 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

Version is 0.15.1

@stuartbale
Copy link

stuartbale commented Sep 6, 2021

request is used in one place - the HtmlHint CLI.

request.get(url, (error, response, body) => {

If someone can post what the suggested replacement for this is, I can submit a pull request.

Replacing request will resolve all three deprecated warnings.

@stuartbale
Copy link

request is used in one place - the HtmlHint CLI.

request.get(url, (error, response, body) => {

If someone can post what the suggested replacement for this is, I can submit a pull request.

Replacing request will resolve all three deprecated warnings.

Would node-fetch be suitable?

https://www.npmjs.com/package/node-fetch

Seems to be well supported and used in >21k other packages.

@stuartbale
Copy link

I notice a pending Pull Request with a fix for this here:
#670

@darcyparker
Copy link
Contributor

with #670 merged, can this be closed?

@coliff coliff closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants