Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options w/ true/false vs true/not-present #2

Closed
carywreams opened this issue Nov 15, 2013 · 6 comments
Closed

options w/ true/false vs true/not-present #2

carywreams opened this issue Nov 15, 2013 · 6 comments

Comments

@carywreams
Copy link

Would you consider changing your options list implementation to acting on an
option_name: false,
setting ?

Right now, it appears to accept settings of either true or false as an indication to apply the option. Mere presence in the list - not the true/false setting - causes the rule to be applied.

...or, update the documentation to more strongly indicate that an option should be left off the list if its application is not desired. Expanding on the current statement,

If options is empty, task will scan nothing.

would be very helpful.

@brentwalter
Copy link

I second the suggestions above. I fought the settings for quite a while until I ready this issue request.

@schemedesigns
Copy link

I too had issues until I read the above request. I third the suggestion.

@aarr0n
Copy link

aarr0n commented May 14, 2014

Agree; For example, adding 'doctype-first': false to apply the rule is counter intuitive.

@branneman
Copy link

Agreed.

@danielppereira
Copy link

+1

@yaniswang
Copy link
Contributor

Fixed in v0.9.6.
HTMLHint v0.9.6 will release after some test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants