Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary console.log calls for the dropdown plugin #273

Closed
gregmsanderson opened this issue Feb 8, 2024 · 2 comments
Closed

Unnecessary console.log calls for the dropdown plugin #273

gregmsanderson opened this issue Feb 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@gregmsanderson
Copy link

gregmsanderson commented Feb 8, 2024

Hello,

I noticed that each time I interact with the dropdown plugin https://preline.co/plugins/html/dropdown.html, the up/down key is logged to the console. I don't think it's needed for accessibility, so is this simply left from debugging?

Can that line be removed?

Key code: ArrowDown

Screenshot 2024-02-08 at 17 22 16

@gregmsanderson gregmsanderson changed the title Unncessary console.log calls for the dropdown plugin Unnecessary console.log calls for the dropdown plugin Feb 8, 2024
@olegpix
Copy link
Collaborator

olegpix commented Feb 28, 2024

Hello,

I noticed that each time I interact with the dropdown plugin https://preline.co/plugins/html/dropdown.html, the up/down key is logged to the console. I don't think it's needed for accessibility, so is this simply left from debugging?

Can that line be removed?

Key code: ArrowDown

Screenshot 2024-02-08 at 17 22 16

Thank you! We’ll remove unnecessary console.logs in the next update.

@jahaganiev jahaganiev added the enhancement New feature or request label Feb 28, 2024
@jahaganiev
Copy link
Member

Hey @gregmsanderson - the issue has been fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants