fixes #252 fire change event when the tag close icon is clicked and item is removed #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverhaas
reviewed
Oct 1, 2024
| @@ -364,6 +364,8 @@ class HSSelect extends HSBasePlugin<ISelectOptions> implements ISelect { | |||
| this.selectMultipleItems(); | |||
|
|
|||
| newItem.remove(); | |||
| this.fireEvent('change', this.value); | |||
There was a problem hiding this comment.
Does this bubble?
Normal select change event bubble, so this should too.
There was a problem hiding this comment.
I believe it does.
This is basically following the same pattern when the selection value changes.
Plus, if we take a look at the dispatch implementation, we can see that events bubble by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the close icon on tag is clicked on the advanced select component, the change event is not fired but the item is removed.
Changes:
Fire the change event once the item is removed.