Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #252 fire change event when the tag close icon is clicked and item is removed #411

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fixes #252 fire change event when the tag close icon is clicked and item is removed #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/plugins/select/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,8 @@ class HSSelect extends HSBasePlugin<ISelectOptions> implements ISelect {
this.selectMultipleItems();

newItem.remove();
this.fireEvent('change', this.value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this bubble?
Normal select change event bubble, so this should too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it does.
This is basically following the same pattern when the selection value changes.

Plus, if we take a look at the dispatch implementation, we can see that events bubble by default

dispatch('change.hs.select', this.el, this.value);
});

this.wrapper.append(newItem);
Expand Down