Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #892

Closed
KernelDeimos opened this issue Sep 20, 2024 · 1 comment
Closed

Update tests #892

KernelDeimos opened this issue Sep 20, 2024 · 1 comment

Comments

@KernelDeimos
Copy link
Contributor

This issue is produced by me after I updated tap to the latest version. The previously used version appears to have a broken dependency. A good number of tests are now failing, and it is likely some of them are failing because tap was upgraded by 7 major versions 😅. If required changes are too immense I might change course and downgrade to the earliest version that still works (although, this would be less ideal).

Plan so far:

  • update tests that are broken only due to interface changes of tap
  • temporarily disable any tests which are broken for real
  • gradually fix tests and add them back

The reason I want to temporarily disable any "really broken" tests is so that new tests can be added and regressions can be properly avoided while this is happening (in case it happens to take a while).

@KernelDeimos
Copy link
Contributor Author

KernelDeimos commented Sep 20, 2024

Tests are all working! Turned out to be relatively easy. (all broken tests were only broken because I had to update tap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant