Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeOrigin not in documentation #851

Closed
Morriz opened this issue Jul 8, 2015 · 8 comments
Closed

changeOrigin not in documentation #851

Morriz opened this issue Jul 8, 2015 · 8 comments

Comments

@Morriz
Copy link

Morriz commented Jul 8, 2015

This cost me many hours to figure out....I might be stoopid, but more ppl like me could lost valuable time over this.

Why isn't this option enabled by default? It would serve 99% of the use cases out there.

@jpatters
Copy link
Contributor

jpatters commented Jul 8, 2015

I also just wasted several hours on this.
+1 for adding it to the docs

@jcrugzz
Copy link
Contributor

jcrugzz commented Jul 8, 2015

I will definitely take a pull-request for it :)

@Morriz
Copy link
Author

Morriz commented Jul 8, 2015

Sure. Who will put that extra line in the docs? Last one in line? I will do it when I have the time ;)

On 08 Jul 2015, at 22:05, Jarrett Cruger notifications@github.com wrote:

I will definitely take a pull-request for it :)


Reply to this email directly or view it on GitHub.

@jpatters
Copy link
Contributor

jpatters commented Jul 8, 2015

I'd do it but I have no idea where it should go. Any suggestions? The readme is kind of all over the place on doesn't really document anything. It just gives examples. Should it be its own example?

@Morriz
Copy link
Author

Morriz commented Jul 9, 2015

Just mention it in the list of options with a short explanation. Thats enough

On 08 Jul 2015, at 22:21, Jordan notifications@github.com wrote:

I'd do it but I have no idea where it should go. Any suggestions? The readme is kind of all over the place on doesn't really document anything. It just gives examples. Should it be its own example?


Reply to this email directly or view it on GitHub.

@bdefore
Copy link

bdefore commented Aug 5, 2015

👍 also lost quite a bit of time until i found this in the docs. i'm not sure why it's not true by default!

@kdepp
Copy link

kdepp commented Nov 5, 2015

+1, changeOrigin should be defaultly set to true

@indexzero
Copy link
Contributor

@bdefore @kdepp that is not the purpose of this issue. It should have been closed with #852. If you feel strongly about changeOrigin please open a new issue if one does not exist.

I am not opposed to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants