Handle http/2 request body without content-length #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Http/2 is always streaming, so setting content-length is optional.
danicheg
reviewed
Dec 7, 2024
| @@ -63,10 +63,15 @@ object JdkHttpClient { | |||
| def convertRequest(req: Request[F]): Resource[F, HttpRequest] = | |||
| flow.toPublisher(req.body.chunks.map(_.toByteBuffer)).evalMap { publisher => | |||
| convertHttpVersionFromHttp4s[F](req.httpVersion).map { version => | |||
| def isStreaming = version match { | |||
| case HttpClient.Version.HTTP_1_1 => req.isChunked | |||
| case HttpClient.Version.HTTP_2 => req.contentLength.isEmpty | |||
There was a problem hiding this comment.
At first glance, this seems a little tricky. But given the streaming nature, I think relying on req.body eq Stream.empty[Nothing] is hardly a better option.
core/src/main/scala/org/http4s/jdkhttpclient/JdkHttpClient.scala
Outdated
Show resolved
Hide resolved
danicheg
reviewed
Dec 7, 2024
Comment on lines
+82
to
+84
| // If we dont do this, we might block finalization | ||
| publisher.subscribe(DrainingSubscriber) | ||
| BodyPublishers.noBody |
samspills
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http/2 is always streaming, so setting content-length is optional.