Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side parser. #2

Open
digitalextremist opened this issue Feb 21, 2015 · 2 comments
Open

Server-side parser. #2

digitalextremist opened this issue Feb 21, 2015 · 2 comments
Assignees

Comments

@digitalextremist
Copy link

Per our brief discussion on Twitter @ixti, here is an issue to collect together our progress on a server-side parser for this multipart form-data library. I'll gladly help with this, time allowing.

This will also resolve the following associated issues:

I have functioning server-side parsing code I'm using myself, which is based on danabr/multipart-parser. Rather than just forking that repository I figured we could absorb and continue to maintain whatever we use, as that code is released under MIT.

Are there any objections to that? The last commit on that repository was 3 years back, and the code is all ruby-native.

/cc: @tarcieri, @kenichi

@digitalextremist digitalextremist self-assigned this Feb 21, 2015
@ixti
Copy link
Member

ixti commented Feb 22, 2015

Sounds good to me. Although I think that we can utilize http_parser to read headers of parts instead.

@janko
Copy link
Member

janko commented May 23, 2017

I just wanted to note that I tried danabr/multipart-parser, and surprisingly I found it to be significantly slower than Rack's multipart parser. I generated a multipart body from a 25MB file, and parsed it with both multipart-parser and Rack's multipart parser, and Rack took about 4s whereas multipart-parser took around 35s.

It's not that I needed it or anything, I was just wondering what was the performance comparison between the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants