Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting Content-Type is not supported on non-file parts #5

Closed
abotalov opened this issue Jan 16, 2017 · 0 comments · Fixed by #10
Closed

Setting Content-Type is not supported on non-file parts #5

abotalov opened this issue Jan 16, 2017 · 0 comments · Fixed by #10
Labels
bug

Comments

@abotalov
Copy link
Contributor

abotalov commented Jan 16, 2017 •
edited
Loading

From RFC 7578:

Each part MAY have an (optional) "Content-Type" header field, which
defaults to "text/plain". If the contents of a file are to be sent,
the file data SHOULD be labeled with an appropriate media type, if
known, or "application/octet-stream".

Setting Content-Type for non-file parts is not currently supported.
@ixti ixti added the bug label Jan 18, 2017
ixti added a commit that referenced this issue Jan 18, 2017
@ixti
Set Content-Type on non-file parts
ff9bf3d 
Resolves #5
@ixti ixti mentioned this issue Jan 18, 2017
Closed
abotalov pushed a commit to abotalov/form_data.rb that referenced this issue Jan 21, 2017
Add support for non-file parts with Content-Type
b3fac90 
Also allow to create file parts without filename.
Fixes httprb#5, httprb#6
@abotalov abotalov mentioned this issue Jan 21, 2017
Merged
abotalov pushed a commit to abotalov/form_data.rb that referenced this issue Jan 22, 2017
@abotalov
Add support for non-file parts with Content-Type
e32388a 
Also allow to create file parts without filename.
Fixes httprb#5, httprb#6
@ixti ixti closed this as completed in #10 Jan 22, 2017
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Jun 5, 2017
Update ruby-http-form_data to 1.0.3.
b3eee8a 
## 1.0.3 (2017-05-18)

* [#16](httprb/form_data#16)
  Fix ruby < 2.0.0 support.
  [@ixti][]


## 1.0.2 (2017-05-08)

* [#5](httprb/form_data#5)
  Allow setting Content-Type non-file parts
  [@abotalov]

* [#6](httprb/form_data#6)
  Creation of file parts without filename
  [@abotalov]

* [#11](httprb/form_data#11)
  Deprecate `HTTP::FormData::File#mime_type`. Use `#content_type` instead.
  [@ixti]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RFC 7578 fixes abotalov/form_data.rb
2 participants
@ixti @abotalov