-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide high-level API to wire Celluloid::IO (socket classes, timeouts) #204
Comments
I dislike name of the method actually, and propose to name it HTTP.celluloid # => Celluloid-ready configured client |
For what it’s worth, I prefer your original suggestion. Hard-coding Celluloid configuration to a top-level method name limits the extensibility of this library. |
@sferik Anyway, I agree that hard-coding celluloid config as a top-level method is not a good idea after all. |
👍 for 👎 for My biggest objection to hardcoding |
|
+1 on use, can we deprecate the old Api in 1.0 too? Could make config a lot easier Sent from my iPhone
|
I would like not to deprecate but completely drop out any things we want to deprecate. :D UPDATE: in 1.0.0 release i mean |
Celluloid::IO support is effectively dropped in 1.0. It's something we can revive, but it requires work in the timeouts backend (which should probably be extracted into a separate gem) See #225 for continued discussion |
See: #203 (comment)
The text was updated successfully, but these errors were encountered: