Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide high-level API to wire Celluloid::IO (socket classes, timeouts) #204

Closed
ixti opened this issue Apr 6, 2015 · 8 comments
Closed

Comments

@ixti
Copy link
Member

ixti commented Apr 6, 2015

See: #203 (comment)

HTTP.backend(:celluloid)
@ixti ixti added this to the v0.9 milestone Apr 6, 2015
@ixti
Copy link
Member Author

ixti commented Apr 12, 2015

I dislike name of the method actually, and propose to name it celluloid :D

HTTP.celluloid # => Celluloid-ready configured client 

@sferik
Copy link
Contributor

sferik commented Apr 14, 2015

For what it’s worth, I prefer your original suggestion. Hard-coding Celluloid configuration to a top-level method name limits the extensibility of this library.

@ixti
Copy link
Member Author

ixti commented Apr 14, 2015

@sferik #backend was actually Tony's proposal :)) I was thinking about sortening that to #use or #with, but after thinking on exisitng chainable API though that adding #celluloid into Chainable module will be a good idea.

Anyway, I agree that hard-coding celluloid config as a top-level method is not a good idea after all.

@sferik
Copy link
Contributor

sferik commented Apr 14, 2015

👍 for #use.

👎 for #with, since that used to be an alias for #with_headers. IMHO, changing the API in this way would be confusing.

My biggest objection to hardcoding #celluloid is that it wouldn’t be easily extensible to alternate configurations without monkey patching the HTTP object, which could result in method name collisions.

@tarcieri
Copy link
Member

#use seems good to me

@zanker
Copy link
Contributor

zanker commented Apr 14, 2015

+1 on use, can we deprecate the old Api in 1.0 too? Could make config a lot easier

Sent from my iPhone

On Apr 14, 2015, at 08:48, Tony Arcieri notifications@github.com wrote:

#use seems good to me


Reply to this email directly or view it on GitHub.

@ixti
Copy link
Member Author

ixti commented Apr 14, 2015

I would like not to deprecate but completely drop out any things we want to deprecate. :D

UPDATE: in 1.0.0 release i mean

@ixti ixti modified the milestones: v1.1.0, v2.0.0 Nov 1, 2015
@tarcieri
Copy link
Member

Celluloid::IO support is effectively dropped in 1.0. It's something we can revive, but it requires work in the timeouts backend (which should probably be extracted into a separate gem)

See #225 for continued discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants