Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSupport dependency is missing #253

Closed
Fryie opened this issue Sep 6, 2015 · 7 comments
Closed

ActiveSupport dependency is missing #253

Fryie opened this issue Sep 6, 2015 · 7 comments

Comments

@Fryie
Copy link

Fryie commented Sep 6, 2015

The gem seems to use ActiveSupport methods in some places, e.g. here. In order to be compatible with non-Rails projects, the dependency should be included and the appropriate libraries required where necessary (should be detailed here).

@tarcieri
Copy link
Member

tarcieri commented Sep 7, 2015

That's a PR that just landed (#251). It's not intended for this gem to depend on ActiveSupport.

@tarcieri
Copy link
Member

tarcieri commented Sep 7, 2015

@zanker are the tests actually exercising that case? I'm surprised they didn't break

@tarcieri
Copy link
Member

tarcieri commented Sep 7, 2015

It looks like the certificate_authority gem pulls in activesupport. Perhaps we should get rid of it.

@Fryie
Copy link
Author

Fryie commented Sep 7, 2015

Oh, I see. In the meantime, I guess !data.empty? would fix the issue since it's probably always a string?

@tarcieri
Copy link
Member

tarcieri commented Sep 7, 2015

PR here: #254

@tarcieri
Copy link
Member

tarcieri commented Sep 7, 2015

This is now released as 0.9.6

@Fryie
Copy link
Author

Fryie commented Sep 7, 2015

This must be some of the quickest feedback i've seen on a library. :) thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants