Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Foundation Base64Encoding #394

Closed
Mazyod opened this issue Apr 16, 2019 · 1 comment · Fixed by #403
Closed

Use Foundation Base64Encoding #394

Mazyod opened this issue Apr 16, 2019 · 1 comment · Fixed by #403
Labels
enhancement

Comments

@Mazyod
Copy link
Contributor

Mazyod commented Apr 16, 2019

Hello again,

Just stumbled across the base64 implementation in this library, and would suggest it to be switched to use the one provided from Foundation. Happy to open a PR with the change if it's something you'd want. I would also suggest removing the extension and its tests in the future.

Mazyod@d82f504
@Vkt0r
Copy link
Member

Vkt0r commented May 1, 2019

Hey, @Mazyod sorry for the delay. Thanks for your suggestion and it makes a lot of sense to me to use the base64 encoding algorithm from Apple in Foundation. I would be happy to review your PR !

@Mazyod Mazyod mentioned this issue May 1, 2019
Merged
@Vkt0r Vkt0r closed this as completed in #403 May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Foundation API for Base64 Encoding Mazyod/swifter
2 participants
@Mazyod @Vkt0r