Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ES5 distribution? #4

Closed
spong opened this issue Oct 19, 2019 · 3 comments
Closed

Add ES5 distribution? #4

spong opened this issue Oct 19, 2019 · 3 comments

Comments

@spong
Copy link
Contributor

spong commented Oct 19, 2019

Hey @pimterry, came across this lib in the comments of facebook/react#13044, and it has been just the thing we needed to get react-beautiful-dnd draggables working from within other react component trees. So thanks for taking the time to put this together. 🙂

Anyway, as unfortunate as it is, our builds need to support IE11 for just a little while longer and so we need an ES5 distribution to do that.

I'm not sure if this is something you're open to including as it adds additional bloat and very few people need it, but I figured I'd ask. I've got this working over on my fork (spong@bddc939) and am happy to open a PR, but just wanted to create an issue to get your feedback first.

If this isn't something you're interested in supporting, no worries at all. We can add the appropriate attribution and build from source on our end in this interim period while we still have to support IE11.

Thanks again!

@pimterry
Copy link
Member

Awesome! I'm definitely open to considering that at least, feel free to send a PR.

Is it just that language features need to be compiled away, or is there something more fundamental that's not properly supported, like some of the DOM API or something?

@spong
Copy link
Contributor Author

spong commented Oct 21, 2019

Great! And yeah, it's just language features, no issue with any DOM API's. I went the babel route with the PR for better flexibility if need be. Give it a whirl and let me know what you think. I separated out the ES5 transpilation to it's own script (build-web) and call that from build.

Here's the PR: #5

Thanks! :)

@pimterry
Copy link
Member

Fixed in v1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants