-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to run benchmark in the CoRL20 paper #1131
Comments
I solved this error by using commend 'scl scenario build --clean scenarios/intersections/4lane',but new error happened,like below. |
Hello @zyk516, thank you for the question. I have a few things I can say about this. I remember that there were a few features of the scenario files that the CoRL20 code does not support. One of the features it does not support is the mission types that were experimental at the time; SMARTS/scenarios/intersections/4lane/scenario.py Lines 18 to 22 in c5a1608
The second issue is not quite as clear to me. It looks to be that somehow the observation and observation space does not match. Are you still running the same command as the first time (i.e. Next, @RutvikGupta is currently looking at rehabilitating the CoRL20 code for version 0.4.18 of SMARTS. @RutvikGupta if you have the chance could you look into if the If you have any further questions please ask. |
Hello.@Gamenot ,thank you for your reply. |
Hello.@RutvikGupta ,@Gamenot .The same error as #340 happened when I run the command above.The ray version is 1.0.1post, and smarts is 0.4.18, the code branch is SMARTS-marl_benchmark_path_fixes(When I used master branch, the error happened too.)How to solve this?I wish your replay.Thank you. |
I am surprised that this would happen. Looking through the I will investigate more. |
@zyk516 Is there any chance that an older version of |
Hello,@Gamenot .I tried vay1.18.0 and 0.8.7,the same error would happen.If I delete the line"export_formats: [model, checkpoint]" in baseline-lane-control.yaml, there is no error.And when i run the evaluate.py in benchmark, a new error as blow happened. |
For the AttributeError: 'NoneType' object has no attribute 'reset', I solved this by doing these things below. |
@RutvikGupta @Gamenot I have used the https://github.com/huawei-noah/SMARTS/tree/marl_benchmark_path_fixes branch and followed the readme instructions to run the MARL_Benchmark python3.7 run.py scenarios/intersections/4lane -f agents/ppo/baseline-lane-control.yaml --headless but I have landed up into the below issue Desired SMARTS version Operating System "ray[rllib]==1.0.1.post1" Problem item = next(self.rollout_provider) [41/1879] Can you please help with this soon? |
Hello.@Gamenot,Could you help me please? |
Hello @Gamenot @RutvikGupta @zyk516 I am also facing the same issue using the same SMARTS-marl_benchmark_path_fixes branch with ray version is 1.0.1post, and smarts is 0.4.18. This is a blocker for many i guess please kindly resolve soon |
The above error is fixed in this PR: #1126. Please use this PR branch to setup and run benchmark. |
This issue is being closed as the |
High Level Description
[I want to run benchmark in the CoRL20 paper [SMARTS: Scalable Multi-Agent ReinforcementLearning Training School for Autonomous Driving]]
Desired SMARTS version
[0.4.16]
Operating System
[ ubuntu 18.04]
Problems
When I run the commend ' python3.7 run.py /home/idriver/zyk/study/rl/SMARTS/benchmark/scenarios/intersections/4lane -f benchmark/agents/dqn/baseline-lane-control.yaml
', a AssertionError: EndlessGoal() happened,like below.
File "python/ray/_raylet.pyx", line 482, in ray._raylet.execute_task
File "python/ray/_raylet.pyx", line 436, in ray._raylet.execute_task.function_executor
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/util/iter.py", line 1152, in par_iter_next
return next(self.local_it)
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/evaluation/rollout_worker.py", line 317, in gen_rollouts
yield self.sample()
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/evaluation/rollout_worker.py", line 621, in sample
batches = [self.input_reader.next()]
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/evaluation/sampler.py", line 94, in next
batches = [self.get_data()]
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/evaluation/sampler.py", line 211, in get_data
item = next(self.rollout_provider)
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/evaluation/sampler.py", line 550, in _env_runner
base_env.poll()
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/env/base_env.py", line 390, in poll
obs[i], rewards[i], dones[i], infos[i] = env_state.poll()
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/env/base_env.py", line 442, in poll
self.reset()
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/ray/rllib/env/base_env.py", line 460, in reset
self.last_obs = self.env.reset()
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/benchmark/wrappers/rllib/frame_stack.py", line 204, in reset
return self._get_observations(observations)
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/benchmark/wrappers/rllib/frame_stack.py", line 160, in get_observations
observation = self.observation_adapter(observation)
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/benchmark/wrappers/rllib/frame_stack.py", line 119, in func
observation = cal_obs(env_obs_seq, observation_space, feature_configs)
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/benchmark/common.py", line 889, in cal_obs
obs_np.append(cal_obs(obs, sub_space, feature_configs))
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/benchmark/common.py", line 884, in cal_obs
obs_np[name] = getattr(CalObs, f"cal{name}")(env_obs, *args)
File "/home/idriver/zyk/study/rl/SMARTS/baselines/marl_benchmark/.venv/lib/python3.7/site-packages/benchmark/common.py", line 174, in cal_goal_relative_pos
assert isinstance(goal, PositionalGoal), goal
AssertionError: EndlessGoal()
The text was updated successfully, but these errors were encountered: