Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ims): support evs_data_image resource #5443

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Aug 23, 2024

What this PR does / why we need it:

Support evs_data_image resource

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


Support `evs_data_image` resource

PR Checklist

  • Tests added/passed.

evs_data_image resource

$ make testacc TEST="./huaweicloud/services/acceptance/ims" TESTARGS="-run TestAccEvsDataImage_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ims -v -run TestAccEvsDataImage_basic -timeout 360m -parallel 4
=== RUN   TestAccEvsDataImage_basic
=== PAUSE TestAccEvsDataImage_basic
=== CONT  TestAccEvsDataImage_basic
--- PASS: TestAccEvsDataImage_basic (450.10s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ims       450.141s

ecs_system_image resource

$ make testacc TEST="./huaweicloud/services/acceptance/ims" TESTARGS="-run TestAccEcsSystemImage_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ims -v -run TestAccEcsSystemImage_basic -timeout 360m -parallel 4
=== RUN   TestAccEcsSystemImage_basic
=== PAUSE TestAccEcsSystemImage_basic
=== CONT  TestAccEcsSystemImage_basic
--- PASS: TestAccEcsSystemImage_basic (545.05s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ims       545.090s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 436ad4d into huaweicloud:master Aug 26, 2024
35 checks passed
@jinyangyang222 jinyangyang222 deleted the feat-ims/support-evs_data_image branch September 11, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants