Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler #357

Closed
justin-wesley opened this issue May 5, 2017 · 5 comments
Closed

Update compiler #357

justin-wesley opened this issue May 5, 2017 · 5 comments

Comments

@justin-wesley
Copy link

justin-wesley commented May 5, 2017

With JDK 5 being end of life for many many years, it is time to move to JDK 8. I think you should create a branch for JDK 8 and even JDK 9, so contributors can use the newer JDK.

@Shredder121
Copy link
Contributor

The issue is, that class file formats are forwards compatible, so the lowest common denominator is in most cases the best pick.
On the other end of the scale, there are the new features, so it's balancing those two.

I'm getting the impression that the new features aren't that important to this project, or at least not more important than compatibility.

@oleg-nenashev
Copy link
Collaborator

If somebody proposes a change where Java 6 + is really required, I am sure it will be considered. I do not see much need in enforcing the version until that though it would be possible to refactor the code a bit

@KostyaSha
Copy link
Contributor

To make closeable client? I think it easier to fork this library.

@oleg-nenashev
Copy link
Collaborator

To make closeable client? I think it easier to fork this library.

It is a reasonable improvement. So just create a PR ;)

@kohsuke
Copy link
Collaborator

kohsuke commented Sep 9, 2017

I agree with @oleg-nenashev

Updating class file version first is like a cart before a horse. Let somebody propose a change that benefits from newer version of Java.

@kohsuke kohsuke closed this as completed Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants