-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push a versioned tag of the docker image when new Scaphandre releases are created #152
Comments
@rossf7 thank you for sharing the action 👍 What I would like to see (does not means it is the right thing to do ;-) ) is getting access to both a stable (released) and unstable version (dev).
Idea is to permit easy integration or testing of the latest functionalities (by requesting docker hub for the Does this sounds right to you ? |
@demeringo thanks I like the idea as it would be useful for testing the latest functionality. It should be possible with a simple change to the github action. I'll give it a try and let you know how it goes.
|
@demeringo yes it works it just needs a small change to the docker-metadata action.
@bpetit What do you think to setting up this tagging? |
This would be great. Moreover, w'ell need different tags to provide scaphandre built with different features or sensors. Feel free to bootstrap that in PRs, and thanks a lot. The tagging pattern you proposed suits me well ! |
I opened #160 to add the action. |
Thx! @bpetit <3 |
Problem
I would like to use a tagged version of the docker image instead of the latest tag. So the version of scaphandre is predictable.
Solution
This can be automated using the docker build-push-action. This will push a new tag to docker hub when a new git tag is created.
This can be combined with the docker metadata-action which will set the latest tag according to semver and add some useful labels to the docker image.
I tried this out in my fork and it seems to work well. I just needed to disable the push step because secrets aren't passed for forked repos. Here is the action and an example run.
Alternatives
Pushing the image can be done many ways but I like the idea of using these actions since they are maintained by Docker.
The text was updated successfully, but these errors were encountered: