Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think whether there is a scroll bar that needs to be made configurable #1954

Closed
TD-gaowei opened this issue Oct 14, 2021 · 3 comments
Closed
Labels
bug Something isn't working up-for-grabs

Comments

@TD-gaowei
Copy link

Describe the bug
A clear and concise description of what the bug is.

I have a product that displays some content through the coverComponent. The content is relatively long and will produce scroll bars.

My problem is that the scroll bar does not support wheel scrolling, it can only be dragged

I checked the source code and found that you traverse all the parent elements of the DOM element after mouseover by the mouse, and shield the mousewheel event, causing the scroll bar to fail to scroll through the wheel.

so, you can make the scroll bar configurable

To Reproduce
Steps to reproduce the behaviour:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error
  5. Intuition about the error / Proposed solution (optional)

What is the expected behaviour?
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

About the environment
Which versions of botonic packages, and which browser/OS or environment (development/production) are affected by this issue? Did this work in previous versions of botonic packages?

Additional context
Add any other context about the problem here.

@TD-gaowei TD-gaowei added the bug Something isn't working label Oct 14, 2021
@vanbasten17
Copy link
Contributor

Hi @weigaosS , thanks for reporting! I see the point. Now we are currently working on the 1.0 version of Botonic so we will take this into account in order to be prioritized. By the way, you can create a Pull Request to do the fix, let's contact in Slack if you need further support on achieving it. We'll be happy to help here =)

@tsxoxo
Copy link

tsxoxo commented Oct 18, 2021

Would also be up to look into this, if y'all cool with it!

@vanbasten17
Copy link
Contributor

merged and published within @botonic/react's v0.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working up-for-grabs
Projects
None yet
Development

No branches or pull requests

3 participants