Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create swagger configuration route #100

Merged
merged 3 commits into from
May 17, 2019
Merged

Conversation

LTMenezes
Copy link
Contributor

Closes #24.

In addition to adding the 'API_VALIDATOR_URL' configuration that we discussed, I took the opportunity to also make all the swagger-ui configuration customizable.

This way the user can set any configuration described in https://swagger.io/docs/open-source-tools/swagger-ui/usage/configuration/.

Example of code:
app.config.SWAGGER_UI_CONFIGURATION = { 'validatorUrl': None, 'displayRequestDuration': True, 'docExpansion': 'full' }

What do you guys think?
@hampsterx @chenjr0719

Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool. But, could you add your example to README.md or under examples/? Or the users still don't know how to use it.

@LTMenezes
Copy link
Contributor Author

Great @chenjr0719!
I agree with both of your points, I just updated the PR.

@ahopkins ahopkins merged commit 93199fe into sanic-org:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline/firewalled mode
3 participants