Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audio installation doc page #5494

Closed
polinaeterna opened this issue Feb 1, 2023 · 4 comments
Closed

Update audio installation doc page #5494

polinaeterna opened this issue Feb 1, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@polinaeterna
Copy link
Contributor

Our installation documentation page says that one can use Datasets for mp3 only with torchaudio<0.12. torchaudio>0.12 is actually supported too but requires a specific version of ffmpeg which is not easily installed on all linux versions but there is a custom ubuntu repo for it, we have insctructions in the code: https://github.com/huggingface/datasets/blob/main/src/datasets/features/audio.py#L327
So we should update the doc page. But first investigate this issue.

@polinaeterna polinaeterna added the documentation Improvements or additions to documentation label Feb 1, 2023
@albertvillanova
Copy link
Member

Totally agree, the docs should be in sync with our code.

Indeed to avoid confusing users, I think we should have updated the docs at the same time as this PR:

@polinaeterna
Copy link
Contributor Author

polinaeterna commented Feb 2, 2023

@albertvillanova yeah sure I should have, but I forgot back then, sorry for that 😶

@albertvillanova
Copy link
Member

No, @polinaeterna, nothing to be sorry about.

My comment was for all of us datasets team, as a reminder: when making a PR, but also when reviewing some other's PR, we should not forget to update the corresponding docstring and doc pages. It is something we can improve if we help each other in reminding about it... 🤗

@mariosasko
Copy link
Collaborator

@polinaeterna I think we can close this issue now as we no longer use torchaudio for decoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants