Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of data split names is nondeterministic #5728

Closed
albertvillanova opened this issue Apr 11, 2023 · 0 comments · Fixed by #5729
Closed

The order of data split names is nondeterministic #5728

albertvillanova opened this issue Apr 11, 2023 · 0 comments · Fixed by #5729
Assignees
Labels
bug Something isn't working

Comments

@albertvillanova
Copy link
Member

After this CI error: https://github.com/huggingface/datasets/actions/runs/4639528358/jobs/8210492953?pr=5718

FAILED tests/test_data_files.py::test_get_data_files_patterns[data_file_per_split4] - AssertionError: assert ['random', 'train'] == ['train', 'random']
  At index 0 diff: 'random' != 'train'
  Full diff:
  - ['train', 'random']
  + ['random', 'train']

I have checked locally and found out that the data split order is nondeterministic.

This is caused by the use of set for sharded splits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant