Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP support for Mistral-7b #303

Merged
merged 6 commits into from
Nov 24, 2023
Merged

TP support for Mistral-7b #303

merged 6 commits into from
Nov 24, 2023

Conversation

michaelbenayoun
Copy link
Member

@michaelbenayoun michaelbenayoun commented Nov 9, 2023 •
edited
Loading

This PR enables distributed training for the Mistral architecture.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@dacorvo
Copy link
Collaborator

dacorvo commented Nov 23, 2023

Here come the numpy errors again:

RuntimeError: Failed compilation with ['neuronx-cc', '--target=trn1', 'compile', '--framework', 'XLA', '/tmp/ubuntu/neuroncc_compile_workdir/3240483d-9e28-412f-94d4-a780ee2d02f4/model.MODULE_10323388975015170861+abb26765.hlo.pb', '--output', '/tmp/ubuntu/neuroncc_compile_workdir/3240483d-9e28-412f-94d4-a780ee2d02f4/model.MODULE_10323388975015170861+abb26765.neff', '--model-type=transformer', '--verbose=35']: RuntimeError: module compiled against API version 0xf but this version of numpy is 0xe

dacorvo
dacorvo approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: nice !

JingyaHuang
JingyaHuang approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@michaelbenayoun michaelbenayoun merged commit 123aabc into main Nov 24, 2023
8 checks passed
@michaelbenayoun michaelbenayoun deleted the mistral branch November 24, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingyaHuang JingyaHuang JingyaHuang approved these changes

@dacorvo dacorvo dacorvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbenayoun @HuggingFaceDocBuilderDev @dacorvo @JingyaHuang