-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ONNX export support for PatchTST
#2101
Open
xenova
wants to merge
5
commits into
main
Choose a base branch
from
add-patchtst-onnx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
xenova
commented
Nov 28, 2024
Comment on lines
+119
to
+124
def onnx_compatible_unfold(self, dimension, size, step): | ||
num_patches = (self.size(dimension) - size) // step + 1 | ||
return torch.stack( | ||
[self[:, i : i + size, :] for i in range(0, num_patches * step, step)], | ||
dim=1, | ||
).transpose(3, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into some issues with my naive attempt (only seems to work for 4D). Here's a better version I found:
Suggested change
def onnx_compatible_unfold(self, dimension, size, step): | |
num_patches = (self.size(dimension) - size) // step + 1 | |
return torch.stack( | |
[self[:, i : i + size, :] for i in range(0, num_patches * step, step)], | |
dim=1, | |
).transpose(3, 2) | |
def onnx_compatible_unfold(input_tensor, dimension, size, step): | |
""" | |
Custom implementation of torch.unfold without using torch.unfold. | |
Args: | |
input_tensor (torch.Tensor): The input tensor. | |
dimension (int): The dimension to unfold. | |
size (int): The size of each slice. | |
step (int): The step size between slices. | |
Returns: | |
torch.Tensor: The unfolded tensor. | |
""" | |
# Compute the shape of the unfolded output | |
input_size = input_tensor.size(dimension) | |
num_slices = (input_size - size) // step + 1 | |
# Permute dimension to the end for easier indexing | |
input_tensor = input_tensor.transpose(dimension, -1) | |
# Extract slices | |
slices = [] | |
for i in range(num_slices): | |
start = i * step | |
end = start + size | |
slices.append(input_tensor[..., start:end]) | |
# Stack slices and permute dimensions back | |
result = torch.stack(slices, dim=-2).transpose(dimension, -2) | |
return result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds ONNX export support for PatchTST models, as well as fixes other models that contain the
torch.unfold
operator, which is not supported bytorch.onnx.export
. This is done by applying a set of default patching specs.Fixes huggingface/transformers.js#1047
Before submitting
Who can review?
@michaelbenayoun, @echarlaix