Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make bench" command does not download all required resources #1425

Closed
zamazan4ik opened this issue Jan 7, 2024 · 0 comments · Fixed by #1428
Closed

"make bench" command does not download all required resources #1425

zamazan4ik opened this issue Jan 7, 2024 · 0 comments · Fixed by #1428

Comments

@zamazan4ik
Copy link

Hi!

I checked out the repo on the main branch with f1c23b868006ee27acdd31796677f82fa10d6bd7 commit, cd-ed to tokenizers directory, and ran make bench command. Instead of successful benchmark run, I got the following error:

     Running benches/layout_benchmark.rs (target/release/deps/layout_benchmark-1f68f2f9387775b7)
thread 'main' panicked at benches/layout_benchmark.rs:28:80:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `--bench layout_benchmark`

The reason is that make bench command does not download Albert test resource for layout_benchmark referenced here.

It could be fixed locally by running make test before make bench - it downloads all required files. But I think it should be fixed in another way - make bench command should be isolated and download all required test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant