-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable average tokens across devices #34373
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
590a522
enable average tokens across devices
techkang 647203b
reduce earlier in case model needs it
techkang 8fd583d
simplify if statement
techkang 190d534
reformat code to make ruff happy
techkang ae9fbe9
add doc for argument: average_tokens_across_devices
techkang 4c8d02f
Merge branch 'main' into main
muellerzr 70919a1
Merge branch 'main' into main
techkang 8ca8c4d
cannot find world size when pytorch is unavailable
techkang 1eab209
format code
techkang cdbb3d3
Merge branch 'main' into main
muellerzr bd8ae99
Merge branch 'main' into main
ArthurZucker 588a80e
Merge branch 'main' into main
muellerzr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We modified a lot how loss is computed, are we sure that this is loss is the same as the one applied ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, it should be
loss.detach() / self.args.gradient_accumulation_steps / self.accelerator.num_processes
(dividing by num processes if and only if we did our loss function num tokens logic)