From c1c04c0ec0739854ba914cc9f02cc58e2f5de480 Mon Sep 17 00:00:00 2001 From: James Hughes Date: Mon, 13 Mar 2023 03:43:01 +0000 Subject: [PATCH] fix: Hotfixed dodgy base name in DI, added test to prevent future regression --- .../DependencyInjectionExtensionsTests.cs | 14 ++++++++++++++ .../DependencyInjectionExtensions.cs | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection.Tests/DependencyInjectionExtensionsTests.cs b/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection.Tests/DependencyInjectionExtensionsTests.cs index 91a43f7..f0b3c0e 100644 --- a/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection.Tests/DependencyInjectionExtensionsTests.cs +++ b/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection.Tests/DependencyInjectionExtensionsTests.cs @@ -1,5 +1,6 @@ using CelesTrakSdk.Microsoft.Extensions.DependencyInjection.DependencyInjection; using CelesTrakSdk.Public.Clients; +using CelesTrakSdk.Public.Models.Enums; using Microsoft.Extensions.DependencyInjection; using Shouldly; @@ -19,4 +20,17 @@ public void CanGetClientFromServiceProvider() client.ShouldNotBeNull(); } + + [Fact] + public async Task CanGetResultFromResolvedClient() + { + IServiceCollection collection = new ServiceCollection(); + _ = collection.AddCelesTrakServices(); + + ServiceProvider provider = collection.BuildServiceProvider(); + ICelesTrakClient? client = provider.GetService(); + + client.ShouldNotBeNull(); + await Should.NotThrowAsync(async () => await client.GetRecords(SatCatRecordQueryType.Group, "STATIONS")); + } } diff --git a/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection/DependencyInjection/DependencyInjectionExtensions.cs b/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection/DependencyInjection/DependencyInjectionExtensions.cs index d555c56..01cf4ac 100644 --- a/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection/DependencyInjection/DependencyInjectionExtensions.cs +++ b/src/CelesTrakSdk.Microsoft.Extensions.DependencyInjection/DependencyInjection/DependencyInjectionExtensions.cs @@ -8,7 +8,7 @@ public static class DependencyInjectionExtensions { public static IServiceCollection AddCelesTrakServices(this IServiceCollection services) { - services.AddHttpClient(h => h.BaseAddress = new("https://celestrak.org/satcat/records.php")); + services.AddHttpClient(h => h.BaseAddress = new("https://celestrak.org/")); return services; }