-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix js loading and 404 page #24
Conversation
✅ Deploy Preview for hugo-blog-awesome ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @kusyka911. Thanks for providing all the details and for creating this PR. I really appreciate your contribution to this theme. I liked your fix regarding the 404 page. I also liked what you have done with the links - using relative URLs instead of absolute ones. I'm just trying to do a little investigation with the script loading issue. If you take a look at the demo site, you can observe that there are no such errors. The developer tools console is clean. I have not been able to reproduce the issue with loading scripts. Can you please tell what was the |
@hugo-sid issue with script loading appear ONLY when you using For debugging with phone you may use this
I think this is also a problem of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kusyka911 for this PR.
You have made a significant contribution to this theme.
Looking forward to more contributions from you.
Have a good day. Happy blogging 🙂
What problem does this PR solve?
Updated design of 404 page
before:
after:
Fix issues with loading scripts
This issue exists when using hugo development server and remote device for testing. See screenshot bellow.
Website is loaded from remote IP like
10.0.0.194
but it's trying to load scripts fromlocalhost
. Same issue with link inpostCard
component.Is this PR adding a new feature?
No
Is this PR related to any issue or discussion?
No
PR Checklist