Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable text on selection #61

Closed
hugoattal opened this issue Jan 5, 2021 · 1 comment
Closed

Unreadable text on selection #61

hugoattal opened this issue Jan 5, 2021 · 1 comment
Assignees
Labels
bug Something isn't working pending Pending approval ready Issue is fixed and ready to be deployed
Milestone

Comments

@hugoattal
Copy link
Owner

The text is unreadable on textfields when selected

image

@hugoattal hugoattal added the bug Something isn't working label Jan 5, 2021
@hugoattal hugoattal added this to the 1.7 milestone Jan 6, 2021
@hugoattal
Copy link
Owner Author

I spent a fair amount of time searching for how to define this highlight color.

  • The color is not constant
  • The color vary depending on "foregroundColor" (aka the color of the text)
  • The color is FLinearColor(0,0,0.15) when text is white
  • The color is FLinearcolor(0.3,0.45,0.65) when text is black

But I can't find the logic related to it... It might be near
Runtime/Slate/Private/Framework/Text/SlateTextHighlightRunRenderer.cpp
But I didn't find it. (And I suspect this is some highlight for search)

Thought, I found a solution to make it readable even if that's not ideal: making the text white semi-transparent.
image

I think it's okay, I might find another solution in the future. (If it's not OS-related, because I'm still not 100% sure)

@hugoattal hugoattal added the ready Issue is fixed and ready to be deployed label Jan 6, 2021
@hugoattal hugoattal self-assigned this Jan 6, 2021
@hugoattal hugoattal added the pending Pending approval label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending Pending approval ready Issue is fixed and ready to be deployed
Projects
None yet
Development

No branches or pull requests

1 participant