Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing lodash dependency declaration causes error in latest version of Gutenberg plugin #136

Open
goldenapples opened this issue Sep 8, 2023 · 1 comment
Open

Missing lodash dependency declaration causes error in latest version of Gutenberg plugin #136

goldenapples opened this issue Sep 8, 2023 · 1 comment
Labels
Bug

Comments

@goldenapples
Copy link
Contributor

Recently Gutenberg finished removing all usage of lodash: WordPress/gutenberg#17025 (comment)

Because the editor scripts in Authorship still rely on lodash, but it's not declared as a dependency, they fail in the latest version of the Gutenberg plugin:

Uncaught ReferenceError: lodash is not defined

It would be good to either rewrite code that depends on lodash or declare it as a dependency.
@tomjn tomjn changed the title Missing lodash dependency declaration causes error in latest version of Gutneberg plugin Missing lodash dependency declaration causes error in latest version of Gutenberg plugin Sep 25, 2023
@tomjn
Copy link
Contributor

tomjn commented Sep 25, 2023

Looks like uses are confined to the AuthorsSelect.tsx https://github.com/humanmade/authorship/blob/develop/src/components/AuthorsSelect.tsx file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomjn @goldenapples