Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to turn asserts into exceptions and fix EPA related assert #533

Merged

Conversation

lmontaut
Copy link
Contributor

No description provided.

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@jorisv jorisv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see other assert in src and include. Are you sure none of them should be turn into exception (velocity issue, assertion that really should never happen) ?

src/CMakeLists.txt Outdated Show resolved Hide resolved
@lmontaut
Copy link
Contributor Author

I see other assert in src and include. Are you sure none of them should be turn into exception (velocity issue, assertion that really should never happen) ?

Yes there probably are other assertions that should be turned into exceptions but I think the best for now is to introduce the macro and as we work on the project, we will convert the asserts we need into this macro.

@jcarpent jcarpent merged commit 0067160 into coal-library:devel Feb 13, 2024
34 checks passed
@lmontaut lmontaut deleted the louis/topic/turn-asserts-to-exceptions branch February 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants