fix: export types for typescript #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TypeScript's module system is set to `NodeNext` (as [recommended](https://www.typescriptlang.org/tsconfig#module)), the types cannot be found because they are not present in the export map. This change fixes the problem by adding the types to the export map. Additionally: - it reconfigures the "types" test fixture to: - use `strict` mode - `module: NodeNext` - enables lib checking (thus validating `env.d.ts`) - runs `tsc --build` on `npm install` - updates `types.test.js` accordingly - upgrades `typescript` to latest - fix `pkg.test.mjs` to correctly reference the updated export map
|
Note that PR #76 also does some of this. |
|
Basically, the state of the "types" test was kind of a false positive. |
|
Sorry I missed this...not sure why I wasn't getting notifications for this repo. Thanks. Still learning the ins and outs of types using JavaScript rather than TypeScript. |
|
@nzakas No worries. I'm happy to help with this repo if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TypeScript's module system is set to
NodeNext(as recommended), the types cannot be found because they are not present in the export map.This change fixes the problem by adding the types to the export map. Additionally:
strictmodemodule: NodeNextenv.d.ts)tsc --buildonnpm installtypes.test.jsaccordinglytypescriptto latestpkg.test.mjsto correctly reference the updated export map