Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons to have focus event #459

Closed
pricetula opened this issue Apr 15, 2024 · 2 comments · May be fixed by #469
Closed

Buttons to have focus event #459

pricetula opened this issue Apr 15, 2024 · 2 comments · May be fixed by #469
Labels
help wanted Open to contributions Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.

Comments

@pricetula
Copy link

Describe the feature in detail (code, mocks, or screenshots encouraged)

Html buttons have focus event fires when an element has received focus. Currently one is not able to listen to on:focus event on a button.
example of on:focus
<button on:focus={handleButtonFocused}>...</button> or event forward the focus event <button on:focus>...</button>

What type of pull request would this be?

Enhancement

Provide relevant links or additional information.

component concerned: https://www.bits-ui.com/docs/components/button
example of focus event in svelte: https://svelte.dev/repl/dbeabf42636545b3a8dc6ebe84c2d98c?version=3.17.3

@huntabyte huntabyte added the help wanted Open to contributions label Apr 15, 2024
@huntabyte huntabyte mentioned this issue Jun 9, 2024
3 tasks
@huntabyte huntabyte added the Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5. label Jun 27, 2024
@huntabyte
Copy link
Owner

If someone wants to add this to the current version of Bits I'll more than happy merge / release.

@huntabyte huntabyte mentioned this issue Jul 31, 2024
70 tasks
@huntabyte
Copy link
Owner

Closing as fixed in bits-ui@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open to contributions Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants