Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropdownMenu.Item disabled prop does not work as expected #527

Closed
AndersRobstad opened this issue Apr 30, 2024 · 1 comment · May be fixed by #469
Closed

DropdownMenu.Item disabled prop does not work as expected #527

AndersRobstad opened this issue Apr 30, 2024 · 1 comment · May be fixed by #469
Labels
Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.

Comments

@AndersRobstad
Copy link

AndersRobstad commented Apr 30, 2024 •
edited
Loading

Describe the bug

When passing in disabled=true to the DropdownMenu.Item component the component will still perform on:click actions even if being disabled. The component gets the correct styling for being disabled, but is still possible to interact with by clicking on it

Reproduction

https://stackblitz.com/edit/github-detrjx?file=src%2Froutes%2F%2Bpage.svelte

Logs

No response

System Info

System:
    OS: macOS 14.3.1
    CPU: (10) arm64 Apple M2 Pro
    Memory: 97.55 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.9.0/bin/npm
    pnpm: 9.0.6 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 124.0.6367.91
    Safari: 17.3.1
  npmPackages:
    @sveltejs/kit: ^2.5.7 => 2.5.7
    bits-ui: ^0.21.5 => 0.21.5
    svelte: ^4.2.15 => 4.2.15

Severity

annoyance
@huntabyte huntabyte mentioned this issue Jun 20, 2024
Open
3 tasks
@huntabyte huntabyte mentioned this issue Jul 31, 2024
Closed
70 tasks
@huntabyte huntabyte added the Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5. label Oct 3, 2024
@huntabyte
Copy link
Owner

Closing as fixed in bits-ui@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

next: Svelte 5 huntabyte/bits-ui
2 participants
@AndersRobstad @huntabyte