Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled property of Menubar item is not reactive #537

Closed
vcoppe opened this issue May 4, 2024 · 2 comments · Fixed by #469
Closed

Disabled property of Menubar item is not reactive #537

vcoppe opened this issue May 4, 2024 · 2 comments · Fixed by #469
Labels
bug Something isn't working contributions welcome Open to contributions

Comments

@vcoppe
Copy link

vcoppe commented May 4, 2024

Describe the bug

Setting disabled={$someBooleanStore} on a Menubar.Item does not trigger updates when the store is updated, unless the menu is closed and reopened. I've created a small example that shows that normal HTML buttons update but not the bits-ui component.

Thank you for developing and maintaining this library and shadcn-svelte, it's super smooth to use!
Let me know if there is anything I can do to help fixing this.

Reproduction

https://svelte.dev/repl/80a41d66661f46f0a803935a22ef405f?version=4.2.15

Logs

No response

System Info

Tested on Firefox and Chrome with the latest bits-ui version.

Severity

annoyance

@huntabyte huntabyte mentioned this issue Jun 9, 2024
3 tasks
@huntabyte huntabyte added bug Something isn't working contributions welcome Open to contributions labels Jul 9, 2024
@huntabyte huntabyte mentioned this issue Jul 31, 2024
70 tasks
@aloussase
Copy link

This also happens with Accordion, #654

@huntabyte
Copy link
Owner

Closing as fixed in bits-ui@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contributions welcome Open to contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants