Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple context menu and closeOnOutsideClick not working correctly #563

Closed
rogerfar opened this issue Jun 1, 2024 · 1 comment · May be fixed by #469
Closed

Multiple context menu and closeOnOutsideClick not working correctly #563

rogerfar opened this issue Jun 1, 2024 · 1 comment · May be fixed by #469
Labels
Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.

Comments

@rogerfar
Copy link

rogerfar commented Jun 1, 2024

Describe the bug

When having multiple ContextMenu's and you right click to open another one, the original one stays open, even with closeOnOutsideClick set.

The 2nd issue is that, when click outside (left click), it only closes the last opened context menu, so you have to click multiple times to close them all.

Reproduction

https://stackblitz.com/edit/github-tbmdqu?file=src%2Froutes%2F%2Bpage.svelte

Logs

No response

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (24) x64 13th Gen Intel(R) Core(TM) i7-13700       
    Memory: 33.16 GB / 63.79 GB
  Binaries:
    Node: 20.13.1 - C:\Program Files\nodejs\node.EXE        
    Yarn: 1.22.19 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 10.8.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (125.0.2535.67)
    Internet Explorer: 11.0.19041.4355
  npmPackages:
    @sveltejs/kit: ^2.5.10 => 2.5.10
    bits-ui: ^0.21.10 => 0.21.10
    svelte: ^4.2.17 => 4.2.17

Severity

annoyance

@huntabyte huntabyte mentioned this issue Jun 9, 2024
3 tasks
@huntabyte huntabyte added the Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5. label Jun 27, 2024
@huntabyte huntabyte mentioned this issue Jul 31, 2024
70 tasks
@huntabyte
Copy link
Owner

Closing as fixed in bits-ui@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants