Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Combobox component with the bits ui primitive #917

Open
TheOnlyTails opened this issue Mar 17, 2024 · 5 comments
Open

Create a Combobox component with the bits ui primitive #917

TheOnlyTails opened this issue Mar 17, 2024 · 5 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@TheOnlyTails
Copy link
Contributor

TheOnlyTails commented Mar 17, 2024

Describe the feature

Bits UI has its own Combobox primitive now, so we shouldn't need to do a hack with the command and popover components

@TheOnlyTails TheOnlyTails added the type: feature Introduction of new functionality to the application label Mar 17, 2024
@huntabyte
Copy link
Owner

Until a similar component is in the original, it won't be added here. You are more than welcome to create a combobox using Bits' Combobox in your project if you wish.

@huntabyte huntabyte closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@huntabyte
Copy link
Owner

Reopening to reconsider

@huntabyte huntabyte reopened this Mar 25, 2024
@ThatXliner
Copy link

I would love it if we could use the bits ui combobox

@jlforcherio99
Copy link

Performance for ~3000 rows is not great for the Combobox example provided on the ShadCn docs, but it seems a bit better using the BitsUI combobox. Definitely would be interested for our use case.

@tzezar
Copy link

tzezar commented Apr 23, 2024

Performance for ~3000 rows is not great for the Combobox example provided on the ShadCn docs, but it seems a bit better using the BitsUI combobox. Definitely would be interested for our use case.

For such large data sets, virtualization should be used anyway. I can't imagine rendering 3000 elements in one select on some older device. However, more performance is nice anyway! 💪🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

5 participants