-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IX] - PDF sidepanel oversized documents #7455
Comments
@konzz The problem seems to be with
The scale has been set to 1.1. This is causing the bigger size on the pdf sidepanel, and the distortion of the text selection. When rending a pdf in the library we still use the old pdfjs component that render the pdf with a scale of 1. I think that that discrepancy in scales between components is breaking the selections and making the pdf bigger. I don't see an immediate reason as to why the pdf sidepanel's scale was set to 1.1. The scale should be kept at 1 in my opinion, or at least always match both in pdf sidepanel and entity view. The pdf sidepanel e2e test is done as part of There are other elements of |
@Zasa-san the best way to test it is to play with the browser zoom scale, since PDF rendering and scaling varies depending on the screen resolution. |
After some testing this seems to affect primarily users who are using some kind of zoom factor either in the browser or the OS display settings. This is unrelated to #7393 and should not affect selections. I'm attempting to better handle pdfjs's rendering of pages to solve this zoom problem. |
@aphilop @konzz we seem to have a new problem related to the size of the PDF on the side panel, so we may need to promote this issue to high priority.
Now the document is rendered oversized:
Tested on FF and Chrome
Originally posted by @txau in #7393 (comment)
The text was updated successfully, but these errors were encountered: