Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added arxiv retriever #4538

Merged
merged 1 commit into from
May 12, 2023
Merged

added arxiv retriever #4538

merged 1 commit into from
May 12, 2023

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented May 11, 2023 •
edited
Loading

Added the arxiv retriever

Who can review?

   - @dev2049

@leo-gan leo-gan changed the title added arxiv retriever added arxiv retriever May 11, 2023
@leo-gan leo-gan marked this pull request as ready for review May 11, 2023 23:06
hwchase17
hwchase17 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i actually really like this. looks great!

@dev2049 dev2049 merged commit e17d031 into langchain-ai:master May 12, 2023
@leo-gan leo-gan deleted the arxiv_retriever branch May 12, 2023 15:16
eyurtsev
eyurtsev reviewed May 12, 2023
View reviewed changes
langchain/retrievers/arxiv.py
from langchain.utilities.arxiv import ArxivAPIWrapper


class ArxivRetriever(BaseRetriever, ArxivAPIWrapper):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to change ArxivAPIWrapper into a DocumentLoader
and create a compositional pattern that allows upgrading a document loader into a retriever so we don't end up with double inheritance?

@hwchase17 @leo-gan

@eyurtsev
Copy link
Collaborator

@leo-gan I REALLY like this PR and demo!

@hp0404 hp0404 mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev left review comments

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leo-gan @eyurtsev @hwchase17 @dev2049