From 37e5921bc1b46cd98b133668f6859922571b7a23 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Sun, 25 Feb 2024 18:39:43 +0100
Subject: [PATCH 01/90] Initial feature abstract

---
 docs/digging-deeper/advanced-markdown.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index bf58e739fd1..3b13d463bed 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -156,6 +156,14 @@ anything within the path label will be rendered as HTML. This means you can add
 ```
 ````
 
+### Dynamic Markdown links
+
+In order to create automatically resolved links from your pages and posts, you can use the special Hyde Markdown link syntax.
+
+For all the supported syntax options, Hyde will resolve a relative link based on the current page being rendered.
+
+Since this happens in our Markdown processor, this will work regardless of if you have custom HTML or Blade enabled for your site.
+
 ### Limitations
 
 The filepaths are hidden on mobile devices using CSS to prevent them from overlapping with the code block.

From 1f9912865a541e331c97f92364a10363331be61c Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Sun, 25 Feb 2024 18:39:48 +0100
Subject: [PATCH 02/90] Add examples

---
 docs/digging-deeper/advanced-markdown.md | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 3b13d463bed..0256ed6458f 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -164,6 +164,24 @@ For all the supported syntax options, Hyde will resolve a relative link based on
 
 Since this happens in our Markdown processor, this will work regardless of if you have custom HTML or Blade enabled for your site.
 
+#### Resolving a route
+
+```markdown
+[Home](hyde::route('home'))
+```
+
+#### Resolving a relative link
+
+```markdown
+[Home](hyde::relativeLink('home'))
+```
+
+#### Resolving a media asset
+
+```markdown
+![Image](hyde::media('image.jpg'))
+```
+
 ### Limitations
 
 The filepaths are hidden on mobile devices using CSS to prevent them from overlapping with the code block.

From 04dcd92ddbfd8bc395df8d9d40917cb378033a3c Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Sun, 25 Feb 2024 18:43:05 +0100
Subject: [PATCH 03/90] Streamline examples

---
 docs/digging-deeper/advanced-markdown.md | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 0256ed6458f..bf2240e6c93 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -164,21 +164,14 @@ For all the supported syntax options, Hyde will resolve a relative link based on
 
 Since this happens in our Markdown processor, this will work regardless of if you have custom HTML or Blade enabled for your site.
 
-#### Resolving a route
-
 ```markdown
+<!-- Resolving a route -->
 [Home](hyde::route('home'))
-```
 
-#### Resolving a relative link
-
-```markdown
+<!-- Resolving a relative link -->
 [Home](hyde::relativeLink('home'))
-```
-
-#### Resolving a media asset
 
-```markdown
+<!-- Resolving a media asset -->
 ![Image](hyde::media('image.jpg'))
 ```
 

From eec58870c6ff389c90244bd5f701ab52872dce78 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:15:06 +0200
Subject: [PATCH 04/90] Match the Hyde facade methods

---
 docs/digging-deeper/advanced-markdown.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index bf2240e6c93..fd9803663a1 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -172,7 +172,7 @@ Since this happens in our Markdown processor, this will work regardless of if yo
 [Home](hyde::relativeLink('home'))
 
 <!-- Resolving a media asset -->
-![Image](hyde::media('image.jpg'))
+![Image](hyde::asset('image.jpg'))
 ```
 
 ### Limitations

From 397da8e0045aba6e59a0104a1f83a89c919cc477 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:24:25 +0200
Subject: [PATCH 05/90] Create DynamicMarkdownLinksTest.php

---
 .../tests/Feature/DynamicMarkdownLinksTest.php | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 packages/framework/tests/Feature/DynamicMarkdownLinksTest.php

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
new file mode 100644
index 00000000000..eae8ef2be58
--- /dev/null
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Hyde\Framework\Testing\Feature;
+
+use Hyde\Testing\TestCase;
+
+/**
+ * @covers \Hyde\Hyde
+ */
+class DynamicMarkdownLinksTest extends TestCase
+{
+    public function testExample()
+    {
+        $this->assertTrue(true);
+    }
+}

From 63bab3b8308b95d6cabb0772a448c8690e24bfd1 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:17:36 +0200
Subject: [PATCH 06/90] Create DynamicMarkdownLinkProcessor.php

---
 .../Processing/DynamicMarkdownLinkProcessor.php        | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
new file mode 100644
index 00000000000..24b2415c298
--- /dev/null
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Hyde\Markdown\Processing;
+
+class DynamicMarkdownLinkProcessor
+{
+    //
+}

From d1ee654e231b6ecdcc2152a608abd5edc719504c Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:17:51 +0200
Subject: [PATCH 07/90] Implements MarkdownPostProcessorContract

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 24b2415c298..ce913e077d5 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -4,7 +4,9 @@
 
 namespace Hyde\Markdown\Processing;
 
-class DynamicMarkdownLinkProcessor
+use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
+
+class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     //
 }

From a2e30520d8e03088afc0763f0167899174d209ac Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:24:16 +0200
Subject: [PATCH 08/90] Draft postprocess method

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index ce913e077d5..a47642414a4 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -8,5 +8,8 @@
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
-    //
+    public static function postprocess(string $html): string
+    {
+        // TODO: Implement postprocess() method.
+    }
 }

From 59b06182e4716c528ec90d43d22590ece6c9be39 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:24:32 +0200
Subject: [PATCH 09/90] Revert "Create DynamicMarkdownLinksTest.php"

This reverts commit 091a8d5c48f51af5e24686cfca3494daf79c3ba6.
---
 .../tests/Feature/DynamicMarkdownLinksTest.php | 18 ------------------
 1 file changed, 18 deletions(-)
 delete mode 100644 packages/framework/tests/Feature/DynamicMarkdownLinksTest.php

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
deleted file mode 100644
index eae8ef2be58..00000000000
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
+++ /dev/null
@@ -1,18 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Hyde\Framework\Testing\Feature;
-
-use Hyde\Testing\TestCase;
-
-/**
- * @covers \Hyde\Hyde
- */
-class DynamicMarkdownLinksTest extends TestCase
-{
-    public function testExample()
-    {
-        $this->assertTrue(true);
-    }
-}

From 47bfef53fb5985da8123466fb055cdbcd9c90d95 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:26:21 +0200
Subject: [PATCH 10/90] Create DynamicMarkdownLinkProcessorTest.php

---
 .../Markdown/DynamicMarkdownLinkProcessorTest.php | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
new file mode 100644
index 00000000000..4fc7c0e2f1a
--- /dev/null
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Hyde\Framework\Testing\Feature\Services\Markdown;
+
+use Hyde\Testing\UnitTestCase;
+
+/**
+ * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
+ */
+class DynamicMarkdownLinkProcessorTest extends UnitTestCase
+{
+    //
+}

From 9a08865586e21def88514c4ad64e2ae007e3e09b Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:33:23 +0200
Subject: [PATCH 11/90] Implement the initial dynamic markdown link feature

---
 .../DynamicMarkdownLinkProcessor.php          | 19 ++++++-
 .../DynamicMarkdownLinkProcessorTest.php      | 52 ++++++++++++++++++-
 2 files changed, 69 insertions(+), 2 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index a47642414a4..3b17b28b5fc 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -4,12 +4,29 @@
 
 namespace Hyde\Markdown\Processing;
 
+use Hyde\Hyde;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
     {
-        // TODO: Implement postprocess() method.
+        $patterns = [
+            '/<a href="hyde::route\(\'([^\']+)\'\)"/' => function ($matches) {
+                return '<a href="'.Hyde::route($matches[1]).'"';
+            },
+            '/<a href="hyde::relativeLink\(\'([^\']+)\'\)"/' => function ($matches) {
+                return '<a href="'.Hyde::relativeLink($matches[1]).'"';
+            },
+            '/<img src="hyde::asset\(\'([^\']+)\'\)"/' => function ($matches) {
+                return '<img src="'.Hyde::asset($matches[1]).'"';
+            },
+        ];
+
+        foreach ($patterns as $pattern => $replacement) {
+            $html = preg_replace_callback($pattern, $replacement, $html);
+        }
+
+        return $html;
     }
 }
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 4fc7c0e2f1a..c6e42bcff2a 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -4,12 +4,62 @@
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;
 
+use Hyde\Pages\InMemoryPage;
 use Hyde\Testing\UnitTestCase;
+use Hyde\Support\Models\Route;
+use Hyde\Support\Facades\Render;
+use Hyde\Foundation\Facades\Routes;
+use Hyde\Support\Models\RenderData;
+use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
  */
 class DynamicMarkdownLinkProcessorTest extends UnitTestCase
 {
-    //
+    protected static bool $needsConfig = true;
+    protected static bool $needsKernel = true;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        Render::swap(new RenderData());
+
+        Routes::addRoute(new Route(new InMemoryPage('home')));
+    }
+
+    public function testRouteReplacement()
+    {
+        $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
+        $expected = '<p><a href="home.html">Home</a></p>';
+        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testRelativeLinkReplacement()
+    {
+        $input = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
+        $expected = '<p><a href="about">About</a></p>';
+        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testAssetReplacement()
+    {
+        $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
+        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
+        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMultipleReplacements()
+    {
+        $input = '<p><a href="hyde::route(\'home\')">Home</a> <a href="hyde::relativeLink(\'about\')">About</a> <img src="hyde::asset(\'logo.png\')" alt="Logo" /></p>';
+        $expected = '<p><a href="home.html">Home</a> <a href="about">About</a> <img src="media/logo.png" alt="Logo" /></p>';
+        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testNoReplacements()
+    {
+        $input = '<p>This is a regular <a href="https://example.com">link</a> with no Hyde syntax.</p>';
+        $this->assertEquals($input, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
 }

From 6ec38dd1f4b1fbde44ef66cd099c8829342aa8a3 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:45:56 +0200
Subject: [PATCH 12/90] Refactor to use strict types

---
 .../Markdown/Processing/DynamicMarkdownLinkProcessor.php   | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 3b17b28b5fc..ef41334443b 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -11,14 +11,15 @@ class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
     {
+        /** @var array<string, callable(array<int, string>): string> $patterns */
         $patterns = [
-            '/<a href="hyde::route\(\'([^\']+)\'\)"/' => function ($matches) {
+            '/<a href="hyde::route\(\'([^\']+)\'\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::route($matches[1]).'"';
             },
-            '/<a href="hyde::relativeLink\(\'([^\']+)\'\)"/' => function ($matches) {
+            '/<a href="hyde::relativeLink\(\'([^\']+)\'\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::relativeLink($matches[1]).'"';
             },
-            '/<img src="hyde::asset\(\'([^\']+)\'\)"/' => function ($matches) {
+            '/<img src="hyde::asset\(\'([^\']+)\'\)"/' => function (array $matches): string {
                 return '<img src="'.Hyde::asset($matches[1]).'"';
             },
         ];

From eabee96bbe0a4500aeca4bf8b52a937aed13a468 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:48:12 +0200
Subject: [PATCH 13/90] Extract helper method

---
 .../DynamicMarkdownLinkProcessor.php          | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index ef41334443b..52ae7a605eb 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -11,8 +11,17 @@ class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
     {
-        /** @var array<string, callable(array<int, string>): string> $patterns */
-        $patterns = [
+        foreach (static::patterns() as $pattern => $replacement) {
+            $html = preg_replace_callback($pattern, $replacement, $html);
+        }
+
+        return $html;
+    }
+
+    /** @return array<string, callable(array<int, string>): string> */
+    protected static function patterns(): array
+    {
+        return [
             '/<a href="hyde::route\(\'([^\']+)\'\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::route($matches[1]).'"';
             },
@@ -23,11 +32,5 @@ public static function postprocess(string $html): string
                 return '<img src="'.Hyde::asset($matches[1]).'"';
             },
         ];
-
-        foreach ($patterns as $pattern => $replacement) {
-            $html = preg_replace_callback($pattern, $replacement, $html);
-        }
-
-        return $html;
     }
 }

From 3c91dd7958e16d4449b2322b03d94ab309e40117 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:49:51 +0200
Subject: [PATCH 14/90] Supress faulty inspection

---
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php      | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index c6e42bcff2a..d722ca54b0e 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -1,5 +1,7 @@
 <?php
 
+/** @noinspection HtmlUnknownTarget */
+
 declare(strict_types=1);
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;

From a2c7879815e84a59e73ab5d152350da2febcea95 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:54:33 +0200
Subject: [PATCH 15/90] Use more readable formatting for complex test fixture

---
 .../Markdown/DynamicMarkdownLinkProcessorTest.php  | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index d722ca54b0e..183a6d7414b 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -54,8 +54,18 @@ public function testAssetReplacement()
 
     public function testMultipleReplacements()
     {
-        $input = '<p><a href="hyde::route(\'home\')">Home</a> <a href="hyde::relativeLink(\'about\')">About</a> <img src="hyde::asset(\'logo.png\')" alt="Logo" /></p>';
-        $expected = '<p><a href="home.html">Home</a> <a href="about">About</a> <img src="media/logo.png" alt="Logo" /></p>';
+        $input = <<<'MARKDOWN'
+        <a href="hyde::route('home')">Home</a>
+        <a href="hyde::relativeLink('about')">About</a>
+        <img src="hyde::asset('logo.png')" alt="Logo" />
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <a href="home.html">Home</a>
+        <a href="about">About</a>
+        <img src="media/logo.png" alt="Logo" />
+        HTML;
+
         $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 

From 33ba914f9ec938abf3cb4909a4871d2ed0811504 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:54:59 +0200
Subject: [PATCH 16/90] Use assert same instead of assert equals

---
 .../Markdown/DynamicMarkdownLinkProcessorTest.php      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 183a6d7414b..48026b79b39 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -35,21 +35,21 @@ public function testRouteReplacement()
     {
         $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
         $expected = '<p><a href="home.html">Home</a></p>';
-        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testRelativeLinkReplacement()
     {
         $input = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
         $expected = '<p><a href="about">About</a></p>';
-        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testAssetReplacement()
     {
         $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
         $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
-        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testMultipleReplacements()
@@ -66,12 +66,12 @@ public function testMultipleReplacements()
         <img src="media/logo.png" alt="Logo" />
         HTML;
 
-        $this->assertEquals($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testNoReplacements()
     {
         $input = '<p>This is a regular <a href="https://example.com">link</a> with no Hyde syntax.</p>';
-        $this->assertEquals($input, DynamicMarkdownLinkProcessor::postprocess($input));
+        $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 }

From 15ecda86a7272dcc92ddc8a9b4485a8be0c2d86a Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 17:58:44 +0200
Subject: [PATCH 17/90] Update Markdown link support to work without single
 quotes

---
 .../Processing/DynamicMarkdownLinkProcessor.php | 12 ++++++------
 .../DynamicMarkdownLinkProcessorTest.php        | 17 +++++++++++++++++
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 52ae7a605eb..bf00a9a8c1a 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -22,14 +22,14 @@ public static function postprocess(string $html): string
     protected static function patterns(): array
     {
         return [
-            '/<a href="hyde::route\(\'([^\']+)\'\)"/' => function (array $matches): string {
-                return '<a href="'.Hyde::route($matches[1]).'"';
+            '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+                return '<a href="'.Hyde::route($matches[2]).'"';
             },
-            '/<a href="hyde::relativeLink\(\'([^\']+)\'\)"/' => function (array $matches): string {
-                return '<a href="'.Hyde::relativeLink($matches[1]).'"';
+            '/<a href="hyde::relativeLink\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+                return '<a href="'.Hyde::relativeLink($matches[2]).'"';
             },
-            '/<img src="hyde::asset\(\'([^\']+)\'\)"/' => function (array $matches): string {
-                return '<img src="'.Hyde::asset($matches[1]).'"';
+            '/<img src="hyde::asset\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+                return '<img src="'.Hyde::asset($matches[2]).'"';
             },
         ];
     }
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 48026b79b39..8191fdb7c45 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -36,6 +36,9 @@ public function testRouteReplacement()
         $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
         $expected = '<p><a href="home.html">Home</a></p>';
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+
+        $inputUnquoted = '<p><a href="hyde::route(home)">Home</a></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
     }
 
     public function testRelativeLinkReplacement()
@@ -43,6 +46,9 @@ public function testRelativeLinkReplacement()
         $input = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
         $expected = '<p><a href="about">About</a></p>';
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+
+        $inputUnquoted = '<p><a href="hyde::relativeLink(about)">About</a></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
     }
 
     public function testAssetReplacement()
@@ -50,6 +56,9 @@ public function testAssetReplacement()
         $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
         $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+
+        $inputUnquoted = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
     }
 
     public function testMultipleReplacements()
@@ -67,6 +76,14 @@ public function testMultipleReplacements()
         HTML;
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+
+        $inputUnquoted = <<<'MARKDOWN'
+        <a href="hyde::route(home)">Home</a>
+        <a href="hyde::relativeLink(about)">About</a>
+        <img src="hyde::asset(logo.png)" alt="Logo" />
+        MARKDOWN;
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
     }
 
     public function testNoReplacements()

From 048910d6d913f591d0d951867c465d8b6cecd6ed Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:00:20 +0200
Subject: [PATCH 18/90] Update Markdown link support to work with double quotes

---
 .../DynamicMarkdownLinkProcessor.php          |  6 +--
 .../DynamicMarkdownLinkProcessorTest.php      | 46 +++++++++++++------
 2 files changed, 36 insertions(+), 16 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index bf00a9a8c1a..fe50a979784 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -22,13 +22,13 @@ public static function postprocess(string $html): string
     protected static function patterns(): array
     {
         return [
-            '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+            '/<a href="hyde::route\((\'|"|)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::route($matches[2]).'"';
             },
-            '/<a href="hyde::relativeLink\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+            '/<a href="hyde::relativeLink\((\'|"|)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::relativeLink($matches[2]).'"';
             },
-            '/<img src="hyde::asset\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+            '/<img src="hyde::asset\((\'|"|)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<img src="'.Hyde::asset($matches[2]).'"';
             },
         ];
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 8191fdb7c45..7ff8843d509 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -33,9 +33,13 @@ protected function setUp(): void
 
     public function testRouteReplacement()
     {
-        $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
         $expected = '<p><a href="home.html">Home</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+
+        $inputSingleQuotes = '<p><a href="hyde::route(\'home\')">Home</a></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
+
+        $inputDoubleQuotes = '<p><a href="hyde::route("home")">Home</a></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
 
         $inputUnquoted = '<p><a href="hyde::route(home)">Home</a></p>';
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
@@ -43,9 +47,13 @@ public function testRouteReplacement()
 
     public function testRelativeLinkReplacement()
     {
-        $input = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
         $expected = '<p><a href="about">About</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+
+        $inputSingleQuotes = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
+
+        $inputDoubleQuotes = '<p><a href="hyde::relativeLink("about")">About</a></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
 
         $inputUnquoted = '<p><a href="hyde::relativeLink(about)">About</a></p>';
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
@@ -53,9 +61,13 @@ public function testRelativeLinkReplacement()
 
     public function testAssetReplacement()
     {
-        $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
         $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+
+        $inputSingleQuotes = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
+
+        $inputDoubleQuotes = '<p><img src="hyde::asset("image.jpg")" alt="Image" /></p>';
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
 
         $inputUnquoted = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
@@ -63,19 +75,27 @@ public function testAssetReplacement()
 
     public function testMultipleReplacements()
     {
-        $input = <<<'MARKDOWN'
-        <a href="hyde::route('home')">Home</a>
-        <a href="hyde::relativeLink('about')">About</a>
-        <img src="hyde::asset('logo.png')" alt="Logo" />
-        MARKDOWN;
-
         $expected = <<<'HTML'
         <a href="home.html">Home</a>
         <a href="about">About</a>
         <img src="media/logo.png" alt="Logo" />
         HTML;
 
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+        $inputSingleQuotes = <<<'MARKDOWN'
+        <a href="hyde::route('home')">Home</a>
+        <a href="hyde::relativeLink('about')">About</a>
+        <img src="hyde::asset('logo.png')" alt="Logo" />
+        MARKDOWN;
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
+
+        $inputDoubleQuotes = <<<'MARKDOWN'
+        <a href="hyde::route("home")">Home</a>
+        <a href="hyde::relativeLink("about")">About</a>
+        <img src="hyde::asset("logo.png")" alt="Logo" />
+        MARKDOWN;
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
 
         $inputUnquoted = <<<'MARKDOWN'
         <a href="hyde::route(home)">Home</a>

From 017355f117a9475bb83eb09a54747d04b11523c5 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:03:16 +0200
Subject: [PATCH 19/90] Split out multiple assertions to dedicated unit tests

The testMultipleReplacements method does not need to be split since we don't get any new information from testing already tested alternate syntaxes. That test is mainly for humans to visualise the applicable code better in a more real life scenario.
---
 .../DynamicMarkdownLinkProcessorTest.php      | 97 +++++++++++--------
 1 file changed, 56 insertions(+), 41 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 7ff8843d509..57c875b2f7b 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -33,82 +33,97 @@ protected function setUp(): void
 
     public function testRouteReplacement()
     {
+        $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
         $expected = '<p><a href="home.html">Home</a></p>';
 
-        $inputSingleQuotes = '<p><a href="hyde::route(\'home\')">Home</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
 
-        $inputDoubleQuotes = '<p><a href="hyde::route("home")">Home</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
+    public function testRouteReplacementWithDoubleQuotes()
+    {
+        $input = '<p><a href="hyde::route("home")">Home</a></p>';
+        $expected = '<p><a href="home.html">Home</a></p>';
 
-        $inputUnquoted = '<p><a href="hyde::route(home)">Home</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testRouteReplacementWithoutQuotes()
+    {
+        $input = '<p><a href="hyde::route(home)">Home</a></p>';
+        $expected = '<p><a href="home.html">Home</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testRelativeLinkReplacement()
     {
+        $input = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
         $expected = '<p><a href="about">About</a></p>';
 
-        $inputSingleQuotes = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
 
-        $inputDoubleQuotes = '<p><a href="hyde::relativeLink("about")">About</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
+    public function testRelativeLinkReplacementWithDoubleQuotes()
+    {
+        $input = '<p><a href="hyde::relativeLink("about")">About</a></p>';
+        $expected = '<p><a href="about">About</a></p>';
 
-        $inputUnquoted = '<p><a href="hyde::relativeLink(about)">About</a></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testRelativeLinkReplacementWithoutQuotes()
+    {
+        $input = '<p><a href="hyde::relativeLink(about)">About</a></p>';
+        $expected = '<p><a href="about">About</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testAssetReplacement()
     {
+        $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
         $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
 
-        $inputSingleQuotes = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
 
-        $inputDoubleQuotes = '<p><img src="hyde::asset("image.jpg")" alt="Image" /></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
+    public function testAssetReplacementWithDoubleQuotes()
+    {
+        $input = '<p><img src="hyde::asset("image.jpg")" alt="Image" /></p>';
+        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
 
-        $inputUnquoted = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testMultipleReplacements()
+    public function testAssetReplacementWithoutQuotes()
     {
-        $expected = <<<'HTML'
-        <a href="home.html">Home</a>
-        <a href="about">About</a>
-        <img src="media/logo.png" alt="Logo" />
-        HTML;
+        $input = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';
+        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
 
-        $inputSingleQuotes = <<<'MARKDOWN'
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMultipleReplacements()
+    {
+        $input = <<<'MARKDOWN'
         <a href="hyde::route('home')">Home</a>
         <a href="hyde::relativeLink('about')">About</a>
         <img src="hyde::asset('logo.png')" alt="Logo" />
         MARKDOWN;
 
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputSingleQuotes));
-
-        $inputDoubleQuotes = <<<'MARKDOWN'
-        <a href="hyde::route("home")">Home</a>
-        <a href="hyde::relativeLink("about")">About</a>
-        <img src="hyde::asset("logo.png")" alt="Logo" />
-        MARKDOWN;
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputDoubleQuotes));
-
-        $inputUnquoted = <<<'MARKDOWN'
-        <a href="hyde::route(home)">Home</a>
-        <a href="hyde::relativeLink(about)">About</a>
-        <img src="hyde::asset(logo.png)" alt="Logo" />
-        MARKDOWN;
+        $expected = <<<'HTML'
+        <a href="home.html">Home</a>
+        <a href="about">About</a>
+        <img src="media/logo.png" alt="Logo" />
+        HTML;
 
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($inputUnquoted));
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testNoReplacements()
     {
         $input = '<p>This is a regular <a href="https://example.com">link</a> with no Hyde syntax.</p>';
+
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 }

From df09449ab2e856f3fe360888382f958cf3c104bf Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:08:42 +0200
Subject: [PATCH 20/90] Revert "Update Markdown link support to work with
 double quotes"

This reverts commit 048910d6d913f591d0d951867c465d8b6cecd6ed. See https://github.com/hydephp/develop/pull/1590#discussion_r1690082732
---
 .../DynamicMarkdownLinkProcessor.php          |  6 ++---
 .../DynamicMarkdownLinkProcessorTest.php      | 24 -------------------
 2 files changed, 3 insertions(+), 27 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index fe50a979784..bf00a9a8c1a 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -22,13 +22,13 @@ public static function postprocess(string $html): string
     protected static function patterns(): array
     {
         return [
-            '/<a href="hyde::route\((\'|"|)([^\'"]+)\1\)"/' => function (array $matches): string {
+            '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::route($matches[2]).'"';
             },
-            '/<a href="hyde::relativeLink\((\'|"|)([^\'"]+)\1\)"/' => function (array $matches): string {
+            '/<a href="hyde::relativeLink\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::relativeLink($matches[2]).'"';
             },
-            '/<img src="hyde::asset\((\'|"|)([^\'"]+)\1\)"/' => function (array $matches): string {
+            '/<img src="hyde::asset\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<img src="'.Hyde::asset($matches[2]).'"';
             },
         ];
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 57c875b2f7b..e87afe8ee2c 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -39,14 +39,6 @@ public function testRouteReplacement()
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testRouteReplacementWithDoubleQuotes()
-    {
-        $input = '<p><a href="hyde::route("home")">Home</a></p>';
-        $expected = '<p><a href="home.html">Home</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
     public function testRouteReplacementWithoutQuotes()
     {
         $input = '<p><a href="hyde::route(home)">Home</a></p>';
@@ -63,14 +55,6 @@ public function testRelativeLinkReplacement()
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testRelativeLinkReplacementWithDoubleQuotes()
-    {
-        $input = '<p><a href="hyde::relativeLink("about")">About</a></p>';
-        $expected = '<p><a href="about">About</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
     public function testRelativeLinkReplacementWithoutQuotes()
     {
         $input = '<p><a href="hyde::relativeLink(about)">About</a></p>';
@@ -87,14 +71,6 @@ public function testAssetReplacement()
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testAssetReplacementWithDoubleQuotes()
-    {
-        $input = '<p><img src="hyde::asset("image.jpg")" alt="Image" /></p>';
-        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
     public function testAssetReplacementWithoutQuotes()
     {
         $input = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';

From 55df5a3a4724021aab6c73a5852be8fc148eb512 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:10:33 +0200
Subject: [PATCH 21/90] Register the dynamic Markdown link processor

---
 .../Framework/Concerns/Internal/SetsUpMarkdownConverter.php    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/framework/src/Framework/Concerns/Internal/SetsUpMarkdownConverter.php b/packages/framework/src/Framework/Concerns/Internal/SetsUpMarkdownConverter.php
index 38302778834..307c2caa81d 100644
--- a/packages/framework/src/Framework/Concerns/Internal/SetsUpMarkdownConverter.php
+++ b/packages/framework/src/Framework/Concerns/Internal/SetsUpMarkdownConverter.php
@@ -8,6 +8,7 @@
 use Hyde\Markdown\Processing\BladeDownProcessor;
 use Hyde\Markdown\Processing\ShortcodeProcessor;
 use Hyde\Markdown\Processing\CodeblockFilepathProcessor;
+use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 use Torchlight\Commonmark\V2\TorchlightExtension;
 
 use function array_merge;
@@ -73,6 +74,8 @@ protected function registerPostProcessors(): void
             CodeblockFilepathProcessor::class,
             Config::getBool('markdown.features.codeblock_filepaths', true)
         );
+
+        $this->registerPostProcessor(DynamicMarkdownLinkProcessor::class);
     }
 
     protected function registerPreProcessor(string $class, bool $when = true): void

From 16051f7e2c2bab364f8de18adb1b33aef72b9d4a Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:11:05 +0200
Subject: [PATCH 22/90] Reapply "Create DynamicMarkdownLinksTest.php"

This reverts commit 59b06182e4716c528ec90d43d22590ece6c9be39.
---
 .../tests/Feature/DynamicMarkdownLinksTest.php | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 packages/framework/tests/Feature/DynamicMarkdownLinksTest.php

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
new file mode 100644
index 00000000000..eae8ef2be58
--- /dev/null
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Hyde\Framework\Testing\Feature;
+
+use Hyde\Testing\TestCase;
+
+/**
+ * @covers \Hyde\Hyde
+ */
+class DynamicMarkdownLinksTest extends TestCase
+{
+    public function testExample()
+    {
+        $this->assertTrue(true);
+    }
+}

From b0fe2bb0708e4971fa830da78874f2419da426bf Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:11:34 +0200
Subject: [PATCH 23/90] Rename test to DynamicMarkdownLinksFeatureTest

---
 ...arkdownLinksTest.php => DynamicMarkdownLinksFeatureTest.php} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename packages/framework/tests/Feature/{DynamicMarkdownLinksTest.php => DynamicMarkdownLinksFeatureTest.php} (79%)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
similarity index 79%
rename from packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
rename to packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index eae8ef2be58..66814d5b4af 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -9,7 +9,7 @@
 /**
  * @covers \Hyde\Hyde
  */
-class DynamicMarkdownLinksTest extends TestCase
+class DynamicMarkdownLinksFeatureTest extends TestCase
 {
     public function testExample()
     {

From 69a5277a239a874c8cb48037f72b000cb3749df7 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:12:34 +0200
Subject: [PATCH 24/90] Set up coverage

---
 .../tests/Feature/DynamicMarkdownLinksFeatureTest.php          | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 66814d5b4af..0d186b56e45 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -7,7 +7,8 @@
 use Hyde\Testing\TestCase;
 
 /**
- * @covers \Hyde\Hyde
+ * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
+ * @covers \Hyde\Framework\Concerns\Internal\SetsUpMarkdownConverter
  */
 class DynamicMarkdownLinksFeatureTest extends TestCase
 {

From 6a7f46a9497844d4fe762e101075332eaa9a942c Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:12:57 +0200
Subject: [PATCH 25/90] Add test crosslinks

---
 .../framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php | 2 ++
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php      | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 0d186b56e45..87aafdc3007 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -9,6 +9,8 @@
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
  * @covers \Hyde\Framework\Concerns\Internal\SetsUpMarkdownConverter
+ *
+ * @see \Hyde\Framework\Testing\Feature\Services\Markdown\DynamicMarkdownLinkProcessorTest
  */
 class DynamicMarkdownLinksFeatureTest extends TestCase
 {
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index e87afe8ee2c..ff7bb6923ef 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -16,6 +16,8 @@
 
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
+ *
+ * @see \Hyde\Framework\Testing\Feature\DynamicMarkdownLinksFeatureTest
  */
 class DynamicMarkdownLinkProcessorTest extends UnitTestCase
 {

From 85860164032a6c5efa81b2701fe44103be264055 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:15:23 +0200
Subject: [PATCH 26/90] Match heredoc name to type

---
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index ff7bb6923ef..04f53ca365d 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -83,11 +83,11 @@ public function testAssetReplacementWithoutQuotes()
 
     public function testMultipleReplacements()
     {
-        $input = <<<'MARKDOWN'
+        $input = <<<'HTML'
         <a href="hyde::route('home')">Home</a>
         <a href="hyde::relativeLink('about')">About</a>
         <img src="hyde::asset('logo.png')" alt="Logo" />
-        MARKDOWN;
+        HTML;
 
         $expected = <<<'HTML'
         <a href="home.html">Home</a>

From e943c198b4c4eece221224664f0c5e8270409bdf Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:44:58 +0200
Subject: [PATCH 27/90] Implement the basic test

---
 .../DynamicMarkdownLinksFeatureTest.php       | 38 ++++++++++++++++++-
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 87aafdc3007..66ca829ad27 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -1,10 +1,16 @@
 <?php
 
+/** @noinspection HtmlUnknownTarget */
+
 declare(strict_types=1);
 
 namespace Hyde\Framework\Testing\Feature;
 
+use Hyde\Hyde;
 use Hyde\Testing\TestCase;
+use Hyde\Pages\InMemoryPage;
+use Hyde\Support\Models\Route;
+use Hyde\Foundation\Facades\Routes;
 
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
@@ -14,8 +20,36 @@
  */
 class DynamicMarkdownLinksFeatureTest extends TestCase
 {
-    public function testExample()
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        Routes::addRoute(new Route(new InMemoryPage('home')));
+        Routes::addRoute(new Route(new InMemoryPage('blog/post')));
+    }
+
+    public function testDynamicMarkdownLinks()
     {
-        $this->assertTrue(true);
+        $input = <<<'MARKDOWN'
+        [Home](hyde::route('home'))
+        [About](hyde::relativeLink('about'))
+        ![Logo](hyde::asset('logo.png'))
+        
+        [Home](hyde::route(home))
+        [About](hyde::relativeLink(about))
+        ![Logo](hyde::asset(logo.png))
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p><a href="home.html">Home</a>
+        <a href="about">About</a>
+        <img src="media/logo.png" alt="Logo" /></p>
+        <p><a href="home.html">Home</a>
+        <a href="about">About</a>
+        <img src="media/logo.png" alt="Logo" /></p>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
 }

From d489d9020f85b3a7c8ed6d0653139a8aa7ba59ab Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:45:24 +0200
Subject: [PATCH 28/90] Generate more tests with Claude

---
 .../DynamicMarkdownLinksFeatureTest.php       | 103 +++++++++++++++++-
 1 file changed, 102 insertions(+), 1 deletion(-)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 66ca829ad27..10a2e96c5ac 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -28,7 +28,7 @@ protected function setUp(): void
         Routes::addRoute(new Route(new InMemoryPage('blog/post')));
     }
 
-    public function testDynamicMarkdownLinks()
+    public function testBasicDynamicMarkdownLinks()
     {
         $input = <<<'MARKDOWN'
         [Home](hyde::route('home'))
@@ -52,4 +52,105 @@ public function testDynamicMarkdownLinks()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
+
+    public function testDynamicMarkdownLinksWithDoubleQuotes()
+    {
+        $input = <<<'MARKDOWN'
+        [Home](hyde::route("home"))
+        [About](hyde::relativeLink("about"))
+        ![Logo](hyde::asset("logo.png"))
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p><a href="home.html">Home</a>
+        <a href="about">About</a>
+        <img src="media/logo.png" alt="Logo" /></p>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+    }
+
+    public function testDynamicMarkdownLinksInParagraphs()
+    {
+        $input = <<<'MARKDOWN'
+        This is a paragraph with a [link to home](hyde::route('home')) and an [about link](hyde::relativeLink('about')).
+
+        Another paragraph with an ![image](hyde::asset('image.jpg')).
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p>This is a paragraph with a <a href="home.html">link to home</a> and an <a href="about">about link</a>.</p>
+        <p>Another paragraph with an <img src="media/image.jpg" alt="image" />.</p>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+    }
+
+    public function testDynamicMarkdownLinksInLists()
+    {
+        $input = <<<'MARKDOWN'
+        - [Home](hyde::route('home'))
+        - [About](hyde::relativeLink('about'))
+        - ![Logo](hyde::asset('logo.png'))
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <ul>
+        <li>
+        <a href="home.html">Home</a>
+        </li>
+        <li>
+        <a href="about">About</a>
+        </li>
+        <li>
+        <img src="media/logo.png" alt="Logo" />
+        </li>
+        </ul>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+    }
+
+    public function testDynamicMarkdownLinksWithNestedRoutes()
+    {
+        $input = <<<'MARKDOWN'
+        [Blog Post](hyde::route('blog/post'))
+        [Relative Blog](hyde::relativeLink('blog/post'))
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p><a href="blog/post.html">Blog Post</a>
+        <a href="blog/post">Relative Blog</a></p>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+    }
+
+    public function testMixOfDynamicAndRegularMarkdownLinks()
+    {
+        $input = <<<'MARKDOWN'
+        [Home](hyde::route('home'))
+        [External](https://example.com)
+        [About](hyde::relativeLink('about'))
+        [Regular](regular-link.html)
+        ![Logo](hyde::asset('logo.png'))
+        ![External Image](https://example.com/image.jpg)
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p><a href="home.html">Home</a>
+        <a href="https://example.com">External</a>
+        <a href="about">About</a>
+        <a href="regular-link.html">Regular</a>
+        <img src="media/logo.png" alt="Logo" />
+        <img src="https://example.com/image.jpg" alt="External Image" /></p>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+    }
 }

From a8aeb8bf91e0e1d7d86ec81199df1780882c2b5a Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:45:40 +0200
Subject: [PATCH 29/90] Skip unsupported test

See https://github.com/hydephp/develop/pull/1590#discussion_r1690082732
---
 .../framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 10a2e96c5ac..5034aecda8a 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -55,6 +55,8 @@ public function testBasicDynamicMarkdownLinks()
 
     public function testDynamicMarkdownLinksWithDoubleQuotes()
     {
+        $this->markTestSkipped('https://github.com/hydephp/develop/pull/1590#discussion_r1690082732');
+
         $input = <<<'MARKDOWN'
         [Home](hyde::route("home"))
         [About](hyde::relativeLink("about"))

From b10b55a5d67c3300f6fa2ff42f09939831cf54e8 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:48:11 +0200
Subject: [PATCH 30/90] Add fault tolerance testing

---
 .../DynamicMarkdownLinkProcessorTest.php      | 87 +++++++++++++++++++
 1 file changed, 87 insertions(+)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 04f53ca365d..6f7ee4bb102 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -104,4 +104,91 @@ public function testNoReplacements()
 
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
+
+    public function testMalformedRouteLink()
+    {
+        $input = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
+        $expected = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMalformedRelativeLink()
+    {
+        $input = '<p><a href="hyde::relativeLink(about\')">Malformed About</a></p>';
+        $expected = '<p><a href="hyde::relativeLink(about\')">Malformed About</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMalformedAssetLink()
+    {
+        $input = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
+        $expected = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testEmptyRouteLink()
+    {
+        $input = '<p><a href="hyde::route()">Empty Route</a></p>';
+        $expected = '<p><a href="hyde::route()">Empty Route</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testEmptyRelativeLink()
+    {
+        $input = '<p><a href="hyde::relativeLink()">Empty Relative Link</a></p>';
+        $expected = '<p><a href="hyde::relativeLink()">Empty Relative Link</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testEmptyAssetLink()
+    {
+        $input = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
+        $expected = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMixedValidAndInvalidLinks()
+    {
+        $input = <<<'HTML'
+        <a href="hyde::route('home')">Valid Home</a>
+        <a href="hyde::route(invalid'">Invalid Route</a>
+        <a href="hyde::relativeLink('about')">Valid About</a>
+        <a href="hyde::relativeLink(about')">Invalid Relative</a>
+        <img src="hyde::asset('logo.png')" alt="Valid Logo" />
+        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
+        HTML;
+
+        $expected = <<<'HTML'
+        <a href="home.html">Valid Home</a>
+        <a href="hyde::route(invalid'">Invalid Route</a>
+        <a href="about">Valid About</a>
+        <a href="hyde::relativeLink(about')">Invalid Relative</a>
+        <img src="media/logo.png" alt="Valid Logo" />
+        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
+        HTML;
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMalformedHydeSyntax()
+    {
+        $input = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
+        $expected = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testNonExistentRouteFunction()
+    {
+        $input = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
+        $expected = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
 }

From d105152f3e9b19eca36d6f98767a3d371c027318 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 18:48:17 +0200
Subject: [PATCH 31/90] Section test code

---
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php      | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 6f7ee4bb102..e5790ea88d6 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -105,6 +105,8 @@ public function testNoReplacements()
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
+    // Fault tolerance tests
+
     public function testMalformedRouteLink()
     {
         $input = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';

From f2d02fbd33c07d7d07a6feb86a0f41c377b446a7 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:01:32 +0200
Subject: [PATCH 32/90] Add more fault tolerance tests

---
 .../DynamicMarkdownLinkProcessorTest.php         | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index e5790ea88d6..c917bc2e1ab 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -115,6 +115,22 @@ public function testMalformedRouteLink()
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
+    public function testMalformedRouteLink2()
+    {
+        $input = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
+        $expected = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMalformedRouteLink3()
+    {
+        $input = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
+        $expected = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
     public function testMalformedRelativeLink()
     {
         $input = '<p><a href="hyde::relativeLink(about\')">Malformed About</a></p>';

From ad20f39262517d90b3453f2dd442fef9cbd19208 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:07:01 +0200
Subject: [PATCH 33/90] Throw an exception for non existent routes

---
 .../Processing/DynamicMarkdownLinkProcessor.php       | 11 ++++++++++-
 .../Markdown/DynamicMarkdownLinkProcessorTest.php     | 10 ++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index bf00a9a8c1a..d6b9796d344 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,6 +5,7 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
+use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
@@ -23,7 +24,15 @@ protected static function patterns(): array
     {
         return [
             '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
-                return '<a href="'.Hyde::route($matches[2]).'"';
+                $route = Hyde::route($matches[2]);
+                if ($route === null) {
+                    // While the other patterns work regardless of if input is valid,
+                    // this method returns null, which silently fails to an empty string.
+                    // So we instead throw an exception to alert the developer of the issue.
+                    throw new RouteNotFoundException($matches[2]);
+                }
+
+                return '<a href="'.$route.'"';
             },
             '/<a href="hyde::relativeLink\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<a href="'.Hyde::relativeLink($matches[2]).'"';
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index c917bc2e1ab..4ebc368e653 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -12,6 +12,7 @@
 use Hyde\Support\Facades\Render;
 use Hyde\Foundation\Facades\Routes;
 use Hyde\Support\Models\RenderData;
+use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 
 /**
@@ -105,6 +106,15 @@ public function testNoReplacements()
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
+    public function testNonExistentRouteThrowsException()
+    {
+        $this->expectException(RouteNotFoundException::class);
+        $this->expectExceptionMessage('Route [non-existent] not found.');
+
+        $input = '<p><a href="hyde::route(\'non-existent\')">Non-existent Route</a></p>';
+        DynamicMarkdownLinkProcessor::postprocess($input);
+    }
+
     // Fault tolerance tests
 
     public function testMalformedRouteLink()

From 61a552beb06f43ae0f8055105a89643154183df0 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:10:37 +0200
Subject: [PATCH 34/90] Extract helper method

---
 .../DynamicMarkdownLinkProcessor.php           | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index d6b9796d344..b9d3c37a10e 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,6 +5,7 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
+use Hyde\Support\Models\Route;
 use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
@@ -25,12 +26,7 @@ protected static function patterns(): array
         return [
             '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 $route = Hyde::route($matches[2]);
-                if ($route === null) {
-                    // While the other patterns work regardless of if input is valid,
-                    // this method returns null, which silently fails to an empty string.
-                    // So we instead throw an exception to alert the developer of the issue.
-                    throw new RouteNotFoundException($matches[2]);
-                }
+                static::validateRouteExists($route, $matches[2]);
 
                 return '<a href="'.$route.'"';
             },
@@ -42,4 +38,14 @@ protected static function patterns(): array
             },
         ];
     }
+
+    protected static function validateRouteExists(?Route $route, $routeKey): void
+    {
+        if ($route === null) {
+            // While the other patterns work regardless of if input is valid,
+            // this method returns null, which silently fails to an empty string.
+            // So we instead throw an exception to alert the developer of the issue.
+            throw new RouteNotFoundException($routeKey);
+        }
+    }
 }

From ee000ced31862c0ba2e26bfe0af007991c708150 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:10:49 +0200
Subject: [PATCH 35/90] Add newline

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php     | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index b9d3c37a10e..2b48b86c203 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -26,6 +26,7 @@ protected static function patterns(): array
         return [
             '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 $route = Hyde::route($matches[2]);
+
                 static::validateRouteExists($route, $matches[2]);
 
                 return '<a href="'.$route.'"';

From 80edd88d786f813e9d72cb66714ae714cd6ce820 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:11:08 +0200
Subject: [PATCH 36/90] Add newline

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php     | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 2b48b86c203..2c2eb91cd66 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -46,6 +46,7 @@ protected static function validateRouteExists(?Route $route, $routeKey): void
             // While the other patterns work regardless of if input is valid,
             // this method returns null, which silently fails to an empty string.
             // So we instead throw an exception to alert the developer of the issue.
+
             throw new RouteNotFoundException($routeKey);
         }
     }

From 8e1e51678bb3609e1c396443500b920b39860339 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:17:17 +0200
Subject: [PATCH 37/90] Try to find the faulty line

---
 .../Framework/Exceptions/RouteNotFoundException.php  | 12 ++++++++++++
 .../Processing/DynamicMarkdownLinkProcessor.php      | 12 +++++++++++-
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php b/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
index 1f173d27f78..4e8c05e3d45 100644
--- a/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
+++ b/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
@@ -20,4 +20,16 @@ public function __construct(?string $routeKey = null)
     {
         parent::__construct($routeKey ? sprintf('Route [%s] not found.', $routeKey) : $this->message);
     }
+
+    /**
+     * @interal
+     *
+     * @experimental
+     *
+     * @codeCoverageIgnore
+     */
+    public function setErroredFile(string $path): void
+    {
+        $this->message = rtrim($this->message, '.').sprintf(' (in file [%s])', $path);
+    }
 }
diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 2c2eb91cd66..c983ca3f638 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -6,6 +6,7 @@
 
 use Hyde\Hyde;
 use Hyde\Support\Models\Route;
+use Hyde\Support\Facades\Render;
 use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
@@ -47,7 +48,16 @@ protected static function validateRouteExists(?Route $route, $routeKey): void
             // this method returns null, which silently fails to an empty string.
             // So we instead throw an exception to alert the developer of the issue.
 
-            throw new RouteNotFoundException($routeKey);
+            $exception = new RouteNotFoundException($routeKey);
+
+            // In order to show the developer where this error is, we try to find the faulty Markdown file.
+            $page = Render::getPage();
+            if ($page !== null) {
+                $path = $page->getSourcePath();
+                $exception->setErroredFile($path);
+            }
+
+            throw $exception;
         }
     }
 }

From 12383155c8773356e37a0566ee731bfb1c393012 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:25:11 +0200
Subject: [PATCH 38/90] Try to find the line number of the error

---
 .../Framework/Exceptions/RouteNotFoundException.php  |  7 +++++--
 .../Processing/DynamicMarkdownLinkProcessor.php      | 12 +++++++++++-
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php b/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
index 4e8c05e3d45..61b408b7c0d 100644
--- a/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
+++ b/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
@@ -28,8 +28,11 @@ public function __construct(?string $routeKey = null)
      *
      * @codeCoverageIgnore
      */
-    public function setErroredFile(string $path): void
+    public function setErroredFile(string $path, int $line = 0): void
     {
-        $this->message = rtrim($this->message, '.').sprintf(' (in file [%s])', $path);
+        $this->message = rtrim($this->message, '.').sprintf(' (in file %s)', $path);
+
+        $this->file = realpath($path) ?: $path;
+        $this->line = $line;
     }
 }
diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index c983ca3f638..598ec42eb78 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,8 +5,10 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
+use Hyde\Facades\Filesystem;
 use Hyde\Support\Models\Route;
 use Hyde\Support\Facades\Render;
+use Illuminate\Support\Facades\File;
 use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
@@ -54,7 +56,15 @@ protected static function validateRouteExists(?Route $route, $routeKey): void
             $page = Render::getPage();
             if ($page !== null) {
                 $path = $page->getSourcePath();
-                $exception->setErroredFile($path);
+                $contents = Filesystem::getContents($path);
+                // Try to find the line number of the error.
+                $lineNumber = strpos($contents, $routeKey);
+                if ($lineNumber !== false) {
+                    $lineNumber = substr_count(substr($contents, 0, $lineNumber), "\n") + 1;
+                    $exception->setErroredFile($path, $lineNumber);
+                } else {
+                    $exception->setErroredFile($path);
+                }
             }
 
             throw $exception;

From 5fa57910d5a8e5ef2b1e7e36a9cb669ddd137ecd Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:27:09 +0200
Subject: [PATCH 39/90] Extract method

---
 .../DynamicMarkdownLinkProcessor.php          | 38 ++++++++++++-------
 1 file changed, 25 insertions(+), 13 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 598ec42eb78..8d7d0967930 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -53,21 +53,33 @@ protected static function validateRouteExists(?Route $route, $routeKey): void
             $exception = new RouteNotFoundException($routeKey);
 
             // In order to show the developer where this error is, we try to find the faulty Markdown file.
-            $page = Render::getPage();
-            if ($page !== null) {
-                $path = $page->getSourcePath();
-                $contents = Filesystem::getContents($path);
-                // Try to find the line number of the error.
-                $lineNumber = strpos($contents, $routeKey);
-                if ($lineNumber !== false) {
-                    $lineNumber = substr_count(substr($contents, 0, $lineNumber), "\n") + 1;
-                    $exception->setErroredFile($path, $lineNumber);
-                } else {
-                    $exception->setErroredFile($path);
-                }
-            }
+            self::tryToFindErroredLine($routeKey, $exception);
 
             throw $exception;
         }
     }
+
+    /**
+     * @interal If we use more features like these we may want to wrap the RouteNotFoundException in a custom MarkdownPageException.
+     *
+     * @experimental
+     *
+     * @codeCoverageIgnore
+     */
+    protected static function tryToFindErroredLine($routeKey, RouteNotFoundException $exception): void
+    {
+        $page = Render::getPage();
+        if ($page !== null) {
+            $path = $page->getSourcePath();
+            $contents = Filesystem::getContents($path);
+            // Try to find the line number of the error.
+            $lineNumber = strpos($contents, $routeKey);
+            if ($lineNumber !== false) {
+                $lineNumber = substr_count(substr($contents, 0, $lineNumber), "\n") + 1;
+                $exception->setErroredFile($path, $lineNumber);
+            } else {
+                $exception->setErroredFile($path);
+            }
+        }
+    }
 }

From 475c8efe2f1ce15f643204b26174d009e7dd47fe Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 19:43:14 +0200
Subject: [PATCH 40/90] Test the line finding

---
 .../DynamicMarkdownLinkProcessor.php          |  4 +--
 .../DynamicMarkdownLinksFeatureTest.php       | 26 +++++++++++++++++++
 .../DynamicMarkdownLinkProcessorTest.php      | 16 ++++++++++++
 3 files changed, 43 insertions(+), 3 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 8d7d0967930..458bc3c9d39 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -63,13 +63,11 @@ protected static function validateRouteExists(?Route $route, $routeKey): void
      * @interal If we use more features like these we may want to wrap the RouteNotFoundException in a custom MarkdownPageException.
      *
      * @experimental
-     *
-     * @codeCoverageIgnore
      */
     protected static function tryToFindErroredLine($routeKey, RouteNotFoundException $exception): void
     {
         $page = Render::getPage();
-        if ($page !== null) {
+        if ($page !== null && Filesystem::exists($page->getSourcePath())) {
             $path = $page->getSourcePath();
             $contents = Filesystem::getContents($path);
             // Try to find the line number of the error.
diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 5034aecda8a..9b0e51151ea 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -9,8 +9,11 @@
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
 use Hyde\Pages\InMemoryPage;
+use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Models\Route;
 use Hyde\Foundation\Facades\Routes;
+use Hyde\Framework\Actions\StaticPageBuilder;
+use Hyde\Framework\Exceptions\RouteNotFoundException;
 
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
@@ -155,4 +158,27 @@ public function testMixOfDynamicAndRegularMarkdownLinks()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
+
+    public function testNonExistentRouteThrowsExceptionWithLineLocationWhenRenderingAPage()
+    {
+        $this->file('_pages/test.md', <<<'MARKDOWN'
+        Some
+        Extra
+        Newlines
+
+        [test](hyde::route('non-existent'))
+        
+        And some more text.
+        MARKDOWN);
+
+        try {
+            $page = MarkdownPage::parse('test');
+            StaticPageBuilder::handle($page);
+        } catch (RouteNotFoundException $exception) {
+            $this->assertSame('Route [non-existent] not found (in file _pages/test.md)', $exception->getMessage());
+            $this->assertSame(realpath(Hyde::path('_pages/test.md')), $exception->getFile());
+            $this->assertSame(5, $exception->getLine());
+            $this->assertIsString($exception->getFile());
+        }
+    }
 }
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 4ebc368e653..42192af9878 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -6,7 +6,9 @@
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;
 
+use Mockery;
 use Hyde\Pages\InMemoryPage;
+use Hyde\Pages\MarkdownPage;
 use Hyde\Testing\UnitTestCase;
 use Hyde\Support\Models\Route;
 use Hyde\Support\Facades\Render;
@@ -115,6 +117,20 @@ public function testNonExistentRouteThrowsException()
         DynamicMarkdownLinkProcessor::postprocess($input);
     }
 
+    public function testNonExistentRouteThrowsExceptionWithGracefulLineFindingWhenNoFileSourceExists()
+    {
+        $instance = Mockery::mock(RenderData::class);
+        $instance->shouldReceive('getPage')->andReturn(new MarkdownPage('test'));
+
+        Render::swap($instance);
+
+        $this->expectException(RouteNotFoundException::class);
+        $this->expectExceptionMessage('Route [non-existent] not found.');
+
+        $input = '<p><a href="hyde::route(\'non-existent\')">Non-existent Route</a></p>';
+        DynamicMarkdownLinkProcessor::postprocess($input);
+    }
+
     // Fault tolerance tests
 
     public function testMalformedRouteLink()

From 5da5b2fd5cc8fc62d3cf915810fa4c479a5543b8 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 20:42:44 +0200
Subject: [PATCH 41/90] Revert out of scope line finder

See https://github.com/hydephp/develop/pull/1590#discussion_r1690205820

Revert "Extract helper method"
This reverts commit 61a552beb06f43ae0f8055105a89643154183df0.

Revert "Test the line finding"

This reverts commit 475c8efe2f1ce15f643204b26174d009e7dd47fe.

Revert "Extract method"

This reverts commit 5fa57910d5a8e5ef2b1e7e36a9cb669ddd137ecd.

Revert "Try to find the line number of the error"

This reverts commit 12383155c8773356e37a0566ee731bfb1c393012.

Revert "Try to find the faulty line"

This reverts commit 8e1e51678bb3609e1c396443500b920b39860339.

Revert "Add newline"

This reverts commit 80edd88d786f813e9d72cb66714ae714cd6ce820.

Revert "Add newline"

This reverts commit ee000ced31862c0ba2e26bfe0af007991c708150.
---
 .../Exceptions/RouteNotFoundException.php     | 15 ------
 .../DynamicMarkdownLinkProcessor.php          | 50 +++----------------
 .../DynamicMarkdownLinksFeatureTest.php       | 26 ----------
 .../DynamicMarkdownLinkProcessorTest.php      | 16 ------
 4 files changed, 6 insertions(+), 101 deletions(-)

diff --git a/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php b/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
index 61b408b7c0d..1f173d27f78 100644
--- a/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
+++ b/packages/framework/src/Framework/Exceptions/RouteNotFoundException.php
@@ -20,19 +20,4 @@ public function __construct(?string $routeKey = null)
     {
         parent::__construct($routeKey ? sprintf('Route [%s] not found.', $routeKey) : $this->message);
     }
-
-    /**
-     * @interal
-     *
-     * @experimental
-     *
-     * @codeCoverageIgnore
-     */
-    public function setErroredFile(string $path, int $line = 0): void
-    {
-        $this->message = rtrim($this->message, '.').sprintf(' (in file %s)', $path);
-
-        $this->file = realpath($path) ?: $path;
-        $this->line = $line;
-    }
 }
diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 458bc3c9d39..d6b9796d344 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,10 +5,6 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
-use Hyde\Facades\Filesystem;
-use Hyde\Support\Models\Route;
-use Hyde\Support\Facades\Render;
-use Illuminate\Support\Facades\File;
 use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
@@ -29,8 +25,12 @@ protected static function patterns(): array
         return [
             '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 $route = Hyde::route($matches[2]);
-
-                static::validateRouteExists($route, $matches[2]);
+                if ($route === null) {
+                    // While the other patterns work regardless of if input is valid,
+                    // this method returns null, which silently fails to an empty string.
+                    // So we instead throw an exception to alert the developer of the issue.
+                    throw new RouteNotFoundException($matches[2]);
+                }
 
                 return '<a href="'.$route.'"';
             },
@@ -42,42 +42,4 @@ protected static function patterns(): array
             },
         ];
     }
-
-    protected static function validateRouteExists(?Route $route, $routeKey): void
-    {
-        if ($route === null) {
-            // While the other patterns work regardless of if input is valid,
-            // this method returns null, which silently fails to an empty string.
-            // So we instead throw an exception to alert the developer of the issue.
-
-            $exception = new RouteNotFoundException($routeKey);
-
-            // In order to show the developer where this error is, we try to find the faulty Markdown file.
-            self::tryToFindErroredLine($routeKey, $exception);
-
-            throw $exception;
-        }
-    }
-
-    /**
-     * @interal If we use more features like these we may want to wrap the RouteNotFoundException in a custom MarkdownPageException.
-     *
-     * @experimental
-     */
-    protected static function tryToFindErroredLine($routeKey, RouteNotFoundException $exception): void
-    {
-        $page = Render::getPage();
-        if ($page !== null && Filesystem::exists($page->getSourcePath())) {
-            $path = $page->getSourcePath();
-            $contents = Filesystem::getContents($path);
-            // Try to find the line number of the error.
-            $lineNumber = strpos($contents, $routeKey);
-            if ($lineNumber !== false) {
-                $lineNumber = substr_count(substr($contents, 0, $lineNumber), "\n") + 1;
-                $exception->setErroredFile($path, $lineNumber);
-            } else {
-                $exception->setErroredFile($path);
-            }
-        }
-    }
 }
diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 9b0e51151ea..5034aecda8a 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -9,11 +9,8 @@
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
 use Hyde\Pages\InMemoryPage;
-use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Models\Route;
 use Hyde\Foundation\Facades\Routes;
-use Hyde\Framework\Actions\StaticPageBuilder;
-use Hyde\Framework\Exceptions\RouteNotFoundException;
 
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
@@ -158,27 +155,4 @@ public function testMixOfDynamicAndRegularMarkdownLinks()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
-
-    public function testNonExistentRouteThrowsExceptionWithLineLocationWhenRenderingAPage()
-    {
-        $this->file('_pages/test.md', <<<'MARKDOWN'
-        Some
-        Extra
-        Newlines
-
-        [test](hyde::route('non-existent'))
-        
-        And some more text.
-        MARKDOWN);
-
-        try {
-            $page = MarkdownPage::parse('test');
-            StaticPageBuilder::handle($page);
-        } catch (RouteNotFoundException $exception) {
-            $this->assertSame('Route [non-existent] not found (in file _pages/test.md)', $exception->getMessage());
-            $this->assertSame(realpath(Hyde::path('_pages/test.md')), $exception->getFile());
-            $this->assertSame(5, $exception->getLine());
-            $this->assertIsString($exception->getFile());
-        }
-    }
 }
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 42192af9878..4ebc368e653 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -6,9 +6,7 @@
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;
 
-use Mockery;
 use Hyde\Pages\InMemoryPage;
-use Hyde\Pages\MarkdownPage;
 use Hyde\Testing\UnitTestCase;
 use Hyde\Support\Models\Route;
 use Hyde\Support\Facades\Render;
@@ -117,20 +115,6 @@ public function testNonExistentRouteThrowsException()
         DynamicMarkdownLinkProcessor::postprocess($input);
     }
 
-    public function testNonExistentRouteThrowsExceptionWithGracefulLineFindingWhenNoFileSourceExists()
-    {
-        $instance = Mockery::mock(RenderData::class);
-        $instance->shouldReceive('getPage')->andReturn(new MarkdownPage('test'));
-
-        Render::swap($instance);
-
-        $this->expectException(RouteNotFoundException::class);
-        $this->expectExceptionMessage('Route [non-existent] not found.');
-
-        $input = '<p><a href="hyde::route(\'non-existent\')">Non-existent Route</a></p>';
-        DynamicMarkdownLinkProcessor::postprocess($input);
-    }
-
     // Fault tolerance tests
 
     public function testMalformedRouteLink()

From 2bf321c0b080d8dca574bcf9bacffc5031a13199 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 20:49:53 +0200
Subject: [PATCH 42/90] Generate new documentation with Claude

---
 docs/digging-deeper/advanced-markdown.md | 53 +++++++++++++++++++++---
 1 file changed, 47 insertions(+), 6 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index fd9803663a1..5b4f1225019 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -156,25 +156,66 @@ anything within the path label will be rendered as HTML. This means you can add
 ```
 ````
 
-### Dynamic Markdown links
+## Dynamic Markdown Links
 
-In order to create automatically resolved links from your pages and posts, you can use the special Hyde Markdown link syntax.
+HydePHP provides a powerful feature for creating automatically resolved links within your pages and posts using a special Hyde Markdown link syntax. This feature allows you to generate dynamic links that are resolved based on the current page being rendered.
 
-For all the supported syntax options, Hyde will resolve a relative link based on the current page being rendered.
+### Usage
 
-Since this happens in our Markdown processor, this will work regardless of if you have custom HTML or Blade enabled for your site.
+You can use the following syntax options in your Markdown files:
 
 ```markdown
 <!-- Resolving a route -->
 [Home](hyde::route('home'))
 
 <!-- Resolving a relative link -->
-[Home](hyde::relativeLink('home'))
+[About](hyde::relativeLink('about'))
 
 <!-- Resolving a media asset -->
-![Image](hyde::asset('image.jpg'))
+![Logo](hyde::asset('logo.png'))
 ```
 
+### How It Works
+
+The Hyde Markdown processor handles these special links during the conversion process. This means that the feature works regardless of whether you have custom HTML or Blade enabled for your site.
+
+Here's what each function does:
+
+- `hyde::route()`: Generates a link to a specific route in your Hyde site.
+- `hyde::relativeLink()`: Creates a relative link to another page.
+- `hyde::asset()`: Resolves the path to a media asset in your site.
+
+### Behavior and Error Handling
+
+- If the specified route or asset exists, Hyde will generate the correct URL.
+- If a route specified in `hyde::route()` does not exist, a `RouteNotFoundException` will be thrown. This helps catch errors early in the development process.
+
+>info Note: The exception throwing behavior for non-existent routes is designed to provide immediate feedback during development. In production environments, you may want to handle these exceptions gracefully.
+
+### Best Practices
+
+1. Always double-check that the pages or assets you're linking to exist in your project.
+2. Use meaningful names for your routes to make your Markdown more readable and maintainable.
+3. Consider using `hyde::relativeLink()` for local navigation if your site structure might change.
+
+### Customization
+
+You can customize how Hyde handles dynamic links by modifying the `config/hyde.php` file. For example, you might want to change how non-existent routes are handled in production:
+
+```php
+// filepath: config/hyde.php
+'dynamic_links' => [
+    'throw_exception_on_missing_route' => env('APP_ENV') === 'local',
+],
+```
+
+### Limitations
+
+- The dynamic link syntax is only processed within Markdown files. It won't work in plain HTML or Blade templates.
+- Make sure to use the correct syntax (`hyde::function('parameter')`) as other variations may not be recognized.
+
+By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links.
+
 ### Limitations
 
 The filepaths are hidden on mobile devices using CSS to prevent them from overlapping with the code block.

From 6d43f736811ecee50b6016195fa5f010367064a2 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 20:50:03 +0200
Subject: [PATCH 43/90] Proof generated documentation

---
 docs/digging-deeper/advanced-markdown.md | 40 +++++-------------------
 1 file changed, 8 insertions(+), 32 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 5b4f1225019..26432b77999 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -165,7 +165,7 @@ HydePHP provides a powerful feature for creating automatically resolved links wi
 You can use the following syntax options in your Markdown files:
 
 ```markdown
-<!-- Resolving a route -->
+<!-- Resolving a page route -->
 [Home](hyde::route('home'))
 
 <!-- Resolving a relative link -->
@@ -179,42 +179,18 @@ You can use the following syntax options in your Markdown files:
 
 The Hyde Markdown processor handles these special links during the conversion process. This means that the feature works regardless of whether you have custom HTML or Blade enabled for your site.
 
-Here's what each function does:
-
-- `hyde::route()`: Generates a link to a specific route in your Hyde site.
-- `hyde::relativeLink()`: Creates a relative link to another page.
-- `hyde::asset()`: Resolves the path to a media asset in your site.
-
-### Behavior and Error Handling
-
-- If the specified route or asset exists, Hyde will generate the correct URL.
-- If a route specified in `hyde::route()` does not exist, a `RouteNotFoundException` will be thrown. This helps catch errors early in the development process.
-
->info Note: The exception throwing behavior for non-existent routes is designed to provide immediate feedback during development. In production environments, you may want to handle these exceptions gracefully.
-
-### Best Practices
-
-1. Always double-check that the pages or assets you're linking to exist in your project.
-2. Use meaningful names for your routes to make your Markdown more readable and maintainable.
-3. Consider using `hyde::relativeLink()` for local navigation if your site structure might change.
 
-### Customization
-
-You can customize how Hyde handles dynamic links by modifying the `config/hyde.php` file. For example, you might want to change how non-existent routes are handled in production:
+Here's what each function does:
 
-```php
-// filepath: config/hyde.php
-'dynamic_links' => [
-    'throw_exception_on_missing_route' => env('APP_ENV') === 'local',
-],
-```
+- `hyde::route()`: Generates a link to a specific route in your Hyde site. This is equivalent to `{{ Hyde::route('route.name') }}` in Blade (But we throw if the route doesn't exist).
+- `hyde::relativeLink()`: Creates a relative link to another page. This is equivalent to `{{ Hyde::relativeLink('path') }}` in Blade.
+- `hyde::asset()`: Resolves the path to a media asset in your site. This is equivalent to `{{ Hyde::asset('path') }}` in Blade.
 
-### Limitations
+By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links.
 
-- The dynamic link syntax is only processed within Markdown files. It won't work in plain HTML or Blade templates.
-- Make sure to use the correct syntax (`hyde::function('parameter')`) as other variations may not be recognized.
+### Considerations
 
-By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links.
+**Note:** For the route helper we throw an exception if the route doesn't exist. This is to provide immediate feedback during development.
 
 ### Limitations
 

From 5e96cda5fe2443a42ebb5894e5ca4f347b797a82 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 21:04:44 +0200
Subject: [PATCH 44/90] Streamline documentation

---
 docs/digging-deeper/advanced-markdown.md | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 26432b77999..72ebe98d07e 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -158,7 +158,7 @@ anything within the path label will be rendered as HTML. This means you can add
 
 ## Dynamic Markdown Links
 
-HydePHP provides a powerful feature for creating automatically resolved links within your pages and posts using a special Hyde Markdown link syntax. This feature allows you to generate dynamic links that are resolved based on the current page being rendered.
+HydePHP provides a powerful feature for automatically resolving dynamic links within your pages and posts using a special Hyde Markdown link syntax, designed to match the syntax of the `Hyde` facade.
 
 ### Usage
 
@@ -175,22 +175,25 @@ You can use the following syntax options in your Markdown files:
 ![Logo](hyde::asset('logo.png'))
 ```
 
-### How It Works
+By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links. The feature is always enabled in the Markdown converter.
 
-The Hyde Markdown processor handles these special links during the conversion process. This means that the feature works regardless of whether you have custom HTML or Blade enabled for your site.
 
+### Breakdown
 
-Here's what each function does:
+The example above is equivalent to the following Blade syntax:
 
-- `hyde::route()`: Generates a link to a specific route in your Hyde site. This is equivalent to `{{ Hyde::route('route.name') }}` in Blade (But we throw if the route doesn't exist).
-- `hyde::relativeLink()`: Creates a relative link to another page. This is equivalent to `{{ Hyde::relativeLink('path') }}` in Blade.
-- `hyde::asset()`: Resolves the path to a media asset in your site. This is equivalent to `{{ Hyde::asset('path') }}` in Blade.
+```blade
+<!-- Resolving a page route -->
+{{ Hyde::route('route.name') ?? throw new RouteNotFoundException() }}
 
-By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links.
+<!-- Resolving a relative link -->
+{{ Hyde::relativeLink('path') }}
 
-### Considerations
+<!-- Resolving a media asset -->
+{{ Hyde::asset('path') }}
+```
 
-**Note:** For the route helper we throw an exception if the route doesn't exist. This is to provide immediate feedback during development.
+As you can see, we throw an exception if the route doesn't exist, to provide immediate feedback during development.
 
 ### Limitations
 

From a2b256b6c5f77435e8d90fb41cd82594fc6ff4af Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 21:05:06 +0200
Subject: [PATCH 45/90] Fix documentation location

---
 docs/digging-deeper/advanced-markdown.md | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 72ebe98d07e..60123b9d3f0 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -156,6 +156,11 @@ anything within the path label will be rendered as HTML. This means you can add
 ```
 ````
 
+### Limitations
+
+The filepaths are hidden on mobile devices using CSS to prevent them from overlapping with the code block.
+
+
 ## Dynamic Markdown Links
 
 HydePHP provides a powerful feature for automatically resolving dynamic links within your pages and posts using a special Hyde Markdown link syntax, designed to match the syntax of the `Hyde` facade.
@@ -195,9 +200,6 @@ The example above is equivalent to the following Blade syntax:
 
 As you can see, we throw an exception if the route doesn't exist, to provide immediate feedback during development.
 
-### Limitations
-
-The filepaths are hidden on mobile devices using CSS to prevent them from overlapping with the code block.
 
 ## Configuration
 

From 9589bc17d1165cbc577e298d4500c7aeb9a2c48d Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 21:12:32 +0200
Subject: [PATCH 46/90] Remove dynamic relative link Markdown feature offering
 little value

Can't see too big of a use case for this
---
 docs/digging-deeper/advanced-markdown.md      |  6 ---
 .../DynamicMarkdownLinkProcessor.php          |  3 --
 .../DynamicMarkdownLinksFeatureTest.php       | 20 ++--------
 .../DynamicMarkdownLinkProcessorTest.php      | 38 -------------------
 4 files changed, 3 insertions(+), 64 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 60123b9d3f0..f8d59d14267 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -173,9 +173,6 @@ You can use the following syntax options in your Markdown files:
 <!-- Resolving a page route -->
 [Home](hyde::route('home'))
 
-<!-- Resolving a relative link -->
-[About](hyde::relativeLink('about'))
-
 <!-- Resolving a media asset -->
 ![Logo](hyde::asset('logo.png'))
 ```
@@ -191,9 +188,6 @@ The example above is equivalent to the following Blade syntax:
 <!-- Resolving a page route -->
 {{ Hyde::route('route.name') ?? throw new RouteNotFoundException() }}
 
-<!-- Resolving a relative link -->
-{{ Hyde::relativeLink('path') }}
-
 <!-- Resolving a media asset -->
 {{ Hyde::asset('path') }}
 ```
diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index d6b9796d344..0bbe7643826 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -34,9 +34,6 @@ protected static function patterns(): array
 
                 return '<a href="'.$route.'"';
             },
-            '/<a href="hyde::relativeLink\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
-                return '<a href="'.Hyde::relativeLink($matches[2]).'"';
-            },
             '/<img src="hyde::asset\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
                 return '<img src="'.Hyde::asset($matches[2]).'"';
             },
diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index 5034aecda8a..a4d57aa76a5 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -32,20 +32,16 @@ public function testBasicDynamicMarkdownLinks()
     {
         $input = <<<'MARKDOWN'
         [Home](hyde::route('home'))
-        [About](hyde::relativeLink('about'))
         ![Logo](hyde::asset('logo.png'))
         
         [Home](hyde::route(home))
-        [About](hyde::relativeLink(about))
         ![Logo](hyde::asset(logo.png))
         MARKDOWN;
 
         $expected = <<<'HTML'
         <p><a href="home.html">Home</a>
-        <a href="about">About</a>
         <img src="media/logo.png" alt="Logo" /></p>
         <p><a href="home.html">Home</a>
-        <a href="about">About</a>
         <img src="media/logo.png" alt="Logo" /></p>
 
         HTML;
@@ -59,13 +55,11 @@ public function testDynamicMarkdownLinksWithDoubleQuotes()
 
         $input = <<<'MARKDOWN'
         [Home](hyde::route("home"))
-        [About](hyde::relativeLink("about"))
         ![Logo](hyde::asset("logo.png"))
         MARKDOWN;
 
         $expected = <<<'HTML'
         <p><a href="home.html">Home</a>
-        <a href="about">About</a>
         <img src="media/logo.png" alt="Logo" /></p>
 
         HTML;
@@ -76,13 +70,13 @@ public function testDynamicMarkdownLinksWithDoubleQuotes()
     public function testDynamicMarkdownLinksInParagraphs()
     {
         $input = <<<'MARKDOWN'
-        This is a paragraph with a [link to home](hyde::route('home')) and an [about link](hyde::relativeLink('about')).
+        This is a paragraph with a [link to home](hyde::route('home')).
 
         Another paragraph with an ![image](hyde::asset('image.jpg')).
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p>This is a paragraph with a <a href="home.html">link to home</a> and an <a href="about">about link</a>.</p>
+        <p>This is a paragraph with a <a href="home.html">link to home</a>.</p>
         <p>Another paragraph with an <img src="media/image.jpg" alt="image" />.</p>
 
         HTML;
@@ -94,7 +88,6 @@ public function testDynamicMarkdownLinksInLists()
     {
         $input = <<<'MARKDOWN'
         - [Home](hyde::route('home'))
-        - [About](hyde::relativeLink('about'))
         - ![Logo](hyde::asset('logo.png'))
         MARKDOWN;
 
@@ -104,9 +97,6 @@ public function testDynamicMarkdownLinksInLists()
         <a href="home.html">Home</a>
         </li>
         <li>
-        <a href="about">About</a>
-        </li>
-        <li>
         <img src="media/logo.png" alt="Logo" />
         </li>
         </ul>
@@ -120,12 +110,10 @@ public function testDynamicMarkdownLinksWithNestedRoutes()
     {
         $input = <<<'MARKDOWN'
         [Blog Post](hyde::route('blog/post'))
-        [Relative Blog](hyde::relativeLink('blog/post'))
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="blog/post.html">Blog Post</a>
-        <a href="blog/post">Relative Blog</a></p>
+        <p><a href="blog/post.html">Blog Post</a></p>
 
         HTML;
 
@@ -137,7 +125,6 @@ public function testMixOfDynamicAndRegularMarkdownLinks()
         $input = <<<'MARKDOWN'
         [Home](hyde::route('home'))
         [External](https://example.com)
-        [About](hyde::relativeLink('about'))
         [Regular](regular-link.html)
         ![Logo](hyde::asset('logo.png'))
         ![External Image](https://example.com/image.jpg)
@@ -146,7 +133,6 @@ public function testMixOfDynamicAndRegularMarkdownLinks()
         $expected = <<<'HTML'
         <p><a href="home.html">Home</a>
         <a href="https://example.com">External</a>
-        <a href="about">About</a>
         <a href="regular-link.html">Regular</a>
         <img src="media/logo.png" alt="Logo" />
         <img src="https://example.com/image.jpg" alt="External Image" /></p>
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 4ebc368e653..daca2d7ea34 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -50,22 +50,6 @@ public function testRouteReplacementWithoutQuotes()
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testRelativeLinkReplacement()
-    {
-        $input = '<p><a href="hyde::relativeLink(\'about\')">About</a></p>';
-        $expected = '<p><a href="about">About</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testRelativeLinkReplacementWithoutQuotes()
-    {
-        $input = '<p><a href="hyde::relativeLink(about)">About</a></p>';
-        $expected = '<p><a href="about">About</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
     public function testAssetReplacement()
     {
         $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
@@ -86,13 +70,11 @@ public function testMultipleReplacements()
     {
         $input = <<<'HTML'
         <a href="hyde::route('home')">Home</a>
-        <a href="hyde::relativeLink('about')">About</a>
         <img src="hyde::asset('logo.png')" alt="Logo" />
         HTML;
 
         $expected = <<<'HTML'
         <a href="home.html">Home</a>
-        <a href="about">About</a>
         <img src="media/logo.png" alt="Logo" />
         HTML;
 
@@ -141,14 +123,6 @@ public function testMalformedRouteLink3()
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testMalformedRelativeLink()
-    {
-        $input = '<p><a href="hyde::relativeLink(about\')">Malformed About</a></p>';
-        $expected = '<p><a href="hyde::relativeLink(about\')">Malformed About</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
     public function testMalformedAssetLink()
     {
         $input = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
@@ -165,14 +139,6 @@ public function testEmptyRouteLink()
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testEmptyRelativeLink()
-    {
-        $input = '<p><a href="hyde::relativeLink()">Empty Relative Link</a></p>';
-        $expected = '<p><a href="hyde::relativeLink()">Empty Relative Link</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
     public function testEmptyAssetLink()
     {
         $input = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
@@ -186,8 +152,6 @@ public function testMixedValidAndInvalidLinks()
         $input = <<<'HTML'
         <a href="hyde::route('home')">Valid Home</a>
         <a href="hyde::route(invalid'">Invalid Route</a>
-        <a href="hyde::relativeLink('about')">Valid About</a>
-        <a href="hyde::relativeLink(about')">Invalid Relative</a>
         <img src="hyde::asset('logo.png')" alt="Valid Logo" />
         <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
         HTML;
@@ -195,8 +159,6 @@ public function testMixedValidAndInvalidLinks()
         $expected = <<<'HTML'
         <a href="home.html">Valid Home</a>
         <a href="hyde::route(invalid'">Invalid Route</a>
-        <a href="about">Valid About</a>
-        <a href="hyde::relativeLink(about')">Invalid Relative</a>
         <img src="media/logo.png" alt="Valid Logo" />
         <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
         HTML;

From d4d8762640544f0402c651797715b0303384940e Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 21:47:29 +0200
Subject: [PATCH 47/90] New proof of concept

---
 docs/digging-deeper/advanced-markdown.md      |  38 ++++--
 .../DynamicMarkdownLinkProcessor.php          |  59 +++++----
 .../DynamicMarkdownLinksFeatureTest.php       |  83 ++++++------
 .../DynamicMarkdownLinkProcessorTest.php      | 122 ++++++------------
 4 files changed, 141 insertions(+), 161 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index f8d59d14267..ce04af98bfd 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -163,7 +163,7 @@ The filepaths are hidden on mobile devices using CSS to prevent them from overla
 
 ## Dynamic Markdown Links
 
-HydePHP provides a powerful feature for automatically resolving dynamic links within your pages and posts using a special Hyde Markdown link syntax, designed to match the syntax of the `Hyde` facade.
+HydePHP provides a powerful feature for automatically resolving dynamic links within your pages and posts using source file paths, which are then converted to the appropriate routes in the built site.
 
 ### Usage
 
@@ -171,29 +171,43 @@ You can use the following syntax options in your Markdown files:
 
 ```markdown
 <!-- Resolving a page route -->
-[Home](hyde::route('home'))
+[Home](/_pages/index.blade.php)
 
 <!-- Resolving a media asset -->
-![Logo](hyde::asset('logo.png'))
+![Logo](/_media/logo.svg)
 ```
 
 By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links. The feature is always enabled in the Markdown converter.
 
+### How It Works
 
-### Breakdown
+When you use a source file path in your Markdown links, HydePHP will automatically convert it to the appropriate route or asset path in the built site. For example:
 
-The example above is equivalent to the following Blade syntax:
+- `/_pages/index.blade.php` will be converted to `index.html`
+- `/_pages/blog/post.blade.php` will be converted to `blog/post.html`
+- `/_media/logo.svg` will be converted to `media/logo.svg`
 
-```blade
-<!-- Resolving a page route -->
-{{ Hyde::route('route.name') ?? throw new RouteNotFoundException() }}
+This conversion happens during the build process, ensuring that your links are always up-to-date with your current site structure.
 
-<!-- Resolving a media asset -->
-{{ Hyde::asset('path') }}
-```
+### Benefits
+
+1. **IDE Support**: By using actual file paths, you get better IDE support, including autocompletion and error checking.
+2. **Syntax Highlighting**: Your Markdown editor can provide proper syntax highlighting for these links, as they use standard Markdown syntax.
+3. **Easy Navigation**: You can easily navigate to the source files by clicking on the links in your IDE.
+
+### Limitations
+
+- This syntax doesn't support linking to dynamic routes. For such cases, you may need to use a different approach.
+- If you move or rename source files, make sure to update any Markdown links referencing them to avoid broken links.
+- While this approach provides better IDE support and syntax highlighting, it does couple your content to your project structure. Consider this trade-off when deciding to use this feature.
+
+### Best Practices
 
-As you can see, we throw an exception if the route doesn't exist, to provide immediate feedback during development.
+1. Always use the leading slash (`/`) in your links to ensure consistency and avoid potential issues with relative paths.
+2. Keep your file structure organized and consistent to make it easier to manage links.
+3. Regularly check for broken links in your content, especially after moving or renaming files.
 
+By following these guidelines and understanding the limitations, you can effectively use dynamic Markdown links to create more maintainable and flexible content in your HydePHP projects.
 
 ## Configuration
 
diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 0bbe7643826..5ab0541ad2c 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,38 +5,49 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
-use Hyde\Framework\Exceptions\RouteNotFoundException;
+use Illuminate\Support\Str;
+use Hyde\Support\Filesystem\MediaFile;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
     {
-        foreach (static::patterns() as $pattern => $replacement) {
-            $html = preg_replace_callback($pattern, $replacement, $html);
+        // Todo cache in static property bound to kernel version (but evaluation is tied to rendering page)
+
+        $map = [];
+
+        /** @var \Hyde\Support\Models\Route $route */
+        foreach (Hyde::routes() as $route) {
+            $map[$route->getSourcePath()] = $route;
         }
 
-        return $html;
-    }
+        foreach ($map as $sourcePath => $route) {
+            $patterns = [
+                '<a href="'.$sourcePath.'">',
+                '<a href="/'.$sourcePath.'">',
+            ];
 
-    /** @return array<string, callable(array<int, string>): string> */
-    protected static function patterns(): array
-    {
-        return [
-            '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
-                $route = Hyde::route($matches[2]);
-                if ($route === null) {
-                    // While the other patterns work regardless of if input is valid,
-                    // this method returns null, which silently fails to an empty string.
-                    // So we instead throw an exception to alert the developer of the issue.
-                    throw new RouteNotFoundException($matches[2]);
-                }
-
-                return '<a href="'.$route.'"';
-            },
-            '/<img src="hyde::asset\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
-                return '<img src="'.Hyde::asset($matches[2]).'"';
-            },
-        ];
+            $html = str_replace($patterns, '<a href="'.$route->getLink().'">', $html);
+        }
+
+        // maybe we just need to cache this, as the kernel is already a singleton, but this is not
+        $assetMap = [];
+
+        foreach (MediaFile::all() as $mediaFile) {
+            $assetMap[$mediaFile->getPath()] = $mediaFile;
+        }
+
+        foreach ($assetMap as $path => $mediaFile) {
+            $patterns = [
+                '<img src="'.$path.'"',
+                '<img src="/'.$path.'"',
+            ];
+
+            $localPath = Str::after($mediaFile->getPath(), '_media/');
+            $html = str_replace($patterns, '<img src="'.Hyde::asset($localPath).'"', $html);
+        }
+
+        return $html;
     }
 }
diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index a4d57aa76a5..c88cf429291 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -8,58 +8,41 @@
 
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
-use Hyde\Pages\InMemoryPage;
+use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Models\Route;
 use Hyde\Foundation\Facades\Routes;
 
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
  * @covers \Hyde\Framework\Concerns\Internal\SetsUpMarkdownConverter
- *
- * @see \Hyde\Framework\Testing\Feature\Services\Markdown\DynamicMarkdownLinkProcessorTest
  */
 class DynamicMarkdownLinksFeatureTest extends TestCase
 {
-    protected function setUp(): void
+    public static function setUpBeforeClass(): void
     {
-        parent::setUp();
+        parent::setUpBeforeClass();
 
-        Routes::addRoute(new Route(new InMemoryPage('home')));
-        Routes::addRoute(new Route(new InMemoryPage('blog/post')));
+        touch('_media/logo.png');
+        touch('_media/image.jpg');
     }
 
-    public function testBasicDynamicMarkdownLinks()
+    public static function tearDownAfterClass(): void
     {
-        $input = <<<'MARKDOWN'
-        [Home](hyde::route('home'))
-        ![Logo](hyde::asset('logo.png'))
-        
-        [Home](hyde::route(home))
-        ![Logo](hyde::asset(logo.png))
-        MARKDOWN;
-
-        $expected = <<<'HTML'
-        <p><a href="home.html">Home</a>
-        <img src="media/logo.png" alt="Logo" /></p>
-        <p><a href="home.html">Home</a>
-        <img src="media/logo.png" alt="Logo" /></p>
-
-        HTML;
+        unlink('_media/logo.png');
+        unlink('_media/image.jpg');
 
-        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+        parent::tearDownAfterClass();
     }
 
-    public function testDynamicMarkdownLinksWithDoubleQuotes()
+    public function testBasicDynamicMarkdownLinks()
     {
-        $this->markTestSkipped('https://github.com/hydephp/develop/pull/1590#discussion_r1690082732');
-
         $input = <<<'MARKDOWN'
-        [Home](hyde::route("home"))
-        ![Logo](hyde::asset("logo.png"))
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="home.html">Home</a>
+        <p><a href="index.html">Home</a>
         <img src="media/logo.png" alt="Logo" /></p>
 
         HTML;
@@ -70,13 +53,13 @@ public function testDynamicMarkdownLinksWithDoubleQuotes()
     public function testDynamicMarkdownLinksInParagraphs()
     {
         $input = <<<'MARKDOWN'
-        This is a paragraph with a [link to home](hyde::route('home')).
+        This is a paragraph with a [link to home](/_pages/index.blade.php).
 
-        Another paragraph with an ![image](hyde::asset('image.jpg')).
+        Another paragraph with an ![image](/_media/image.jpg).
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p>This is a paragraph with a <a href="home.html">link to home</a>.</p>
+        <p>This is a paragraph with a <a href="index.html">link to home</a>.</p>
         <p>Another paragraph with an <img src="media/image.jpg" alt="image" />.</p>
 
         HTML;
@@ -87,14 +70,14 @@ public function testDynamicMarkdownLinksInParagraphs()
     public function testDynamicMarkdownLinksInLists()
     {
         $input = <<<'MARKDOWN'
-        - [Home](hyde::route('home'))
-        - ![Logo](hyde::asset('logo.png'))
+        - [Home](/_pages/index.blade.php)
+        - ![Logo](/_media/logo.png)
         MARKDOWN;
 
         $expected = <<<'HTML'
         <ul>
         <li>
-        <a href="home.html">Home</a>
+        <a href="index.html">Home</a>
         </li>
         <li>
         <img src="media/logo.png" alt="Logo" />
@@ -108,12 +91,14 @@ public function testDynamicMarkdownLinksInLists()
 
     public function testDynamicMarkdownLinksWithNestedRoutes()
     {
+        Routes::addRoute(new Route(new MarkdownPage('about/contact')));
+
         $input = <<<'MARKDOWN'
-        [Blog Post](hyde::route('blog/post'))
+        [Contact](/_pages/about/contact.md)
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="blog/post.html">Blog Post</a></p>
+        <p><a href="about/contact.html">Contact</a></p>
 
         HTML;
 
@@ -123,15 +108,15 @@ public function testDynamicMarkdownLinksWithNestedRoutes()
     public function testMixOfDynamicAndRegularMarkdownLinks()
     {
         $input = <<<'MARKDOWN'
-        [Home](hyde::route('home'))
+        [Home](/_pages/index.blade.php)
         [External](https://example.com)
         [Regular](regular-link.html)
-        ![Logo](hyde::asset('logo.png'))
+        ![Logo](/_media/logo.png)
         ![External Image](https://example.com/image.jpg)
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="home.html">Home</a>
+        <p><a href="index.html">Home</a>
         <a href="https://example.com">External</a>
         <a href="regular-link.html">Regular</a>
         <img src="media/logo.png" alt="Logo" />
@@ -141,4 +126,20 @@ public function testMixOfDynamicAndRegularMarkdownLinks()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
+
+    public function testLinksWithLeadingSlash()
+    {
+        $input = <<<'MARKDOWN'
+        [Home with slash](/_pages/index.blade.php)
+        ![Logo with slash](/_media/logo.png)
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p><a href="index.html">Home with slash</a>
+        <img src="media/logo.png" alt="Logo with slash" /></p>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+    }
 }
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index daca2d7ea34..002ba287a8a 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -6,13 +6,13 @@
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;
 
-use Hyde\Pages\InMemoryPage;
+use Hyde\Pages\BladePage;
+use Hyde\Pages\MarkdownPost;
 use Hyde\Testing\UnitTestCase;
 use Hyde\Support\Models\Route;
 use Hyde\Support\Facades\Render;
 use Hyde\Foundation\Facades\Routes;
 use Hyde\Support\Models\RenderData;
-use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 
 /**
@@ -31,37 +31,40 @@ protected function setUp(): void
 
         Render::swap(new RenderData());
 
-        Routes::addRoute(new Route(new InMemoryPage('home')));
+        Routes::addRoute(new Route(new BladePage('index')));
+        Routes::addRoute(new Route(new MarkdownPost('post')));
+
+        // Todo: No way to mock media files, so we are using app.css as a test asset for now.
     }
 
     public function testRouteReplacement()
     {
-        $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
-        $expected = '<p><a href="home.html">Home</a></p>';
+        $input = '<p><a href="_pages/index.blade.php">Home</a></p>';
+        $expected = '<p><a href="index.html">Home</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testRouteReplacementWithoutQuotes()
+    public function testRouteReplacementWithLeadingSlash()
     {
-        $input = '<p><a href="hyde::route(home)">Home</a></p>';
-        $expected = '<p><a href="home.html">Home</a></p>';
+        $input = '<p><a href="/_pages/index.blade.php">Home</a></p>';
+        $expected = '<p><a href="index.html">Home</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testAssetReplacement()
     {
-        $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
-        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
+        $input = '<p><img src="_media/app.css" alt="Logo" /></p>';
+        $expected = '<p><img src="media/app.css" alt="Logo" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testAssetReplacementWithoutQuotes()
+    public function testAssetReplacementWithLeadingSlash()
     {
-        $input = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';
-        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
+        $input = '<p><img src="/_media/app.css" alt="Logo" /></p>';
+        $expected = '<p><img src="media/app.css" alt="Logo" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
@@ -69,13 +72,13 @@ public function testAssetReplacementWithoutQuotes()
     public function testMultipleReplacements()
     {
         $input = <<<'HTML'
-        <a href="hyde::route('home')">Home</a>
-        <img src="hyde::asset('logo.png')" alt="Logo" />
+        <a href="_pages/index.blade.php">Home</a>
+        <img src="_media/app.css" alt="Logo" />
         HTML;
 
         $expected = <<<'HTML'
-        <a href="home.html">Home</a>
-        <img src="media/logo.png" alt="Logo" />
+        <a href="index.html">Home</a>
+        <img src="media/app.css" alt="Logo" />
         HTML;
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
@@ -88,61 +91,28 @@ public function testNoReplacements()
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testNonExistentRouteThrowsException()
-    {
-        $this->expectException(RouteNotFoundException::class);
-        $this->expectExceptionMessage('Route [non-existent] not found.');
-
-        $input = '<p><a href="hyde::route(\'non-existent\')">Non-existent Route</a></p>';
-        DynamicMarkdownLinkProcessor::postprocess($input);
-    }
-
-    // Fault tolerance tests
-
-    public function testMalformedRouteLink()
-    {
-        $input = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
-        $expected = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testMalformedRouteLink2()
-    {
-        $input = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
-        $expected = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testMalformedRouteLink3()
+    public function testNestedRouteReplacement()
     {
-        $input = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
-        $expected = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
+        $input = '<p><a href="_posts/post.md">Blog Post</a></p>';
+        $expected = '<p><a href="posts/post.html">Blog Post</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testMalformedAssetLink()
-    {
-        $input = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
-        $expected = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
+    // Fault tolerance tests
 
-    public function testEmptyRouteLink()
+    public function testNonExistentRouteIsNotReplaced()
     {
-        $input = '<p><a href="hyde::route()">Empty Route</a></p>';
-        $expected = '<p><a href="hyde::route()">Empty Route</a></p>';
+        $input = '<p><a href="_pages/non-existent.blade.php">Non-existent Route</a></p>';
+        $expected = '<p><a href="_pages/non-existent.blade.php">Non-existent Route</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testEmptyAssetLink()
+    public function testNonExistentAssetIsNotReplaced()
     {
-        $input = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
-        $expected = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
+        $input = '<p><img src="_media/non-existent.png" alt="Non-existent Asset" /></p>';
+        $expected = '<p><img src="_media/non-existent.png" alt="Non-existent Asset" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
@@ -150,35 +120,19 @@ public function testEmptyAssetLink()
     public function testMixedValidAndInvalidLinks()
     {
         $input = <<<'HTML'
-        <a href="hyde::route('home')">Valid Home</a>
-        <a href="hyde::route(invalid'">Invalid Route</a>
-        <img src="hyde::asset('logo.png')" alt="Valid Logo" />
-        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
+        <a href="_pages/index.blade.php">Valid Home</a>
+        <a href="_pages/invalid.blade.php">Invalid Route</a>
+        <img src="_media/app.css" alt="Valid Logo" />
+        <img src="_media/invalid.jpg" alt="Invalid Asset" />
         HTML;
 
         $expected = <<<'HTML'
-        <a href="home.html">Valid Home</a>
-        <a href="hyde::route(invalid'">Invalid Route</a>
-        <img src="media/logo.png" alt="Valid Logo" />
-        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
+        <a href="index.html">Valid Home</a>
+        <a href="_pages/invalid.blade.php">Invalid Route</a>
+        <img src="media/app.css" alt="Valid Logo" />
+        <img src="_media/invalid.jpg" alt="Invalid Asset" />
         HTML;
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
-
-    public function testMalformedHydeSyntax()
-    {
-        $input = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
-        $expected = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testNonExistentRouteFunction()
-    {
-        $input = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
-        $expected = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
 }

From 9e613daae4995f0b078c91b1a481db45933b0cce Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Wed, 24 Jul 2024 22:28:58 +0200
Subject: [PATCH 48/90] Improve proof of concept

---
 docs/digging-deeper/advanced-markdown.md      |  55 ++++-----
 .../DynamicMarkdownLinkProcessor.php          |  56 ++++++---
 .../DynamicMarkdownLinksFeatureTest.php       | 107 ++++++++++++++++++
 .../tests/Unit/IncludesFacadeUnitTest.php     |   9 ++
 4 files changed, 176 insertions(+), 51 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index ce04af98bfd..1278f1702a4 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -163,51 +163,40 @@ The filepaths are hidden on mobile devices using CSS to prevent them from overla
 
 ## Dynamic Markdown Links
 
-HydePHP provides a powerful feature for automatically resolving dynamic links within your pages and posts using source file paths, which are then converted to the appropriate routes in the built site.
+## Overview
+HydePHP automatically resolves links in your Markdown files using source file paths, converting them to appropriate routes in the built site.
 
-### Usage
-
-You can use the following syntax options in your Markdown files:
+## Usage
+In your Markdown files, use source file paths for links:
 
 ```markdown
-<!-- Resolving a page route -->
 [Home](/_pages/index.blade.php)
-
-<!-- Resolving a media asset -->
 ![Logo](/_media/logo.svg)
 ```
 
-By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links. The feature is always enabled in the Markdown converter.
-
-### How It Works
-
-When you use a source file path in your Markdown links, HydePHP will automatically convert it to the appropriate route or asset path in the built site. For example:
+## How It Works
+During the build process, HydePHP converts source paths to their corresponding routes:
 
-- `/_pages/index.blade.php` will be converted to `index.html`
-- `/_pages/blog/post.blade.php` will be converted to `blog/post.html`
-- `/_media/logo.svg` will be converted to `media/logo.svg`
-
-This conversion happens during the build process, ensuring that your links are always up-to-date with your current site structure.
-
-### Benefits
-
-1. **IDE Support**: By using actual file paths, you get better IDE support, including autocompletion and error checking.
-2. **Syntax Highlighting**: Your Markdown editor can provide proper syntax highlighting for these links, as they use standard Markdown syntax.
-3. **Easy Navigation**: You can easily navigate to the source files by clicking on the links in your IDE.
-
-### Limitations
+- `/_pages/index.blade.php` becomes `index.html`
+- `/_pages/blog/post.blade.php` becomes `blog/post.html`
+- `/_media/logo.svg` becomes `media/logo.svg`
 
-- This syntax doesn't support linking to dynamic routes. For such cases, you may need to use a different approach.
-- If you move or rename source files, make sure to update any Markdown links referencing them to avoid broken links.
-- While this approach provides better IDE support and syntax highlighting, it does couple your content to your project structure. Consider this trade-off when deciding to use this feature.
+## Benefits
+- Enhanced IDE support (autocompletion, error checking)
+- Proper syntax highlighting in Markdown editors
+- Easy navigation to source files
 
-### Best Practices
+## Limitations
+- Doesn't support dynamic routes
+- Content becomes coupled to project structure
+- Requires manual updates if files are moved or renamed
 
-1. Always use the leading slash (`/`) in your links to ensure consistency and avoid potential issues with relative paths.
-2. Keep your file structure organized and consistent to make it easier to manage links.
-3. Regularly check for broken links in your content, especially after moving or renaming files.
+## Best Practices
+1. Use leading slashes in links for consistency
+2. Maintain an organized file structure
+3. Regularly check for broken links, especially after file operations
 
-By following these guidelines and understanding the limitations, you can effectively use dynamic Markdown links to create more maintainable and flexible content in your HydePHP projects.
+By leveraging this feature, you can create more maintainable content while enjoying improved developer tooling support.
 
 ## Configuration
 
diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 5ab0541ad2c..0a12e54b03c 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -12,6 +12,32 @@
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
+    {
+        foreach (static::routeMap() as $sourcePath => $route) {
+            $patterns = [
+                sprintf('<a href="%s">', $sourcePath),
+                sprintf('<a href="/%s">', $sourcePath),
+            ];
+
+            $html = str_replace($patterns, sprintf('<a href="%s">', $route->getLink()), $html);
+        }
+
+        foreach (static::assetMap() as $path => $mediaFile) {
+            $patterns = [
+                sprintf('<img src="%s"', $path),
+                sprintf('<img src="/%s"', $path),
+            ];
+
+            $html = str_replace($patterns, sprintf('<img src="%s"', static::assetPath($mediaFile)), $html);
+        }
+
+        return $html;
+    }
+
+    /**
+     * @return array<string, \Hyde\Support\Models\Route>
+     */
+    protected static function routeMap(): array
     {
         // Todo cache in static property bound to kernel version (but evaluation is tied to rendering page)
 
@@ -22,15 +48,14 @@ public static function postprocess(string $html): string
             $map[$route->getSourcePath()] = $route;
         }
 
-        foreach ($map as $sourcePath => $route) {
-            $patterns = [
-                '<a href="'.$sourcePath.'">',
-                '<a href="/'.$sourcePath.'">',
-            ];
-
-            $html = str_replace($patterns, '<a href="'.$route->getLink().'">', $html);
-        }
+        return $map;
+    }
 
+    /**
+     * @return array<string, \Hyde\Support\Filesystem\MediaFile>
+     */
+    protected static function assetMap(): array
+    {
         // maybe we just need to cache this, as the kernel is already a singleton, but this is not
         $assetMap = [];
 
@@ -38,16 +63,11 @@ public static function postprocess(string $html): string
             $assetMap[$mediaFile->getPath()] = $mediaFile;
         }
 
-        foreach ($assetMap as $path => $mediaFile) {
-            $patterns = [
-                '<img src="'.$path.'"',
-                '<img src="/'.$path.'"',
-            ];
-
-            $localPath = Str::after($mediaFile->getPath(), '_media/');
-            $html = str_replace($patterns, '<img src="'.Hyde::asset($localPath).'"', $html);
-        }
+        return $assetMap;
+    }
 
-        return $html;
+    protected static function assetPath(MediaFile $mediaFile): string
+    {
+        return Hyde::asset(Str::after($mediaFile->getPath(), '_media/'));
     }
 }
diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index c88cf429291..dd0c4f408c5 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -8,6 +8,7 @@
 
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
+use Hyde\Support\Includes;
 use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Models\Route;
 use Hyde\Foundation\Facades\Routes;
@@ -15,6 +16,8 @@
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
  * @covers \Hyde\Framework\Concerns\Internal\SetsUpMarkdownConverter
+ *
+ * @see \Hyde\Framework\Testing\Feature\Services\Markdown\DynamicMarkdownLinkProcessorTest
  */
 class DynamicMarkdownLinksFeatureTest extends TestCase
 {
@@ -142,4 +145,108 @@ public function testLinksWithLeadingSlash()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
+
+    public function testCanRenderPageWithDynamicMarkdownLinks()
+    {
+        $this->file('_pages/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $page = MarkdownPage::get('test');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="index.html">Home</a>',
+            '<img src="media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testCanRenderNestedPageWithDynamicMarkdownLinks()
+    {
+        $this->file('_pages/nested/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $page = MarkdownPage::get('nested/test');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="../index.html">Home</a>',
+            '<img src="../media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testCanRenderIncludeWithDynamicMarkdownLinks()
+    {
+        // if there is no current path data, we assume the file is included from the root
+
+        $this->file('resources/includes/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $html = Includes::markdown('test')->toHtml();
+
+        $expected = [
+            '<a href="index.html">Home</a>',
+            '<img src="media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testCanRenderIncludeFromNestedPageWithDynamicMarkdownLinks()
+    {
+        $this->mockCurrentPage('nested/test');
+
+        $this->file('resources/includes/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $html = Includes::markdown('test')->toHtml();
+
+        $expected = [
+            '<a href="../index.html">Home</a>',
+            '<img src="../media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
 }
diff --git a/packages/framework/tests/Unit/IncludesFacadeUnitTest.php b/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
index 1da30c9d435..6dac17db2f5 100644
--- a/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
+++ b/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
@@ -9,9 +9,12 @@
 use Hyde\Hyde;
 use Hyde\Support\Includes;
 use Hyde\Testing\UnitTestCase;
+use Hyde\Support\Facades\Render;
 use Illuminate\Support\HtmlString;
+use Hyde\Support\Models\RenderData;
 use Illuminate\Support\Facades\Blade;
 use Illuminate\Filesystem\Filesystem;
+use Hyde\Testing\MocksKernelFeatures;
 
 /**
  * @covers \Hyde\Support\Includes
@@ -20,6 +23,8 @@
  */
 class IncludesFacadeUnitTest extends UnitTestCase
 {
+    use MocksKernelFeatures;
+
     protected static bool $needsKernel = true;
     protected static bool $needsConfig = true;
 
@@ -28,6 +33,10 @@ protected function setUp(): void
         parent::setUp();
 
         Blade::swap(Mockery::mock());
+
+        $this->setupTestKernel();
+        $this->kernel->setRoutes(collect());
+        Render::swap(new RenderData());
     }
 
     protected function tearDown(): void

From 6a5f159d2bd4f6cea4901af7bd4b0e8cb97871c6 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:31:32 +0200
Subject: [PATCH 49/90] Prepare to refactor proof of concept

Want to reimplement these a bit better

Revert "New proof of concept"

This reverts commit d4d8762640544f0402c651797715b0303384940e.

Revert "Improve proof of concept"

This reverts commit 9e613daae4995f0b078c91b1a481db45933b0cce.
---
 docs/digging-deeper/advanced-markdown.md      |  45 ++---
 .../DynamicMarkdownLinkProcessor.php          |  73 ++-----
 .../DynamicMarkdownLinksFeatureTest.php       | 186 ++++--------------
 .../DynamicMarkdownLinkProcessorTest.php      | 122 ++++++++----
 .../tests/Unit/IncludesFacadeUnitTest.php     |   9 -
 5 files changed, 165 insertions(+), 270 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 1278f1702a4..f8d59d14267 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -163,40 +163,37 @@ The filepaths are hidden on mobile devices using CSS to prevent them from overla
 
 ## Dynamic Markdown Links
 
-## Overview
-HydePHP automatically resolves links in your Markdown files using source file paths, converting them to appropriate routes in the built site.
+HydePHP provides a powerful feature for automatically resolving dynamic links within your pages and posts using a special Hyde Markdown link syntax, designed to match the syntax of the `Hyde` facade.
 
-## Usage
-In your Markdown files, use source file paths for links:
+### Usage
+
+You can use the following syntax options in your Markdown files:
 
 ```markdown
-[Home](/_pages/index.blade.php)
-![Logo](/_media/logo.svg)
+<!-- Resolving a page route -->
+[Home](hyde::route('home'))
+
+<!-- Resolving a media asset -->
+![Logo](hyde::asset('logo.png'))
 ```
 
-## How It Works
-During the build process, HydePHP converts source paths to their corresponding routes:
+By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links. The feature is always enabled in the Markdown converter.
 
-- `/_pages/index.blade.php` becomes `index.html`
-- `/_pages/blog/post.blade.php` becomes `blog/post.html`
-- `/_media/logo.svg` becomes `media/logo.svg`
 
-## Benefits
-- Enhanced IDE support (autocompletion, error checking)
-- Proper syntax highlighting in Markdown editors
-- Easy navigation to source files
+### Breakdown
 
-## Limitations
-- Doesn't support dynamic routes
-- Content becomes coupled to project structure
-- Requires manual updates if files are moved or renamed
+The example above is equivalent to the following Blade syntax:
+
+```blade
+<!-- Resolving a page route -->
+{{ Hyde::route('route.name') ?? throw new RouteNotFoundException() }}
+
+<!-- Resolving a media asset -->
+{{ Hyde::asset('path') }}
+```
 
-## Best Practices
-1. Use leading slashes in links for consistency
-2. Maintain an organized file structure
-3. Regularly check for broken links, especially after file operations
+As you can see, we throw an exception if the route doesn't exist, to provide immediate feedback during development.
 
-By leveraging this feature, you can create more maintainable content while enjoying improved developer tooling support.
 
 ## Configuration
 
diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 0a12e54b03c..0bbe7643826 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,69 +5,38 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
-use Illuminate\Support\Str;
-use Hyde\Support\Filesystem\MediaFile;
+use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
     {
-        foreach (static::routeMap() as $sourcePath => $route) {
-            $patterns = [
-                sprintf('<a href="%s">', $sourcePath),
-                sprintf('<a href="/%s">', $sourcePath),
-            ];
-
-            $html = str_replace($patterns, sprintf('<a href="%s">', $route->getLink()), $html);
-        }
-
-        foreach (static::assetMap() as $path => $mediaFile) {
-            $patterns = [
-                sprintf('<img src="%s"', $path),
-                sprintf('<img src="/%s"', $path),
-            ];
-
-            $html = str_replace($patterns, sprintf('<img src="%s"', static::assetPath($mediaFile)), $html);
+        foreach (static::patterns() as $pattern => $replacement) {
+            $html = preg_replace_callback($pattern, $replacement, $html);
         }
 
         return $html;
     }
 
-    /**
-     * @return array<string, \Hyde\Support\Models\Route>
-     */
-    protected static function routeMap(): array
-    {
-        // Todo cache in static property bound to kernel version (but evaluation is tied to rendering page)
-
-        $map = [];
-
-        /** @var \Hyde\Support\Models\Route $route */
-        foreach (Hyde::routes() as $route) {
-            $map[$route->getSourcePath()] = $route;
-        }
-
-        return $map;
-    }
-
-    /**
-     * @return array<string, \Hyde\Support\Filesystem\MediaFile>
-     */
-    protected static function assetMap(): array
-    {
-        // maybe we just need to cache this, as the kernel is already a singleton, but this is not
-        $assetMap = [];
-
-        foreach (MediaFile::all() as $mediaFile) {
-            $assetMap[$mediaFile->getPath()] = $mediaFile;
-        }
-
-        return $assetMap;
-    }
-
-    protected static function assetPath(MediaFile $mediaFile): string
+    /** @return array<string, callable(array<int, string>): string> */
+    protected static function patterns(): array
     {
-        return Hyde::asset(Str::after($mediaFile->getPath(), '_media/'));
+        return [
+            '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+                $route = Hyde::route($matches[2]);
+                if ($route === null) {
+                    // While the other patterns work regardless of if input is valid,
+                    // this method returns null, which silently fails to an empty string.
+                    // So we instead throw an exception to alert the developer of the issue.
+                    throw new RouteNotFoundException($matches[2]);
+                }
+
+                return '<a href="'.$route.'"';
+            },
+            '/<img src="hyde::asset\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
+                return '<img src="'.Hyde::asset($matches[2]).'"';
+            },
+        ];
     }
 }
diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index dd0c4f408c5..a4d57aa76a5 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -8,8 +8,7 @@
 
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
-use Hyde\Support\Includes;
-use Hyde\Pages\MarkdownPage;
+use Hyde\Pages\InMemoryPage;
 use Hyde\Support\Models\Route;
 use Hyde\Foundation\Facades\Routes;
 
@@ -21,31 +20,46 @@
  */
 class DynamicMarkdownLinksFeatureTest extends TestCase
 {
-    public static function setUpBeforeClass(): void
+    protected function setUp(): void
     {
-        parent::setUpBeforeClass();
+        parent::setUp();
 
-        touch('_media/logo.png');
-        touch('_media/image.jpg');
+        Routes::addRoute(new Route(new InMemoryPage('home')));
+        Routes::addRoute(new Route(new InMemoryPage('blog/post')));
     }
 
-    public static function tearDownAfterClass(): void
+    public function testBasicDynamicMarkdownLinks()
     {
-        unlink('_media/logo.png');
-        unlink('_media/image.jpg');
+        $input = <<<'MARKDOWN'
+        [Home](hyde::route('home'))
+        ![Logo](hyde::asset('logo.png'))
+        
+        [Home](hyde::route(home))
+        ![Logo](hyde::asset(logo.png))
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p><a href="home.html">Home</a>
+        <img src="media/logo.png" alt="Logo" /></p>
+        <p><a href="home.html">Home</a>
+        <img src="media/logo.png" alt="Logo" /></p>
+
+        HTML;
 
-        parent::tearDownAfterClass();
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
 
-    public function testBasicDynamicMarkdownLinks()
+    public function testDynamicMarkdownLinksWithDoubleQuotes()
     {
+        $this->markTestSkipped('https://github.com/hydephp/develop/pull/1590#discussion_r1690082732');
+
         $input = <<<'MARKDOWN'
-        [Home](/_pages/index.blade.php)
-        ![Logo](/_media/logo.png)
+        [Home](hyde::route("home"))
+        ![Logo](hyde::asset("logo.png"))
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="index.html">Home</a>
+        <p><a href="home.html">Home</a>
         <img src="media/logo.png" alt="Logo" /></p>
 
         HTML;
@@ -56,13 +70,13 @@ public function testBasicDynamicMarkdownLinks()
     public function testDynamicMarkdownLinksInParagraphs()
     {
         $input = <<<'MARKDOWN'
-        This is a paragraph with a [link to home](/_pages/index.blade.php).
+        This is a paragraph with a [link to home](hyde::route('home')).
 
-        Another paragraph with an ![image](/_media/image.jpg).
+        Another paragraph with an ![image](hyde::asset('image.jpg')).
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p>This is a paragraph with a <a href="index.html">link to home</a>.</p>
+        <p>This is a paragraph with a <a href="home.html">link to home</a>.</p>
         <p>Another paragraph with an <img src="media/image.jpg" alt="image" />.</p>
 
         HTML;
@@ -73,14 +87,14 @@ public function testDynamicMarkdownLinksInParagraphs()
     public function testDynamicMarkdownLinksInLists()
     {
         $input = <<<'MARKDOWN'
-        - [Home](/_pages/index.blade.php)
-        - ![Logo](/_media/logo.png)
+        - [Home](hyde::route('home'))
+        - ![Logo](hyde::asset('logo.png'))
         MARKDOWN;
 
         $expected = <<<'HTML'
         <ul>
         <li>
-        <a href="index.html">Home</a>
+        <a href="home.html">Home</a>
         </li>
         <li>
         <img src="media/logo.png" alt="Logo" />
@@ -94,14 +108,12 @@ public function testDynamicMarkdownLinksInLists()
 
     public function testDynamicMarkdownLinksWithNestedRoutes()
     {
-        Routes::addRoute(new Route(new MarkdownPage('about/contact')));
-
         $input = <<<'MARKDOWN'
-        [Contact](/_pages/about/contact.md)
+        [Blog Post](hyde::route('blog/post'))
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="about/contact.html">Contact</a></p>
+        <p><a href="blog/post.html">Blog Post</a></p>
 
         HTML;
 
@@ -111,15 +123,15 @@ public function testDynamicMarkdownLinksWithNestedRoutes()
     public function testMixOfDynamicAndRegularMarkdownLinks()
     {
         $input = <<<'MARKDOWN'
-        [Home](/_pages/index.blade.php)
+        [Home](hyde::route('home'))
         [External](https://example.com)
         [Regular](regular-link.html)
-        ![Logo](/_media/logo.png)
+        ![Logo](hyde::asset('logo.png'))
         ![External Image](https://example.com/image.jpg)
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="index.html">Home</a>
+        <p><a href="home.html">Home</a>
         <a href="https://example.com">External</a>
         <a href="regular-link.html">Regular</a>
         <img src="media/logo.png" alt="Logo" />
@@ -129,124 +141,4 @@ public function testMixOfDynamicAndRegularMarkdownLinks()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
-
-    public function testLinksWithLeadingSlash()
-    {
-        $input = <<<'MARKDOWN'
-        [Home with slash](/_pages/index.blade.php)
-        ![Logo with slash](/_media/logo.png)
-        MARKDOWN;
-
-        $expected = <<<'HTML'
-        <p><a href="index.html">Home with slash</a>
-        <img src="media/logo.png" alt="Logo with slash" /></p>
-
-        HTML;
-
-        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
-    }
-
-    public function testCanRenderPageWithDynamicMarkdownLinks()
-    {
-        $this->file('_pages/test.md', <<<'MARKDOWN'
-        [Home](/_pages/index.blade.php)
-        ![Logo](/_media/logo.png)
-
-        [non-existent](/_pages/non-existent.md)
-        ![non-existent](/_media/non-existent.png)
-        MARKDOWN);
-
-        $page = MarkdownPage::get('test');
-        Hyde::shareViewData($page);
-        $html = $page->compile();
-
-        $expected = [
-            '<a href="index.html">Home</a>',
-            '<img src="media/logo.png" alt="Logo" />',
-            '<a href="/_pages/non-existent.md">non-existent</a>',
-            '<img src="/_media/non-existent.png" alt="non-existent" />',
-        ];
-
-        foreach ($expected as $expectation) {
-            $this->assertStringContainsString($expectation, $html);
-        }
-    }
-
-    public function testCanRenderNestedPageWithDynamicMarkdownLinks()
-    {
-        $this->file('_pages/nested/test.md', <<<'MARKDOWN'
-        [Home](/_pages/index.blade.php)
-        ![Logo](/_media/logo.png)
-
-        [non-existent](/_pages/non-existent.md)
-        ![non-existent](/_media/non-existent.png)
-        MARKDOWN);
-
-        $page = MarkdownPage::get('nested/test');
-        Hyde::shareViewData($page);
-        $html = $page->compile();
-
-        $expected = [
-            '<a href="../index.html">Home</a>',
-            '<img src="../media/logo.png" alt="Logo" />',
-            '<a href="/_pages/non-existent.md">non-existent</a>',
-            '<img src="/_media/non-existent.png" alt="non-existent" />',
-        ];
-
-        foreach ($expected as $expectation) {
-            $this->assertStringContainsString($expectation, $html);
-        }
-    }
-
-    public function testCanRenderIncludeWithDynamicMarkdownLinks()
-    {
-        // if there is no current path data, we assume the file is included from the root
-
-        $this->file('resources/includes/test.md', <<<'MARKDOWN'
-        [Home](/_pages/index.blade.php)
-        ![Logo](/_media/logo.png)
-
-        [non-existent](/_pages/non-existent.md)
-        ![non-existent](/_media/non-existent.png)
-        MARKDOWN);
-
-        $html = Includes::markdown('test')->toHtml();
-
-        $expected = [
-            '<a href="index.html">Home</a>',
-            '<img src="media/logo.png" alt="Logo" />',
-            '<a href="/_pages/non-existent.md">non-existent</a>',
-            '<img src="/_media/non-existent.png" alt="non-existent" />',
-        ];
-
-        foreach ($expected as $expectation) {
-            $this->assertStringContainsString($expectation, $html);
-        }
-    }
-
-    public function testCanRenderIncludeFromNestedPageWithDynamicMarkdownLinks()
-    {
-        $this->mockCurrentPage('nested/test');
-
-        $this->file('resources/includes/test.md', <<<'MARKDOWN'
-        [Home](/_pages/index.blade.php)
-        ![Logo](/_media/logo.png)
-
-        [non-existent](/_pages/non-existent.md)
-        ![non-existent](/_media/non-existent.png)
-        MARKDOWN);
-
-        $html = Includes::markdown('test')->toHtml();
-
-        $expected = [
-            '<a href="../index.html">Home</a>',
-            '<img src="../media/logo.png" alt="Logo" />',
-            '<a href="/_pages/non-existent.md">non-existent</a>',
-            '<img src="/_media/non-existent.png" alt="non-existent" />',
-        ];
-
-        foreach ($expected as $expectation) {
-            $this->assertStringContainsString($expectation, $html);
-        }
-    }
 }
diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 002ba287a8a..daca2d7ea34 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -6,13 +6,13 @@
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;
 
-use Hyde\Pages\BladePage;
-use Hyde\Pages\MarkdownPost;
+use Hyde\Pages\InMemoryPage;
 use Hyde\Testing\UnitTestCase;
 use Hyde\Support\Models\Route;
 use Hyde\Support\Facades\Render;
 use Hyde\Foundation\Facades\Routes;
 use Hyde\Support\Models\RenderData;
+use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 
 /**
@@ -31,40 +31,37 @@ protected function setUp(): void
 
         Render::swap(new RenderData());
 
-        Routes::addRoute(new Route(new BladePage('index')));
-        Routes::addRoute(new Route(new MarkdownPost('post')));
-
-        // Todo: No way to mock media files, so we are using app.css as a test asset for now.
+        Routes::addRoute(new Route(new InMemoryPage('home')));
     }
 
     public function testRouteReplacement()
     {
-        $input = '<p><a href="_pages/index.blade.php">Home</a></p>';
-        $expected = '<p><a href="index.html">Home</a></p>';
+        $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
+        $expected = '<p><a href="home.html">Home</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testRouteReplacementWithLeadingSlash()
+    public function testRouteReplacementWithoutQuotes()
     {
-        $input = '<p><a href="/_pages/index.blade.php">Home</a></p>';
-        $expected = '<p><a href="index.html">Home</a></p>';
+        $input = '<p><a href="hyde::route(home)">Home</a></p>';
+        $expected = '<p><a href="home.html">Home</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testAssetReplacement()
     {
-        $input = '<p><img src="_media/app.css" alt="Logo" /></p>';
-        $expected = '<p><img src="media/app.css" alt="Logo" /></p>';
+        $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
+        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testAssetReplacementWithLeadingSlash()
+    public function testAssetReplacementWithoutQuotes()
     {
-        $input = '<p><img src="/_media/app.css" alt="Logo" /></p>';
-        $expected = '<p><img src="media/app.css" alt="Logo" /></p>';
+        $input = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';
+        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
@@ -72,13 +69,13 @@ public function testAssetReplacementWithLeadingSlash()
     public function testMultipleReplacements()
     {
         $input = <<<'HTML'
-        <a href="_pages/index.blade.php">Home</a>
-        <img src="_media/app.css" alt="Logo" />
+        <a href="hyde::route('home')">Home</a>
+        <img src="hyde::asset('logo.png')" alt="Logo" />
         HTML;
 
         $expected = <<<'HTML'
-        <a href="index.html">Home</a>
-        <img src="media/app.css" alt="Logo" />
+        <a href="home.html">Home</a>
+        <img src="media/logo.png" alt="Logo" />
         HTML;
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
@@ -91,28 +88,61 @@ public function testNoReplacements()
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testNestedRouteReplacement()
+    public function testNonExistentRouteThrowsException()
     {
-        $input = '<p><a href="_posts/post.md">Blog Post</a></p>';
-        $expected = '<p><a href="posts/post.html">Blog Post</a></p>';
+        $this->expectException(RouteNotFoundException::class);
+        $this->expectExceptionMessage('Route [non-existent] not found.');
 
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+        $input = '<p><a href="hyde::route(\'non-existent\')">Non-existent Route</a></p>';
+        DynamicMarkdownLinkProcessor::postprocess($input);
     }
 
     // Fault tolerance tests
 
-    public function testNonExistentRouteIsNotReplaced()
+    public function testMalformedRouteLink()
+    {
+        $input = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
+        $expected = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMalformedRouteLink2()
+    {
+        $input = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
+        $expected = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMalformedRouteLink3()
+    {
+        $input = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
+        $expected = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMalformedAssetLink()
+    {
+        $input = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
+        $expected = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testEmptyRouteLink()
     {
-        $input = '<p><a href="_pages/non-existent.blade.php">Non-existent Route</a></p>';
-        $expected = '<p><a href="_pages/non-existent.blade.php">Non-existent Route</a></p>';
+        $input = '<p><a href="hyde::route()">Empty Route</a></p>';
+        $expected = '<p><a href="hyde::route()">Empty Route</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testNonExistentAssetIsNotReplaced()
+    public function testEmptyAssetLink()
     {
-        $input = '<p><img src="_media/non-existent.png" alt="Non-existent Asset" /></p>';
-        $expected = '<p><img src="_media/non-existent.png" alt="Non-existent Asset" /></p>';
+        $input = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
+        $expected = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
@@ -120,19 +150,35 @@ public function testNonExistentAssetIsNotReplaced()
     public function testMixedValidAndInvalidLinks()
     {
         $input = <<<'HTML'
-        <a href="_pages/index.blade.php">Valid Home</a>
-        <a href="_pages/invalid.blade.php">Invalid Route</a>
-        <img src="_media/app.css" alt="Valid Logo" />
-        <img src="_media/invalid.jpg" alt="Invalid Asset" />
+        <a href="hyde::route('home')">Valid Home</a>
+        <a href="hyde::route(invalid'">Invalid Route</a>
+        <img src="hyde::asset('logo.png')" alt="Valid Logo" />
+        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
         HTML;
 
         $expected = <<<'HTML'
-        <a href="index.html">Valid Home</a>
-        <a href="_pages/invalid.blade.php">Invalid Route</a>
-        <img src="media/app.css" alt="Valid Logo" />
-        <img src="_media/invalid.jpg" alt="Invalid Asset" />
+        <a href="home.html">Valid Home</a>
+        <a href="hyde::route(invalid'">Invalid Route</a>
+        <img src="media/logo.png" alt="Valid Logo" />
+        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
         HTML;
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
+
+    public function testMalformedHydeSyntax()
+    {
+        $input = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
+        $expected = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testNonExistentRouteFunction()
+    {
+        $input = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
+        $expected = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
 }
diff --git a/packages/framework/tests/Unit/IncludesFacadeUnitTest.php b/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
index 6dac17db2f5..1da30c9d435 100644
--- a/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
+++ b/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
@@ -9,12 +9,9 @@
 use Hyde\Hyde;
 use Hyde\Support\Includes;
 use Hyde\Testing\UnitTestCase;
-use Hyde\Support\Facades\Render;
 use Illuminate\Support\HtmlString;
-use Hyde\Support\Models\RenderData;
 use Illuminate\Support\Facades\Blade;
 use Illuminate\Filesystem\Filesystem;
-use Hyde\Testing\MocksKernelFeatures;
 
 /**
  * @covers \Hyde\Support\Includes
@@ -23,8 +20,6 @@
  */
 class IncludesFacadeUnitTest extends UnitTestCase
 {
-    use MocksKernelFeatures;
-
     protected static bool $needsKernel = true;
     protected static bool $needsConfig = true;
 
@@ -33,10 +28,6 @@ protected function setUp(): void
         parent::setUp();
 
         Blade::swap(Mockery::mock());
-
-        $this->setupTestKernel();
-        $this->kernel->setRoutes(collect());
-        Render::swap(new RenderData());
     }
 
     protected function tearDown(): void

From 9c19e5025063d8575c8e1b0a6972e3a2d1499cb4 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:40:28 +0200
Subject: [PATCH 50/90] Document new dynamic Markdown link feature spec

---
 docs/digging-deeper/advanced-markdown.md | 47 +++++++++++++++---------
 1 file changed, 29 insertions(+), 18 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index f8d59d14267..e0ce47a5a37 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -163,37 +163,48 @@ The filepaths are hidden on mobile devices using CSS to prevent them from overla
 
 ## Dynamic Markdown Links
 
-HydePHP provides a powerful feature for automatically resolving dynamic links within your pages and posts using a special Hyde Markdown link syntax, designed to match the syntax of the `Hyde` facade.
+## Overview
 
-### Usage
+HydePHP provides a powerful feature for automatically converting Markdown links to source files to the corresponding routes in the built site.
 
-You can use the following syntax options in your Markdown files:
+This allows for much better writing experience when using an IDE, as you can easily navigate to the source file by clicking on the link.
 
-```markdown
-<!-- Resolving a page route -->
-[Home](hyde::route('home'))
+## Usage
+
+Using the feature is simple: Just use source file paths for links:
 
-<!-- Resolving a media asset -->
-![Logo](hyde::asset('logo.png'))
+```markdown
+[Home](/_pages/index.blade.php)
+![Logo](/_media/logo.svg)
 ```
 
-By using these dynamic Markdown links, you can create more maintainable and flexible content, allowing your site structure to evolve without breaking internal links. The feature is always enabled in the Markdown converter.
+As you can see, it works for both pages and media assets. The leading slash is optional and will be ignored by Hyde, but including it often gives better IDE support.
 
+### Behind the Scenes
 
-### Breakdown
+During the build process, HydePHP converts source paths to their corresponding routes, and evaluates them depending on the page being rendered.
 
-The example above is equivalent to the following Blade syntax:
+If your page is in the site root then:
 
-```blade
-<!-- Resolving a page route -->
-{{ Hyde::route('route.name') ?? throw new RouteNotFoundException() }}
+- `/_pages/index.blade.php` becomes `index.html`
+- `/_media/logo.svg` becomes `media/logo.svg`
 
-<!-- Resolving a media asset -->
-{{ Hyde::asset('path') }}
-```
+If your page is in a subdirectory then:
+
+- `/_pages/index.blade.php` becomes `../index.html`
+- `/_media/logo.svg` becomes `../media/logo.svg`
+
+Of course, if your page is in a more deeply nested directory, the number of `../` will increase accordingly.
+
+We will of course also match your configured preference for `pretty_urls` and only include the `.html` extension when desired.
+
+### Limitations
 
-As you can see, we throw an exception if the route doesn't exist, to provide immediate feedback during development.
+There are some limitations and considerations to keep in mind when using this feature:
 
+- This feature won't work for dynamic routes (not backed by a file)
+- If you rename a file, links will break. Your IDE may warn about this.
+- If a file is not found, we won't be able to see it when evaluating links.
 
 ## Configuration
 

From 70deb8ca82137a5fd01a77f5e0571afe749d5352 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:43:22 +0200
Subject: [PATCH 51/90] Remove the patterns method

---
 .../DynamicMarkdownLinkProcessor.php          | 21 -------------------
 1 file changed, 21 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 0bbe7643826..ab0dc0a7236 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -18,25 +18,4 @@ public static function postprocess(string $html): string
 
         return $html;
     }
-
-    /** @return array<string, callable(array<int, string>): string> */
-    protected static function patterns(): array
-    {
-        return [
-            '/<a href="hyde::route\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
-                $route = Hyde::route($matches[2]);
-                if ($route === null) {
-                    // While the other patterns work regardless of if input is valid,
-                    // this method returns null, which silently fails to an empty string.
-                    // So we instead throw an exception to alert the developer of the issue.
-                    throw new RouteNotFoundException($matches[2]);
-                }
-
-                return '<a href="'.$route.'"';
-            },
-            '/<img src="hyde::asset\(([\'"]?)([^\'"]+)\1\)"/' => function (array $matches): string {
-                return '<img src="'.Hyde::asset($matches[2]).'"';
-            },
-        ];
-    }
 }

From 780b871d0c7e5fc366518dfce45508c437a221a4 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:44:25 +0200
Subject: [PATCH 52/90] Remove the patterns loop

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php   | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index ab0dc0a7236..cd2888e6bfa 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -12,9 +12,6 @@ class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
     {
-        foreach (static::patterns() as $pattern => $replacement) {
-            $html = preg_replace_callback($pattern, $replacement, $html);
-        }
 
         return $html;
     }

From dee2c96d87af33711b6636ddc213abe3d802f030 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:44:37 +0200
Subject: [PATCH 53/90] Remove unused import

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php     | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index cd2888e6bfa..29ad4a388fa 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,7 +5,6 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
-use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract

From 642ec731c2bacfb9872234c0999e8ddb3e588358 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:44:56 +0200
Subject: [PATCH 54/90] Draft new processing loop

---
 .../Processing/DynamicMarkdownLinkProcessor.php | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 29ad4a388fa..784e8a46e4b 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -11,6 +11,23 @@ class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
     public static function postprocess(string $html): string
     {
+        foreach (static::routeMap() as $sourcePath => $route) {
+            $patterns = [
+                '<a href="'.$sourcePath.'">',
+                '<a href="/'.$sourcePath.'">',
+            ];
+
+            $html = str_replace($patterns, '<a href="'.$route->getLink().'">', $html);
+        }
+
+        foreach (static::assetMap() as $path => $mediaFile) {
+            $patterns = [
+                '<img src="'.$path.'"',
+                '<img src="/'.$path.'"',
+            ];
+
+            $html = str_replace($patterns, '<img src="'.static::assetPath($mediaFile).'"', $html);
+        }
 
         return $html;
     }

From 2b35be29d405747f8d5d500d0e25816ae183a54f Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:45:48 +0200
Subject: [PATCH 55/90] Convert concatenation to 'sprintf()' calls

---
 .../Processing/DynamicMarkdownLinkProcessor.php      | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 784e8a46e4b..e6a3483a1ba 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -13,20 +13,20 @@ public static function postprocess(string $html): string
     {
         foreach (static::routeMap() as $sourcePath => $route) {
             $patterns = [
-                '<a href="'.$sourcePath.'">',
-                '<a href="/'.$sourcePath.'">',
+                sprintf('<a href="%s">', $sourcePath),
+                sprintf('<a href="/%s">', $sourcePath),
             ];
 
-            $html = str_replace($patterns, '<a href="'.$route->getLink().'">', $html);
+            $html = str_replace($patterns, sprintf('<a href="%s">', $route->getLink()), $html);
         }
 
         foreach (static::assetMap() as $path => $mediaFile) {
             $patterns = [
-                '<img src="'.$path.'"',
-                '<img src="/'.$path.'"',
+                sprintf('<img src="%s"', $path),
+                sprintf('<img src="/%s"', $path),
             ];
 
-            $html = str_replace($patterns, '<img src="'.static::assetPath($mediaFile).'"', $html);
+            $html = str_replace($patterns, sprintf('<img src="%s"', static::assetPath($mediaFile)), $html);
         }
 
         return $html;

From 2afc335e06ac1ff09fd1bac354d31efbaa9a4e05 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:46:12 +0200
Subject: [PATCH 56/90] Implement the route map method

---
 .../Processing/DynamicMarkdownLinkProcessor.php   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index e6a3483a1ba..5efab805bd6 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -31,4 +31,19 @@ public static function postprocess(string $html): string
 
         return $html;
     }
+
+    /**
+     * @return array<string, \Hyde\Support\Models\Route>
+     */
+    protected static function routeMap(): array
+    {
+        $map = [];
+
+        /** @var \Hyde\Support\Models\Route $route */
+        foreach (Hyde::routes() as $route) {
+            $map[$route->getSourcePath()] = $route;
+        }
+
+        return $map;
+    }
 }

From 04a0a7c09f9d57530e7b2da17251fa476ffe54db Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:46:47 +0200
Subject: [PATCH 57/90] Implement the asset map method

---
 .../Processing/DynamicMarkdownLinkProcessor.php   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 5efab805bd6..a334a5cbf06 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,6 +5,7 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
+use Hyde\Support\Filesystem\MediaFile;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
@@ -46,4 +47,18 @@ protected static function routeMap(): array
 
         return $map;
     }
+
+    /**
+     * @return array<string, \Hyde\Support\Filesystem\MediaFile>
+     */
+    protected static function assetMap(): array
+    {
+        $assetMap = [];
+
+        foreach (MediaFile::all() as $mediaFile) {
+            $assetMap[$mediaFile->getPath()] = $mediaFile;
+        }
+
+        return $assetMap;
+    }
 }

From 48efa5ea4f2824aa49a0ed8ce6b9c01ddbc1405d Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:47:04 +0200
Subject: [PATCH 58/90] Implement the asset path method

---
 .../Markdown/Processing/DynamicMarkdownLinkProcessor.php    | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index a334a5cbf06..4086e23e03b 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -5,6 +5,7 @@
 namespace Hyde\Markdown\Processing;
 
 use Hyde\Hyde;
+use Illuminate\Support\Str;
 use Hyde\Support\Filesystem\MediaFile;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
@@ -61,4 +62,9 @@ protected static function assetMap(): array
 
         return $assetMap;
     }
+
+    protected static function assetPath(MediaFile $mediaFile): string
+    {
+        return Hyde::asset(Str::after($mediaFile->getPath(), '_media/'));
+    }
 }

From f8c2c22db84aad3ebb8dfc0bc8c783b8ed385770 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 10:47:08 +0200
Subject: [PATCH 59/90] Add todo

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 4086e23e03b..247a41d3c14 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -50,6 +50,8 @@ protected static function routeMap(): array
     }
 
     /**
+     * @todo Consider adding caching, since this is not a singleton like the routes.
+     *
      * @return array<string, \Hyde\Support\Filesystem\MediaFile>
      */
     protected static function assetMap(): array

From b5d8f71096019d61b3b7101a3306e755b140cac7 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:01:53 +0200
Subject: [PATCH 60/90] Update imports

---
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php     | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index daca2d7ea34..e50098cfcc6 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -6,13 +6,12 @@
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;
 
-use Hyde\Pages\InMemoryPage;
+use Hyde\Pages\MarkdownPost;
 use Hyde\Testing\UnitTestCase;
 use Hyde\Support\Models\Route;
 use Hyde\Support\Facades\Render;
 use Hyde\Foundation\Facades\Routes;
 use Hyde\Support\Models\RenderData;
-use Hyde\Framework\Exceptions\RouteNotFoundException;
 use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 
 /**

From 37b8f84caf1214fa5043aaa56d4aa8b653e2d60f Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:02:01 +0200
Subject: [PATCH 61/90] Add import

---
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php       | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index e50098cfcc6..3fdf5cee477 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -6,6 +6,7 @@
 
 namespace Hyde\Framework\Testing\Feature\Services\Markdown;
 
+use Hyde\Pages\BladePage;
 use Hyde\Pages\MarkdownPost;
 use Hyde\Testing\UnitTestCase;
 use Hyde\Support\Models\Route;

From a44357d96441b925b29d61e1abcf1ded977d0762 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:02:12 +0200
Subject: [PATCH 62/90] Update route mocks

---
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 3fdf5cee477..d5c82d9ed89 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -31,7 +31,8 @@ protected function setUp(): void
 
         Render::swap(new RenderData());
 
-        Routes::addRoute(new Route(new InMemoryPage('home')));
+        Routes::addRoute(new Route(new BladePage('index')));
+        Routes::addRoute(new Route(new MarkdownPost('post')));
     }
 
     public function testRouteReplacement()

From c175cb585ec4c88ca092a6c6876dad4f13202613 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:02:53 +0200
Subject: [PATCH 63/90] Remove old exception test

---
 .../Markdown/DynamicMarkdownLinkProcessorTest.php        | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index d5c82d9ed89..81e9e3fa443 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -89,15 +89,6 @@ public function testNoReplacements()
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testNonExistentRouteThrowsException()
-    {
-        $this->expectException(RouteNotFoundException::class);
-        $this->expectExceptionMessage('Route [non-existent] not found.');
-
-        $input = '<p><a href="hyde::route(\'non-existent\')">Non-existent Route</a></p>';
-        DynamicMarkdownLinkProcessor::postprocess($input);
-    }
-
     // Fault tolerance tests
 
     public function testMalformedRouteLink()

From a8be72d63cba247dc80f470271c7b0652d28dcfc Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:03:22 +0200
Subject: [PATCH 64/90] Remove old fault tolerance tests

---
 .../DynamicMarkdownLinkProcessorTest.php         | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 81e9e3fa443..a11e4b07083 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -157,20 +157,4 @@ public function testMixedValidAndInvalidLinks()
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
-
-    public function testMalformedHydeSyntax()
-    {
-        $input = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
-        $expected = '<p><a href="hyde:route(\'home\')">Malformed Hyde Syntax</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testNonExistentRouteFunction()
-    {
-        $input = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
-        $expected = '<p><a href="hyde::nonexistent(\'home\')">Non-existent Function</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
 }

From 77af426995451c0133cf1ae34929c2894a4f540d Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:04:18 +0200
Subject: [PATCH 65/90] Remove old fault tolerance tests

---
 .../DynamicMarkdownLinkProcessorTest.php      | 69 -------------------
 1 file changed, 69 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index a11e4b07083..3da31d46cd2 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -88,73 +88,4 @@ public function testNoReplacements()
 
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
-
-    // Fault tolerance tests
-
-    public function testMalformedRouteLink()
-    {
-        $input = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
-        $expected = '<p><a href="hyde::route(\'home">Malformed Home</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testMalformedRouteLink2()
-    {
-        $input = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
-        $expected = '<p><a href="hyde::route(\'home)">Malformed Home</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testMalformedRouteLink3()
-    {
-        $input = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
-        $expected = '<p><a href="hyde::route(\'home\'">Malformed Home</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testMalformedAssetLink()
-    {
-        $input = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
-        $expected = '<p><img src="hyde::asset(\'image.jpg" alt="Malformed Image" /></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testEmptyRouteLink()
-    {
-        $input = '<p><a href="hyde::route()">Empty Route</a></p>';
-        $expected = '<p><a href="hyde::route()">Empty Route</a></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testEmptyAssetLink()
-    {
-        $input = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
-        $expected = '<p><img src="hyde::asset()" alt="Empty Asset" /></p>';
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
-
-    public function testMixedValidAndInvalidLinks()
-    {
-        $input = <<<'HTML'
-        <a href="hyde::route('home')">Valid Home</a>
-        <a href="hyde::route(invalid'">Invalid Route</a>
-        <img src="hyde::asset('logo.png')" alt="Valid Logo" />
-        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
-        HTML;
-
-        $expected = <<<'HTML'
-        <a href="home.html">Valid Home</a>
-        <a href="hyde::route(invalid'">Invalid Route</a>
-        <img src="media/logo.png" alt="Valid Logo" />
-        <img src="hyde::asset('image.jpg" alt="Invalid Asset" />
-        HTML;
-
-        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
-    }
 }

From c3a46c957d803433c18356cf7419a06049bc134b Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:05:05 +0200
Subject: [PATCH 66/90] Add new fault tolerance tests

---
 .../DynamicMarkdownLinkProcessorTest.php      | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 3da31d46cd2..cf90f6ccd1d 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -88,4 +88,41 @@ public function testNoReplacements()
 
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
+
+    // Fault tolerance tests
+
+    public function testNonExistentRouteIsNotReplaced()
+    {
+        $input = '<p><a href="_pages/non-existent.blade.php">Non-existent Route</a></p>';
+        $expected = '<p><a href="_pages/non-existent.blade.php">Non-existent Route</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testNonExistentAssetIsNotReplaced()
+    {
+        $input = '<p><img src="_media/non-existent.png" alt="Non-existent Asset" /></p>';
+        $expected = '<p><img src="_media/non-existent.png" alt="Non-existent Asset" /></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
+    public function testMixedValidAndInvalidLinks()
+    {
+        $input = <<<'HTML'
+        <a href="_pages/index.blade.php">Valid Home</a>
+        <a href="_pages/invalid.blade.php">Invalid Route</a>
+        <img src="_media/logo.png" alt="Valid Logo" />
+        <img src="_media/invalid.jpg" alt="Invalid Asset" />
+        HTML;
+
+        $expected = <<<'HTML'
+        <a href="index.html">Valid Home</a>
+        <a href="_pages/invalid.blade.php">Invalid Route</a>
+        <img src="media/logo.png" alt="Valid Logo" />
+        <img src="_media/invalid.jpg" alt="Invalid Asset" />
+        HTML;
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
 }

From b79d983f5a112c01892d739e744ba25685a76db5 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:06:06 +0200
Subject: [PATCH 67/90] Update test for the new dynamic Markdown link feature

---
 .../DynamicMarkdownLinkProcessorTest.php      | 34 ++++++++++++-------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index cf90f6ccd1d..6e5969a2e05 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -37,32 +37,32 @@ protected function setUp(): void
 
     public function testRouteReplacement()
     {
-        $input = '<p><a href="hyde::route(\'home\')">Home</a></p>';
-        $expected = '<p><a href="home.html">Home</a></p>';
+        $input = '<p><a href="_pages/index.blade.php">Home</a></p>';
+        $expected = '<p><a href="index.html">Home</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testRouteReplacementWithoutQuotes()
+    public function testRouteReplacementWithLeadingSlash()
     {
-        $input = '<p><a href="hyde::route(home)">Home</a></p>';
-        $expected = '<p><a href="home.html">Home</a></p>';
+        $input = '<p><a href="/_pages/index.blade.php">Home</a></p>';
+        $expected = '<p><a href="index.html">Home</a></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testAssetReplacement()
     {
-        $input = '<p><img src="hyde::asset(\'image.jpg\')" alt="Image" /></p>';
-        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
+        $input = '<p><img src="_media/logo.png" alt="Logo" /></p>';
+        $expected = '<p><img src="media/logo.png" alt="Logo" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
-    public function testAssetReplacementWithoutQuotes()
+    public function testAssetReplacementWithLeadingSlash()
     {
-        $input = '<p><img src="hyde::asset(image.jpg)" alt="Image" /></p>';
-        $expected = '<p><img src="media/image.jpg" alt="Image" /></p>';
+        $input = '<p><img src="/_media/logo.png" alt="Logo" /></p>';
+        $expected = '<p><img src="media/logo.png" alt="Logo" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
@@ -70,12 +70,12 @@ public function testAssetReplacementWithoutQuotes()
     public function testMultipleReplacements()
     {
         $input = <<<'HTML'
-        <a href="hyde::route('home')">Home</a>
-        <img src="hyde::asset('logo.png')" alt="Logo" />
+        <a href="_pages/index.blade.php">Home</a>
+        <img src="_media/logo.png" alt="Logo" />
         HTML;
 
         $expected = <<<'HTML'
-        <a href="home.html">Home</a>
+        <a href="index.html">Home</a>
         <img src="media/logo.png" alt="Logo" />
         HTML;
 
@@ -89,6 +89,14 @@ public function testNoReplacements()
         $this->assertSame($input, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
+    public function testNestedRouteReplacement()
+    {
+        $input = '<p><a href="_posts/post.md">Blog Post</a></p>';
+        $expected = '<p><a href="posts/post.html">Blog Post</a></p>';
+
+        $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
+    }
+
     // Fault tolerance tests
 
     public function testNonExistentRouteIsNotReplaced()

From c6445010ee6ada62cd13c584c94736d08f8912ff Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:06:26 +0200
Subject: [PATCH 68/90] Use existing file pending mock support

---
 .../DynamicMarkdownLinkProcessorTest.php       | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 6e5969a2e05..002ba287a8a 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -33,6 +33,8 @@ protected function setUp(): void
 
         Routes::addRoute(new Route(new BladePage('index')));
         Routes::addRoute(new Route(new MarkdownPost('post')));
+
+        // Todo: No way to mock media files, so we are using app.css as a test asset for now.
     }
 
     public function testRouteReplacement()
@@ -53,16 +55,16 @@ public function testRouteReplacementWithLeadingSlash()
 
     public function testAssetReplacement()
     {
-        $input = '<p><img src="_media/logo.png" alt="Logo" /></p>';
-        $expected = '<p><img src="media/logo.png" alt="Logo" /></p>';
+        $input = '<p><img src="_media/app.css" alt="Logo" /></p>';
+        $expected = '<p><img src="media/app.css" alt="Logo" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
 
     public function testAssetReplacementWithLeadingSlash()
     {
-        $input = '<p><img src="/_media/logo.png" alt="Logo" /></p>';
-        $expected = '<p><img src="media/logo.png" alt="Logo" /></p>';
+        $input = '<p><img src="/_media/app.css" alt="Logo" /></p>';
+        $expected = '<p><img src="media/app.css" alt="Logo" /></p>';
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
@@ -71,12 +73,12 @@ public function testMultipleReplacements()
     {
         $input = <<<'HTML'
         <a href="_pages/index.blade.php">Home</a>
-        <img src="_media/logo.png" alt="Logo" />
+        <img src="_media/app.css" alt="Logo" />
         HTML;
 
         $expected = <<<'HTML'
         <a href="index.html">Home</a>
-        <img src="media/logo.png" alt="Logo" />
+        <img src="media/app.css" alt="Logo" />
         HTML;
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
@@ -120,14 +122,14 @@ public function testMixedValidAndInvalidLinks()
         $input = <<<'HTML'
         <a href="_pages/index.blade.php">Valid Home</a>
         <a href="_pages/invalid.blade.php">Invalid Route</a>
-        <img src="_media/logo.png" alt="Valid Logo" />
+        <img src="_media/app.css" alt="Valid Logo" />
         <img src="_media/invalid.jpg" alt="Invalid Asset" />
         HTML;
 
         $expected = <<<'HTML'
         <a href="index.html">Valid Home</a>
         <a href="_pages/invalid.blade.php">Invalid Route</a>
-        <img src="media/logo.png" alt="Valid Logo" />
+        <img src="media/app.css" alt="Valid Logo" />
         <img src="_media/invalid.jpg" alt="Invalid Asset" />
         HTML;
 

From 6e50913ecefa775945a039d2024d7e41f0a5e076 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:08:11 +0200
Subject: [PATCH 69/90] Replace feature test setup with lower level filesystem
 configuration

---
 .../tests/Feature/DynamicMarkdownLinksFeatureTest.php     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index a4d57aa76a5..f2cd450f7bd 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -20,12 +20,12 @@
  */
 class DynamicMarkdownLinksFeatureTest extends TestCase
 {
-    protected function setUp(): void
+    public static function setUpBeforeClass(): void
     {
-        parent::setUp();
+        parent::setUpBeforeClass();
 
-        Routes::addRoute(new Route(new InMemoryPage('home')));
-        Routes::addRoute(new Route(new InMemoryPage('blog/post')));
+        touch('_media/logo.png');
+        touch('_media/image.jpg');
     }
 
     public function testBasicDynamicMarkdownLinks()

From 6d6d75388e0a617434247b780f167487ba280d36 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:08:58 +0200
Subject: [PATCH 70/90] Tear down filesystem after class

---
 .../tests/Feature/DynamicMarkdownLinksFeatureTest.php     | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index f2cd450f7bd..acebe47a10c 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -28,6 +28,14 @@ public static function setUpBeforeClass(): void
         touch('_media/image.jpg');
     }
 
+    public static function tearDownAfterClass(): void
+    {
+        unlink('_media/logo.png');
+        unlink('_media/image.jpg');
+
+        parent::tearDownAfterClass();
+    }
+
     public function testBasicDynamicMarkdownLinks()
     {
         $input = <<<'MARKDOWN'

From 48558faec24b40118ff28877a7f23abf939b0cb8 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:09:37 +0200
Subject: [PATCH 71/90] Update test for the new dynamic Markdown link feature

---
 .../DynamicMarkdownLinksFeatureTest.php       | 72 +++++++++----------
 1 file changed, 34 insertions(+), 38 deletions(-)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index acebe47a10c..b720b006b4a 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -8,7 +8,8 @@
 
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
-use Hyde\Pages\InMemoryPage;
+use Hyde\Support\Includes;
+use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Models\Route;
 use Hyde\Foundation\Facades\Routes;
 
@@ -39,35 +40,12 @@ public static function tearDownAfterClass(): void
     public function testBasicDynamicMarkdownLinks()
     {
         $input = <<<'MARKDOWN'
-        [Home](hyde::route('home'))
-        ![Logo](hyde::asset('logo.png'))
-        
-        [Home](hyde::route(home))
-        ![Logo](hyde::asset(logo.png))
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="home.html">Home</a>
-        <img src="media/logo.png" alt="Logo" /></p>
-        <p><a href="home.html">Home</a>
-        <img src="media/logo.png" alt="Logo" /></p>
-
-        HTML;
-
-        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
-    }
-
-    public function testDynamicMarkdownLinksWithDoubleQuotes()
-    {
-        $this->markTestSkipped('https://github.com/hydephp/develop/pull/1590#discussion_r1690082732');
-
-        $input = <<<'MARKDOWN'
-        [Home](hyde::route("home"))
-        ![Logo](hyde::asset("logo.png"))
-        MARKDOWN;
-
-        $expected = <<<'HTML'
-        <p><a href="home.html">Home</a>
+        <p><a href="index.html">Home</a>
         <img src="media/logo.png" alt="Logo" /></p>
 
         HTML;
@@ -78,13 +56,13 @@ public function testDynamicMarkdownLinksWithDoubleQuotes()
     public function testDynamicMarkdownLinksInParagraphs()
     {
         $input = <<<'MARKDOWN'
-        This is a paragraph with a [link to home](hyde::route('home')).
+        This is a paragraph with a [link to home](/_pages/index.blade.php).
 
-        Another paragraph with an ![image](hyde::asset('image.jpg')).
+        Another paragraph with an ![image](/_media/image.jpg).
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p>This is a paragraph with a <a href="home.html">link to home</a>.</p>
+        <p>This is a paragraph with a <a href="index.html">link to home</a>.</p>
         <p>Another paragraph with an <img src="media/image.jpg" alt="image" />.</p>
 
         HTML;
@@ -95,14 +73,14 @@ public function testDynamicMarkdownLinksInParagraphs()
     public function testDynamicMarkdownLinksInLists()
     {
         $input = <<<'MARKDOWN'
-        - [Home](hyde::route('home'))
-        - ![Logo](hyde::asset('logo.png'))
+        - [Home](/_pages/index.blade.php)
+        - ![Logo](/_media/logo.png)
         MARKDOWN;
 
         $expected = <<<'HTML'
         <ul>
         <li>
-        <a href="home.html">Home</a>
+        <a href="index.html">Home</a>
         </li>
         <li>
         <img src="media/logo.png" alt="Logo" />
@@ -116,12 +94,14 @@ public function testDynamicMarkdownLinksInLists()
 
     public function testDynamicMarkdownLinksWithNestedRoutes()
     {
+        Routes::addRoute(new Route(new MarkdownPage('about/contact')));
+
         $input = <<<'MARKDOWN'
-        [Blog Post](hyde::route('blog/post'))
+        [Contact](/_pages/about/contact.md)
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="blog/post.html">Blog Post</a></p>
+        <p><a href="about/contact.html">Contact</a></p>
 
         HTML;
 
@@ -131,15 +111,15 @@ public function testDynamicMarkdownLinksWithNestedRoutes()
     public function testMixOfDynamicAndRegularMarkdownLinks()
     {
         $input = <<<'MARKDOWN'
-        [Home](hyde::route('home'))
+        [Home](/_pages/index.blade.php)
         [External](https://example.com)
         [Regular](regular-link.html)
-        ![Logo](hyde::asset('logo.png'))
+        ![Logo](/_media/logo.png)
         ![External Image](https://example.com/image.jpg)
         MARKDOWN;
 
         $expected = <<<'HTML'
-        <p><a href="home.html">Home</a>
+        <p><a href="index.html">Home</a>
         <a href="https://example.com">External</a>
         <a href="regular-link.html">Regular</a>
         <img src="media/logo.png" alt="Logo" />
@@ -149,4 +129,20 @@ public function testMixOfDynamicAndRegularMarkdownLinks()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
+
+    public function testLinksWithLeadingSlash()
+    {
+        $input = <<<'MARKDOWN'
+        [Home with slash](/_pages/index.blade.php)
+        ![Logo with slash](/_media/logo.png)
+        MARKDOWN;
+
+        $expected = <<<'HTML'
+        <p><a href="index.html">Home with slash</a>
+        <img src="media/logo.png" alt="Logo with slash" /></p>
+
+        HTML;
+
+        $this->assertSame($expected, Hyde::markdown($input)->toHtml());
+    }
 }

From 60786a556133fc1b26e131b7e34deb23a5149e58 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:10:00 +0200
Subject: [PATCH 72/90] Add more high level feature test cases

---
 .../DynamicMarkdownLinksFeatureTest.php       | 104 ++++++++++++++++++
 1 file changed, 104 insertions(+)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index b720b006b4a..dd0c4f408c5 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -145,4 +145,108 @@ public function testLinksWithLeadingSlash()
 
         $this->assertSame($expected, Hyde::markdown($input)->toHtml());
     }
+
+    public function testCanRenderPageWithDynamicMarkdownLinks()
+    {
+        $this->file('_pages/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $page = MarkdownPage::get('test');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="index.html">Home</a>',
+            '<img src="media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testCanRenderNestedPageWithDynamicMarkdownLinks()
+    {
+        $this->file('_pages/nested/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $page = MarkdownPage::get('nested/test');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="../index.html">Home</a>',
+            '<img src="../media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testCanRenderIncludeWithDynamicMarkdownLinks()
+    {
+        // if there is no current path data, we assume the file is included from the root
+
+        $this->file('resources/includes/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $html = Includes::markdown('test')->toHtml();
+
+        $expected = [
+            '<a href="index.html">Home</a>',
+            '<img src="media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testCanRenderIncludeFromNestedPageWithDynamicMarkdownLinks()
+    {
+        $this->mockCurrentPage('nested/test');
+
+        $this->file('resources/includes/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        ![Logo](/_media/logo.png)
+
+        [non-existent](/_pages/non-existent.md)
+        ![non-existent](/_media/non-existent.png)
+        MARKDOWN);
+
+        $html = Includes::markdown('test')->toHtml();
+
+        $expected = [
+            '<a href="../index.html">Home</a>',
+            '<img src="../media/logo.png" alt="Logo" />',
+            '<a href="/_pages/non-existent.md">non-existent</a>',
+            '<img src="/_media/non-existent.png" alt="non-existent" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
 }

From 75fc296b167e9f1f3ea83675eb76ace0b737e499 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:10:18 +0200
Subject: [PATCH 73/90] Update unit test to mock the kernel routes

---
 packages/framework/tests/Unit/IncludesFacadeUnitTest.php | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/packages/framework/tests/Unit/IncludesFacadeUnitTest.php b/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
index 1da30c9d435..6dac17db2f5 100644
--- a/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
+++ b/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
@@ -9,9 +9,12 @@
 use Hyde\Hyde;
 use Hyde\Support\Includes;
 use Hyde\Testing\UnitTestCase;
+use Hyde\Support\Facades\Render;
 use Illuminate\Support\HtmlString;
+use Hyde\Support\Models\RenderData;
 use Illuminate\Support\Facades\Blade;
 use Illuminate\Filesystem\Filesystem;
+use Hyde\Testing\MocksKernelFeatures;
 
 /**
  * @covers \Hyde\Support\Includes
@@ -20,6 +23,8 @@
  */
 class IncludesFacadeUnitTest extends UnitTestCase
 {
+    use MocksKernelFeatures;
+
     protected static bool $needsKernel = true;
     protected static bool $needsConfig = true;
 
@@ -28,6 +33,10 @@ protected function setUp(): void
         parent::setUp();
 
         Blade::swap(Mockery::mock());
+
+        $this->setupTestKernel();
+        $this->kernel->setRoutes(collect());
+        Render::swap(new RenderData());
     }
 
     protected function tearDown(): void

From f0e006475de0fcf40a601e0279622e50917f5b97 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 11:26:24 +0200
Subject: [PATCH 74/90] Add static variable to cache the asset map in memory

This change makes it go from a constant ~2ms per call to essentially zero (0.000ms avg on 100 000 iterations)
---
 .../Markdown/Processing/DynamicMarkdownLinkProcessor.php  | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 247a41d3c14..db0e4fc411a 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -50,13 +50,15 @@ protected static function routeMap(): array
     }
 
     /**
-     * @todo Consider adding caching, since this is not a singleton like the routes.
-     *
      * @return array<string, \Hyde\Support\Filesystem\MediaFile>
      */
     protected static function assetMap(): array
     {
-        $assetMap = [];
+        static $assetMap = null;
+
+        if ($assetMap !== null) {
+            return $assetMap;
+        }
 
         foreach (MediaFile::all() as $mediaFile) {
             $assetMap[$mediaFile->getPath()] = $mediaFile;

From 25a7328633e76e218abfc84e1b8a1b2001bf4fbe Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:05:10 +0200
Subject: [PATCH 75/90] Refactor static variable to a static property

---
 .../DynamicMarkdownLinkProcessor.php          | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index db0e4fc411a..a69b2561d48 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -11,6 +11,11 @@
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
+    /**
+     * @var array<string, \Hyde\Support\Filesystem\MediaFile>|null
+     */
+    protected static ?array $assetMapCache = null;
+
     public static function postprocess(string $html): string
     {
         foreach (static::routeMap() as $sourcePath => $route) {
@@ -54,17 +59,15 @@ protected static function routeMap(): array
      */
     protected static function assetMap(): array
     {
-        static $assetMap = null;
-
-        if ($assetMap !== null) {
-            return $assetMap;
-        }
+        if (static::$assetMapCache === null) {
+            static::$assetMapCache = [];
 
-        foreach (MediaFile::all() as $mediaFile) {
-            $assetMap[$mediaFile->getPath()] = $mediaFile;
+            foreach (MediaFile::all() as $mediaFile) {
+                static::$assetMapCache[$mediaFile->getPath()] = $mediaFile;
+            }
         }
 
-        return $assetMap;
+        return static::$assetMapCache;
     }
 
     protected static function assetPath(MediaFile $mediaFile): string

From ae464632e21f8e1ea80dda750d54a4c9b1a5c908 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:05:47 +0200
Subject: [PATCH 76/90] Add internal testing helper to reset the asset map
 cache

---
 .../Markdown/Processing/DynamicMarkdownLinkProcessor.php  | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index a69b2561d48..b1e2ed237a7 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -74,4 +74,12 @@ protected static function assetPath(MediaFile $mediaFile): string
     {
         return Hyde::asset(Str::after($mediaFile->getPath(), '_media/'));
     }
+
+    /**
+     * @internal Testing helper to reset the asset map cache.
+     */
+    public static function resetAssetMapCache(): void
+    {
+        static::$assetMapCache = null;
+    }
 }

From 8755f49db95e38f85f9a7210a729e08f10874573 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:06:18 +0200
Subject: [PATCH 77/90] Reset the asset map cache

---
 .../tests/Feature/DynamicMarkdownLinksFeatureTest.php          | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index dd0c4f408c5..cdf9a416eca 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -12,6 +12,7 @@
 use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Models\Route;
 use Hyde\Foundation\Facades\Routes;
+use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 
 /**
  * @covers \Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor
@@ -27,6 +28,8 @@ public static function setUpBeforeClass(): void
 
         touch('_media/logo.png');
         touch('_media/image.jpg');
+
+        DynamicMarkdownLinkProcessor::resetAssetMapCache();
     }
 
     public static function tearDownAfterClass(): void

From 1b7bfcb2840efdf2909c6c55ea21999ac46f4604 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:16:45 +0200
Subject: [PATCH 78/90] Ignore coverage

---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index b1e2ed237a7..a7f3971617c 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -77,6 +77,8 @@ protected static function assetPath(MediaFile $mediaFile): string
 
     /**
      * @internal Testing helper to reset the asset map cache.
+     *
+     * @codeCoverageIgnore Only used in tests, where it's implicitly covered.
      */
     public static function resetAssetMapCache(): void
     {

From 7e7927b094e10d2fe4e77de21eb6b79f466d49d2 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:19:54 +0200
Subject: [PATCH 79/90] Revert "Ignore coverage"

This reverts commit 1b7bfcb2840efdf2909c6c55ea21999ac46f4604.
---
 .../src/Markdown/Processing/DynamicMarkdownLinkProcessor.php    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index a7f3971617c..b1e2ed237a7 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -77,8 +77,6 @@ protected static function assetPath(MediaFile $mediaFile): string
 
     /**
      * @internal Testing helper to reset the asset map cache.
-     *
-     * @codeCoverageIgnore Only used in tests, where it's implicitly covered.
      */
     public static function resetAssetMapCache(): void
     {

From 76672b26571309cd6ea6c7aa34af74626375450e Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:20:40 +0200
Subject: [PATCH 80/90] Test the method

---
 .../Services/Markdown/DynamicMarkdownLinkProcessorTest.php | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
index 002ba287a8a..67acd7ffe39 100644
--- a/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
+++ b/packages/framework/tests/Feature/Services/Markdown/DynamicMarkdownLinkProcessorTest.php
@@ -135,4 +135,11 @@ public function testMixedValidAndInvalidLinks()
 
         $this->assertSame($expected, DynamicMarkdownLinkProcessor::postprocess($input));
     }
+
+    public function testResetAssetMapCache()
+    {
+        DynamicMarkdownLinkProcessor::resetAssetMapCache();
+
+        $this->assertTrue(true);
+    }
 }

From 7ed5a854debdd3725605bec460a43ad7728f3bf1 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:22:07 +0200
Subject: [PATCH 81/90] Compress PHPDoc annotations

---
 .../Processing/DynamicMarkdownLinkProcessor.php  | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index b1e2ed237a7..39a083cb7c6 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -11,9 +11,7 @@
 
 class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 {
-    /**
-     * @var array<string, \Hyde\Support\Filesystem\MediaFile>|null
-     */
+    /** @var array<string, \Hyde\Support\Filesystem\MediaFile>|null */
     protected static ?array $assetMapCache = null;
 
     public static function postprocess(string $html): string
@@ -39,9 +37,7 @@ public static function postprocess(string $html): string
         return $html;
     }
 
-    /**
-     * @return array<string, \Hyde\Support\Models\Route>
-     */
+    /** @return array<string, \Hyde\Support\Models\Route> */
     protected static function routeMap(): array
     {
         $map = [];
@@ -54,9 +50,7 @@ protected static function routeMap(): array
         return $map;
     }
 
-    /**
-     * @return array<string, \Hyde\Support\Filesystem\MediaFile>
-     */
+    /** @return array<string, \Hyde\Support\Filesystem\MediaFile> */
     protected static function assetMap(): array
     {
         if (static::$assetMapCache === null) {
@@ -75,9 +69,7 @@ protected static function assetPath(MediaFile $mediaFile): string
         return Hyde::asset(Str::after($mediaFile->getPath(), '_media/'));
     }
 
-    /**
-     * @internal Testing helper to reset the asset map cache.
-     */
+    /** @internal Testing helper to reset the asset map cache. */
     public static function resetAssetMapCache(): void
     {
         static::$assetMapCache = null;

From 376d3eccbae2b418c3c9d5f6fbd2dc6f664e27e9 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:25:18 +0200
Subject: [PATCH 82/90] Normalize the signatures to be looser and match images

---
 .../Markdown/Processing/DynamicMarkdownLinkProcessor.php    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 39a083cb7c6..f31f1db76fb 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -18,11 +18,11 @@ public static function postprocess(string $html): string
     {
         foreach (static::routeMap() as $sourcePath => $route) {
             $patterns = [
-                sprintf('<a href="%s">', $sourcePath),
-                sprintf('<a href="/%s">', $sourcePath),
+                sprintf('<a href="%s"', $sourcePath),
+                sprintf('<a href="/%s"', $sourcePath),
             ];
 
-            $html = str_replace($patterns, sprintf('<a href="%s">', $route->getLink()), $html);
+            $html = str_replace($patterns, sprintf('<a href="%s"', $route->getLink()), $html);
         }
 
         foreach (static::assetMap() as $path => $mediaFile) {

From 831c83c6aa9a36d0d63f4f948dc0deb3f23bc958 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:25:57 +0200
Subject: [PATCH 83/90] Normalize the loop variable name

---
 .../Markdown/Processing/DynamicMarkdownLinkProcessor.php    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index f31f1db76fb..7dc220855e0 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -25,10 +25,10 @@ public static function postprocess(string $html): string
             $html = str_replace($patterns, sprintf('<a href="%s"', $route->getLink()), $html);
         }
 
-        foreach (static::assetMap() as $path => $mediaFile) {
+        foreach (static::assetMap() as $sourcePath => $mediaFile) {
             $patterns = [
-                sprintf('<img src="%s"', $path),
-                sprintf('<img src="/%s"', $path),
+                sprintf('<img src="%s"', $sourcePath),
+                sprintf('<img src="/%s"', $sourcePath),
             ];
 
             $html = str_replace($patterns, sprintf('<img src="%s"', static::assetPath($mediaFile)), $html);

From 851b17a5e0dec626ae56c3a7ed20bc6e2d482a50 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:31:39 +0200
Subject: [PATCH 84/90] Refactor to extract methods for common logic

---
 .../DynamicMarkdownLinkProcessor.php          | 31 ++++++++++++-------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index 7dc220855e0..fc9e6b45330 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -6,6 +6,7 @@
 
 use Hyde\Hyde;
 use Illuminate\Support\Str;
+use Hyde\Support\Models\Route;
 use Hyde\Support\Filesystem\MediaFile;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
@@ -16,27 +17,35 @@ class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 
     public static function postprocess(string $html): string
     {
-        foreach (static::routeMap() as $sourcePath => $route) {
-            $patterns = [
-                sprintf('<a href="%s"', $sourcePath),
-                sprintf('<a href="/%s"', $sourcePath),
-            ];
+        $html = static::processMap(static::routeMap(), $html, 'a', 'href');
+        $html = static::processMap(static::assetMap(), $html, 'img', 'src');
 
-            $html = str_replace($patterns, sprintf('<a href="%s"', $route->getLink()), $html);
-        }
+        return $html;
+    }
 
-        foreach (static::assetMap() as $sourcePath => $mediaFile) {
+    /**
+     * @param array<string, \Hyde\Support\Models\Route|\Hyde\Support\Filesystem\MediaFile> $map
+     */
+    protected static function processMap(array $map, string $html, string $tag, string $attribute): string
+    {
+        foreach ($map as $sourcePath => $item) {
             $patterns = [
-                sprintf('<img src="%s"', $sourcePath),
-                sprintf('<img src="/%s"', $sourcePath),
+                sprintf('<%s %s="%s"', $tag, $attribute, $sourcePath),
+                sprintf('<%s %s="/%s"', $tag, $attribute, $sourcePath),
             ];
 
-            $html = str_replace($patterns, sprintf('<img src="%s"', static::assetPath($mediaFile)), $html);
+            $replacement = sprintf('<%s %s="%s"', $tag, $attribute, static::getItemPath($item));
+            $html = str_replace($patterns, $replacement, $html);
         }
 
         return $html;
     }
 
+    protected static function getItemPath(MediaFile|Route $item): string
+    {
+        return $item instanceof MediaFile ? static::assetPath($item) : $item->getLink();
+    }
+
     /** @return array<string, \Hyde\Support\Models\Route> */
     protected static function routeMap(): array
     {

From ede0cdf2b0c7259044f38e2593cf54b464fd874b Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:31:42 +0200
Subject: [PATCH 85/90] Revert "Refactor to extract methods for common logic"

This reverts commit 851b17a5e0dec626ae56c3a7ed20bc6e2d482a50. Cleaner is not always better.
---
 .../DynamicMarkdownLinkProcessor.php          | 31 +++++++------------
 1 file changed, 11 insertions(+), 20 deletions(-)

diff --git a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
index fc9e6b45330..7dc220855e0 100644
--- a/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
+++ b/packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
@@ -6,7 +6,6 @@
 
 use Hyde\Hyde;
 use Illuminate\Support\Str;
-use Hyde\Support\Models\Route;
 use Hyde\Support\Filesystem\MediaFile;
 use Hyde\Markdown\Contracts\MarkdownPostProcessorContract;
 
@@ -17,35 +16,27 @@ class DynamicMarkdownLinkProcessor implements MarkdownPostProcessorContract
 
     public static function postprocess(string $html): string
     {
-        $html = static::processMap(static::routeMap(), $html, 'a', 'href');
-        $html = static::processMap(static::assetMap(), $html, 'img', 'src');
+        foreach (static::routeMap() as $sourcePath => $route) {
+            $patterns = [
+                sprintf('<a href="%s"', $sourcePath),
+                sprintf('<a href="/%s"', $sourcePath),
+            ];
 
-        return $html;
-    }
+            $html = str_replace($patterns, sprintf('<a href="%s"', $route->getLink()), $html);
+        }
 
-    /**
-     * @param array<string, \Hyde\Support\Models\Route|\Hyde\Support\Filesystem\MediaFile> $map
-     */
-    protected static function processMap(array $map, string $html, string $tag, string $attribute): string
-    {
-        foreach ($map as $sourcePath => $item) {
+        foreach (static::assetMap() as $sourcePath => $mediaFile) {
             $patterns = [
-                sprintf('<%s %s="%s"', $tag, $attribute, $sourcePath),
-                sprintf('<%s %s="/%s"', $tag, $attribute, $sourcePath),
+                sprintf('<img src="%s"', $sourcePath),
+                sprintf('<img src="/%s"', $sourcePath),
             ];
 
-            $replacement = sprintf('<%s %s="%s"', $tag, $attribute, static::getItemPath($item));
-            $html = str_replace($patterns, $replacement, $html);
+            $html = str_replace($patterns, sprintf('<img src="%s"', static::assetPath($mediaFile)), $html);
         }
 
         return $html;
     }
 
-    protected static function getItemPath(MediaFile|Route $item): string
-    {
-        return $item instanceof MediaFile ? static::assetPath($item) : $item->getLink();
-    }
-
     /** @return array<string, \Hyde\Support\Models\Route> */
     protected static function routeMap(): array
     {

From 4a46a584cc93be51cf7df6b4484819526886f798 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 16:33:24 +0200
Subject: [PATCH 86/90] Document that relative links is not supported here

Would take a ton of complexity
---
 docs/digging-deeper/advanced-markdown.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index e0ce47a5a37..791213a6a39 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -205,6 +205,7 @@ There are some limitations and considerations to keep in mind when using this fe
 - This feature won't work for dynamic routes (not backed by a file)
 - If you rename a file, links will break. Your IDE may warn about this.
 - If a file is not found, we won't be able to see it when evaluating links.
+- Relative links are not supported (so ../_pages/index.blade.php won't work)
 
 ## Configuration
 

From 5cbde9cc429c54b9e95fce3928f9258fc1edfa81 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 18:10:55 +0200
Subject: [PATCH 87/90] Add more feature tests

---
 .../DynamicMarkdownLinksFeatureTest.php       | 145 ++++++++++++++++++
 1 file changed, 145 insertions(+)

diff --git a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
index cdf9a416eca..60208243185 100644
--- a/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
+++ b/packages/framework/tests/Feature/DynamicMarkdownLinksFeatureTest.php
@@ -10,7 +10,9 @@
 use Hyde\Testing\TestCase;
 use Hyde\Support\Includes;
 use Hyde\Pages\MarkdownPage;
+use Hyde\Pages\MarkdownPost;
 use Hyde\Support\Models\Route;
+use Hyde\Pages\DocumentationPage;
 use Hyde\Foundation\Facades\Routes;
 use Hyde\Markdown\Processing\DynamicMarkdownLinkProcessor;
 
@@ -252,4 +254,147 @@ public function testCanRenderIncludeFromNestedPageWithDynamicMarkdownLinks()
             $this->assertStringContainsString($expectation, $html);
         }
     }
+
+    public function testDynamicMarkdownLinksForDifferentPageTypes()
+    {
+        $this->file('_pages/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        [Documentation](/_docs/index.md)
+        [Readme](/_docs/readme.md)
+        [Example](/_pages/example.md)
+        [Contact](/_pages/about/contact.md)
+        [About](/_pages/about/index.md)
+        [Post](/_posts/hello-world.md)
+        
+        ![Logo](/_media/logo.png)
+        MARKDOWN);
+
+        Routes::addRoute(new Route(new MarkdownPage('example')));
+        Routes::addRoute(new Route(new MarkdownPage('about/index')));
+        Routes::addRoute(new Route(new MarkdownPage('about/contact')));
+        Routes::addRoute(new Route(new MarkdownPost('hello-world')));
+        Routes::addRoute(new Route(new DocumentationPage('index')));
+        Routes::addRoute(new Route(new DocumentationPage('readme')));
+
+        $page = MarkdownPage::get('test');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="index.html">Home</a>',
+            '<a href="docs/index.html">Documentation</a>',
+            '<a href="docs/readme.html">Readme</a>',
+            '<a href="example.html">Example</a>',
+            '<a href="about/contact.html">Contact</a>',
+            '<a href="about/index.html">About</a>',
+            '<a href="posts/hello-world.html">Post</a>',
+            '<img src="media/logo.png" alt="Logo" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testDynamicMarkdownLinksUseTheSitePrettyUrlConfiguration()
+    {
+        config(['hyde.pretty_urls' => true]);
+
+        $this->file('_pages/test.md', <<<'MARKDOWN'
+        [Home](/_pages/index.blade.php)
+        [Documentation](/_docs/index.md)
+        [Readme](/_docs/readme.md)
+        [Example](/_pages/example.md)
+        [Contact](/_pages/about/contact.md)
+        [About](/_pages/about/index.md)
+        [Post](/_posts/hello-world.md)
+        
+        ![Logo](/_media/logo.png)
+        MARKDOWN);
+
+        Routes::addRoute(new Route(new MarkdownPage('example')));
+        Routes::addRoute(new Route(new MarkdownPage('about/index')));
+        Routes::addRoute(new Route(new MarkdownPage('about/contact')));
+        Routes::addRoute(new Route(new MarkdownPost('hello-world')));
+        Routes::addRoute(new Route(new DocumentationPage('index')));
+        Routes::addRoute(new Route(new DocumentationPage('readme')));
+
+        $page = MarkdownPage::get('test');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="./">Home</a>',
+            '<a href="docs/">Documentation</a>',
+            '<a href="docs/readme">Readme</a>',
+            '<a href="example">Example</a>',
+            '<a href="about/contact">Contact</a>',
+            '<a href="about/">About</a>',
+            '<a href="posts/hello-world">Post</a>',
+            '<img src="media/logo.png" alt="Logo" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
+
+    public function testDynamicMarkdownLinksFromDifferentPageTypes()
+    {
+        $links = <<<'MARKDOWN'
+        [Docs](/_docs/docs.md)
+        [Post](/_posts/post.md)
+        [Page](/_pages/page.md)
+        ![Logo](/_media/logo.png)
+        MARKDOWN;
+
+        $this->file('_docs/docs.md', $links);
+        $this->file('_posts/post.md', $links);
+        $this->file('_pages/page.md', $links);
+
+        $page = DocumentationPage::get('docs');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="../docs/docs.html">Docs</a>',
+            '<a href="../posts/post.html">Post</a>',
+            '<a href="../page.html">Page</a>',
+            '<img src="../media/logo.png" alt="Logo" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+
+        $page = MarkdownPost::get('post');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="../docs/docs.html">Docs</a>',
+            '<a href="../posts/post.html">Post</a>',
+            '<a href="../page.html">Page</a>',
+            '<img src="../media/logo.png" alt="Logo" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+
+        $page = MarkdownPage::get('page');
+        Hyde::shareViewData($page);
+        $html = $page->compile();
+
+        $expected = [
+            '<a href="docs/docs.html">Docs</a>',
+            '<a href="posts/post.html">Post</a>',
+            '<a href="page.html">Page</a>',
+            '<img src="media/logo.png" alt="Logo" />',
+        ];
+
+        foreach ($expected as $expectation) {
+            $this->assertStringContainsString($expectation, $html);
+        }
+    }
 }

From a2bd4468a04a4ee45e53c6db39428ac7487b9653 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 18:11:44 +0200
Subject: [PATCH 88/90] Clean up the documentation

---
 docs/digging-deeper/advanced-markdown.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index 791213a6a39..b2852df3828 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -163,18 +163,18 @@ The filepaths are hidden on mobile devices using CSS to prevent them from overla
 
 ## Dynamic Markdown Links
 
-## Overview
-
 HydePHP provides a powerful feature for automatically converting Markdown links to source files to the corresponding routes in the built site.
 
-This allows for much better writing experience when using an IDE, as you can easily navigate to the source file by clicking on the link.
+This allows for much better writing experience when using an IDE, as you can easily navigate to the source file by clicking on the link. Hyde will then automatically resolve the link to the correct route when building the site, formatting the links properly using dynamic relative paths and your configured `pretty_urls` setting.
 
 ## Usage
 
-Using the feature is simple: Just use source file paths for links:
+Using the feature is simple: Just use the source file path when linking to the page you want to resolve:
 
 ```markdown
 [Home](/_pages/index.blade.php)
+[Docs](/_docs/index.md)
+[Featured Post](/_posts/hello-world.md)
 ![Logo](/_media/logo.svg)
 ```
 

From a307b8899169eb3e553db3bd369c4c9ba97a4e51 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 18:11:58 +0200
Subject: [PATCH 89/90] Proof the documentation

---
 docs/digging-deeper/advanced-markdown.md | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/digging-deeper/advanced-markdown.md b/docs/digging-deeper/advanced-markdown.md
index b2852df3828..2fe8bd3648d 100644
--- a/docs/digging-deeper/advanced-markdown.md
+++ b/docs/digging-deeper/advanced-markdown.md
@@ -165,7 +165,7 @@ The filepaths are hidden on mobile devices using CSS to prevent them from overla
 
 HydePHP provides a powerful feature for automatically converting Markdown links to source files to the corresponding routes in the built site.
 
-This allows for much better writing experience when using an IDE, as you can easily navigate to the source file by clicking on the link. Hyde will then automatically resolve the link to the correct route when building the site, formatting the links properly using dynamic relative paths and your configured `pretty_urls` setting.
+This allows for a much better writing experience when using an IDE, as you can easily navigate to the source file by clicking on the link. Hyde will then automatically resolve the link to the correct route when building the site, formatting the links properly using dynamic relative paths and your configured `pretty_urls` setting.
 
 ## Usage
 
@@ -182,7 +182,7 @@ As you can see, it works for both pages and media assets. The leading slash is o
 
 ### Behind the Scenes
 
-During the build process, HydePHP converts source paths to their corresponding routes, and evaluates them depending on the page being rendered.
+During the build process, HydePHP converts source paths to their corresponding routes and evaluates them depending on the page being rendered.
 
 If your page is in the site root then:
 
@@ -196,16 +196,16 @@ If your page is in a subdirectory then:
 
 Of course, if your page is in a more deeply nested directory, the number of `../` will increase accordingly.
 
-We will of course also match your configured preference for `pretty_urls` and only include the `.html` extension when desired.
+We will also match your configured preference for `pretty_urls` and only include the `.html` extension when desired.
 
 ### Limitations
 
 There are some limitations and considerations to keep in mind when using this feature:
 
-- This feature won't work for dynamic routes (not backed by a file)
+- This feature will not work for dynamic routes (not backed by a file)
 - If you rename a file, links will break. Your IDE may warn about this.
-- If a file is not found, we won't be able to see it when evaluating links.
-- Relative links are not supported (so ../_pages/index.blade.php won't work)
+- If a file is not found, we will not be able to see it when evaluating links.
+- Relative links are not supported (so `../_pages/index.blade.php` will not work)
 
 ## Configuration
 

From 2ae3ef998f8710a819e1722cd7ebc338c5f86ff0 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Thu, 25 Jul 2024 18:12:02 +0200
Subject: [PATCH 90/90] Update RELEASE_NOTES.md

---
 RELEASE_NOTES.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index 3871aafcb54..86740ca0d9c 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -11,6 +11,7 @@ This serves two purposes:
 
 ### Added
 - You can now specify navigation priorities by adding a numeric prefix to the source file names in https://github.com/hydephp/develop/pull/1709
+- Added support for resolving dynamic links to source files in Markdown documents in https://github.com/hydephp/develop/pull/1590
 - Added a new `\Hyde\Framework\Actions\PreBuildTasks\TransferMediaAssets` build task handle media assets transfers for site builds.
 - Added a new `\Hyde\Framework\Exceptions\ParseException` exception class to handle parsing exceptions in data collection files in https://github.com/hydephp/develop/pull/1732
 - Added a new `\Hyde\Framework\Exceptions\InvalidConfigurationException` exception class to handle invalid configuration exceptions in https://github.com/hydephp/develop/pull/1799