Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hyde::copy() helper #310

Closed
caendesilva opened this issue Jul 31, 2022 · 2 comments
Closed

Remove Hyde::copy() helper #310

caendesilva opened this issue Jul 31, 2022 · 2 comments

Comments

@caendesilva
Copy link
Member

Besides in tests, the only place we use this helper, is in a single file, PublishesHomepageView.php. That does not to me justify the complexity it adds. Closing this issue, and will remove the helper instead.

Originally posted by @caendesilva in #298 (comment)
@caendesilva
Copy link
Member Author

Or, since it's useful in tests, we could keep it around, but just simplify it. What bothers me is that it has so many outcomes. Making it just be a wrapper for the copy function, using the configured path, would be better.

@caendesilva caendesilva closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2022
@caendesilva
Copy link
Member Author

Or, since it's useful in tests, we could keep it around, but just simplify it. What bothers me is that it has so many outcomes. Making it just be a wrapper for the copy function, using the configured path, would be better.

This is being implemented in #311 and can be closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caendesilva