Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The File.php model's getMimeType() helper function should support XML in the lookup table #562

Closed
caendesilva opened this issue Oct 24, 2022 · 3 comments
Labels
bug Something isn't working contributors-welcome Want something to do? Look here! good first issue Good for newcomers hacktoberfest

Comments

@caendesilva
Copy link
Member

Here's another easy Hacktoberfest bug to fix!

Since this is targeted at beginners and I want you to learn something, I won't tell you exactly what value it should return, however I am happy to offer help if you need it.

Your mission, should you choose to accept it, is to find out the proper mime type for XML files, then submit a pull request to this repository, adding the mime type mapping to the $lookup array in the getMimeType() method of the File.php class.

Good luck!

@caendesilva caendesilva added bug Something isn't working good first issue Good for newcomers contributors-welcome Want something to do? Look here! hacktoberfest labels Oct 24, 2022
@LunarMarathon
Copy link
Contributor

Hey, I would like to try this!
I'm not sure if you'll be assigning first but since you've mentioned to submit a PR, I'll make the changes and submit one

@caendesilva
Copy link
Member Author

Hey, I would like to try this! I'm not sure if you'll be assigning first but since you've mentioned to submit a PR, I'll make the changes and submit one

Hey! Go right ahead! I don't usually assign people, but it's great that you left a comment, so other people knows that you are working on it.

Good luck and let me know if you need any help! But most importantly: have fun!

@caendesilva
Copy link
Member Author

Fixed by #563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contributors-welcome Want something to do? Look here! good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants