Refactor bootstrappers and improve Yaml environment configuration loading #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1773 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1758 1762 +4
===========================================
Files 180 182 +2
Lines 4694 4706 +12
===========================================
+ Hits 4694 4706 +12 ☔ View full report in Codecov by Sentry. |
We can't do this in a provider without registering a core binding, since this executes before service providers are registered.
caendesilva
force-pushed
the
improve-yaml-environment-configuration-loading
branch
from
a6b2906 to
968e044
Compare
caendesilva
force-pushed
the
improve-yaml-environment-configuration-loading
branch
from
894c276 to
faf791d
Compare
caendesilva
changed the title
This was referenced Jul 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up where #1770 left off and replaces #1771 which was merged by GitHub due to a glitch.
This pull request is a story of how I continuously lost my mind.
In short, what we ended up with is a simple system that reads the yaml configuration before the application boots, and injects an environment variable for the site name if it's needed in order to elegantly have it be used in the configuration which is loaded afterwards.