From 765a1bb8da5f58b4ce5348b72cb94b1bd41a11bd Mon Sep 17 00:00:00 2001 From: YunfeiHe Date: Fri, 25 Aug 2023 13:26:40 +0800 Subject: [PATCH 1/5] test windows --- .github/workflows/correctness.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/correctness.yml b/.github/workflows/correctness.yml index cc8bf04..f82aefd 100644 --- a/.github/workflows/correctness.yml +++ b/.github/workflows/correctness.yml @@ -14,9 +14,7 @@ jobs: strategy: matrix: node: [18.x, 20.x] - # os: [ubuntu-latest, windows-latest, macos-latest] - # FIXME: Ignore windows. https://github.com/hyf0/starter-libesm/issues/2 - os: [ubuntu-latest, macos-latest] + os: [ubuntu-latest, windows-latest, macos-latest] fail-fast: false steps: From a86fd0a690b0c1bbd64b24c2690ea8f90d5298f7 Mon Sep 17 00:00:00 2001 From: YunfeiHe Date: Fri, 25 Aug 2023 13:30:10 +0800 Subject: [PATCH 2/5] shim --- package.json | 4 +++- tsconfig.json | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 072b950..b5daa12 100644 --- a/package.json +++ b/package.json @@ -4,13 +4,15 @@ "description": "Pure ESM library starter in JavaScript with type checking!", "type": "module", "exports": "./src/index.js", + "files": [ + "src/" + ], "license": "MIT", "keywords": [], "packageManager": "pnpm@8.0.0", "engines": { "pnpm": ">=8.0.0" }, - "author": "", "scripts": { "test": "node --test tests/*.js", "type-check": "tsc --noEmit", diff --git a/tsconfig.json b/tsconfig.json index 4d5b9f5..4847e89 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -8,7 +8,7 @@ /* Projects */ "incremental": true, /* Save .tsbuildinfo files to allow for incremental compilation of projects. */ // "composite": true, /* Enable constraints that allow a TypeScript project to be used with project references. */ - // "tsBuildInfoFile": "./.tsbuildinfo", /* Specify the path to .tsbuildinfo incremental compilation file. */ + "tsBuildInfoFile": "./.tsbuildinfo", /* Specify the path to .tsbuildinfo incremental compilation file. */ // "disableSourceOfProjectReferenceRedirect": true, /* Disable preferring source files instead of declaration files when referencing composite projects. */ // "disableSolutionSearching": true, /* Opt a project out of multi-project reference checking when editing. */ // "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */ From 1a6009fe02a9cbc7d6f1ab6a711feed98c4048c9 Mon Sep 17 00:00:00 2001 From: YunfeiHe Date: Fri, 25 Aug 2023 13:44:08 +0800 Subject: [PATCH 3/5] update pnpm --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index b5daa12..7aa7715 100644 --- a/package.json +++ b/package.json @@ -9,9 +9,9 @@ ], "license": "MIT", "keywords": [], - "packageManager": "pnpm@8.0.0", + "packageManager": "pnpm@8.3.1", "engines": { - "pnpm": ">=8.0.0" + "pnpm": ">=8.3.1" }, "scripts": { "test": "node --test tests/*.js", From 35698bb2c4c410e2a4fb7783102f3c9c647e80cc Mon Sep 17 00:00:00 2001 From: YunfeiHe Date: Fri, 25 Aug 2023 13:49:13 +0800 Subject: [PATCH 4/5] Exclude --- .github/workflows/correctness.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/correctness.yml b/.github/workflows/correctness.yml index f82aefd..a1c7c85 100644 --- a/.github/workflows/correctness.yml +++ b/.github/workflows/correctness.yml @@ -15,6 +15,11 @@ jobs: matrix: node: [18.x, 20.x] os: [ubuntu-latest, windows-latest, macos-latest] + exclude: + # Excludes node18.x on windows. Node built-in test runner doesn't support glob pattern + # on node18x. + - os: windows-latest + node: 18.x fail-fast: false steps: From c552d8e413b79dd19318943fdd1c4d40a50f9a9f Mon Sep 17 00:00:00 2001 From: YunfeiHe Date: Fri, 25 Aug 2023 16:36:50 +0800 Subject: [PATCH 5/5] Try --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7aa7715..147a985 100644 --- a/package.json +++ b/package.json @@ -14,7 +14,7 @@ "pnpm": ">=8.3.1" }, "scripts": { - "test": "node --test tests/*.js", + "test": "node --test \"tests/*.js\"", "type-check": "tsc --noEmit", "doc:build": "typedoc src/index.js", "doc:serve": "serve ./docs",