Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't show terminal font section #116

Closed
ask-compu opened this issue Apr 19, 2023 · 1 comment · Fixed by #235
Closed

doesn't show terminal font section #116

ask-compu opened this issue Apr 19, 2023 · 1 comment · Fixed by #235

Comments

@ask-compu
Copy link

ask-compu commented Apr 19, 2023

Description

hyfetch does not show the terminal font section but neowofetch does

Neofetch version

hyfetch 1.4.8
neowofetch 7.3.8

Screenshot

image

Config file

neofetch config
hyfetch config

@hykilpikonna
Copy link
Owner

This is because, in the detection function, it uses get_ppid "$$" to obtain the process id of the parent, which, in this case, is HyFetch instead of zsh.

The same issue will occur if neofetch is ran in a zsh subprocess that's one level below from the konsole process:

image

So I implemented an easy fix to recursively check for parent processes until the parent is "konsole."

image

image

hykilpikonna added a commit that referenced this issue May 1, 2023
syimyuzya referenced this issue in syimyuzya/neofetch Feb 15, 2024
Once fixed in dylanaraps#1063, but got broken again with the fix of
hykilpikonna#116.
syimyuzya referenced this issue in syimyuzya/neofetch Feb 15, 2024
Once fixed in dylanaraps#1615, but got broken again with the fix of
hykilpikonna#116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants