Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TIDAL HiFi as a music player #22

Closed
Mar0xy opened this issue Sep 19, 2022 · 5 comments
Closed

Adding TIDAL HiFi as a music player #22

Mar0xy opened this issue Sep 19, 2022 · 5 comments

Comments

@Mar0xy
Copy link

Mar0xy commented Sep 19, 2022

I wonder if it would be possible adding TIDAL HiFi to the music players considering it uses MPRIS which aligns with most of the music players in the script.
the MPRIS service/endpoint is called "tidal-hifi"

@hykilpikonna
Copy link
Owner

I tried adding support today, but it turns out the MPRIS endpoint for tidal-hifi-bin is actually org.mpris.MediaPlayer2.chromium.instance364177. However, on another machine, the endpoint is org.mpris.MediaPlayer2.chromium.instance3414.

We currently don't have a way to detect changing MPRIS endpoint names without depending on qdbus provided by the qt5-tools package, which isn't installed by default on Gnome-based installations.

Maybe you can open an issue on https://github.com/Mastermindzh/tidal-hifi asking them to change the MPRIS endpoint.

image

image

@Mar0xy
Copy link
Author

Mar0xy commented Sep 25, 2022

That's bizarre considering when I use it on my system which is running opensuse and using the .tar.gz file from release to build the rpm package kinda like the AUR package uses the .tar.gz to make the pacman package i can use tidal-hifi just fine to control it via dbus as the app also starts the MPRIS api with the name tidal-hifi as it's endpoint in this line

image

hykilpikonna added a commit that referenced this issue Sep 26, 2022
@hykilpikonna
Copy link
Owner

hykilpikonna commented Sep 26, 2022

That's so weird... Maybe it's an ArchLinux issue, I'll ask the package maintainers on AUR.

I've just added the endpoint as tidal-hifi, can you check if it would work on your side?

image

btw you can run the latest neowofetch using bash <(curl -sL neowofetch.hydev.org)

@Mar0xy
Copy link
Author

Mar0xy commented Sep 26, 2022

It does indeed work
image

Also I am the AUR package maintainer which is why I explained how it worked and as to why I am confused that electron is doing that.

@hykilpikonna
Copy link
Owner

Oh wow I didn't realize you are the AUR package maintainer ;-;

It's nice that it worked on opensuse, I'll mark the issue as resolved for now. I have no idea why the MPRIS endpoint wouldn't be the same on Arch, but it'll show up in hyfetch/neowofetch when the MPRIS endpoint is fixed

teohhanhui added a commit to teohhanhui/hyfetch that referenced this issue Jul 13, 2024
Use selected backend to get distro name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants