The Hylo Group
Replies: 1 comment 3 replies
-
|
Please set your configuration to eliminate all the "surely innocuous" warnings, post the configuration file, and replace the resulting output in your post. |
Beta Was this translation helpful? Give feedback.
3 replies
-
|
Here is a proposed configuration file (.swiftlint.yml) which removes lots of the innocuous stuff: Running swiftlint in the Sources directory with the above config file produces 94 unique warnings/errors: |
Beta Was this translation helpful? Give feedback.
-
|
The output you posted has no file/line information, so it's pretty useless for evaluation. Anyway, I dropped that configuration file into hylo after adding include:
- Sourcesand tried invoking If you can find some settings where SwiftLint points at only things that can inarguably be improved, I would reconsider, but it would have to point to enough problems to warrant burdening developers and CI with the overhead. |
Beta Was this translation helpful? Give feedback.
-
|
I used func check(_ d: AnyDeclID) {
switch d.kind {
case FunctionDecl.self:
check(FunctionDecl.ID(d)!) // The forced unwrap is clearly justified
...
}
}The same goes for cyclomatic complexity, or function lengths, or parameter counts. From your report I see that there are a couple of advices that we could use, like So I'll second Dave and wait to see a specific set of settings that only highlight cases that should be improved. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I ran SwiftLint in the Sources directory and found 229 unique warnings or errors (below). Some of the warnings are certainly innocuous: witness the heavy use of single-character variable names. But maybe some of the suggestions could help to improve code quality.
Addressing things like high cyclomatic complexity, long files/functions, and duplicate conditions might very well avoid problems in the long run.
Will the project accept pull requests which offer remedies for the errors and warnings produced by SwiftLint?
Sources% find . -name ".swift" | xargs swiftlint 2> /dev/null | grep -E "warning|error" | sed 's/^.swift://g' | sed 's/^[0-9]:[0-9]: //g' | sort | uniq -c | sort -n
(output elided—see below)
Beta Was this translation helpful? Give feedback.
All reactions