Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch encoder for OpenTSDB #3

Open
timurb opened this issue Sep 25, 2015 · 3 comments
Open

batch encoder for OpenTSDB #3

timurb opened this issue Sep 25, 2015 · 3 comments

Comments

@timurb
Copy link
Contributor

timurb commented Sep 25, 2015

Hi,
I'm going to create a batch encoder for OpenTSDB based on your opentsdb_http so that a single Heka message could hold in it several metrics at once (vs a single metric as processed at the moment).

Do you think I should create a new encoder or use the same one but try to maintain backward compatibility (or may be drop compatibility)?

BTW, do you have any plans on contributing encoders to Heka core?
I can do that for this new encoder if you are not going to do that soon (referring to you as an original author of course). What do you think?

@hynd
Copy link
Owner

hynd commented Sep 26, 2015

Go for it - if it starts getting messy, i'd create a separate one. And by all means contribute yours to Heka core!

I have a few others that we use internally, but they'd need some tweaking to make them reusable by others. Because of the opinionated way (eg; single messages and some fields) we run things through our pipeline, i'm not sure Heka would want them in the core package - i was content just leaving it linked from https://github.com/mozilla-services/heka/wiki/Community-Plugins.

There were a couple of changes i was going to make to this one (switching to decode_message(read_message("raw")) instead of read_next_field(), and bumping the JSON number precision up now that trink/lua-cjson#1 made its way into Heka, but both would tie this encoder to a pretty recent Heka release.

@timurb
Copy link
Contributor Author

timurb commented Sep 26, 2015

Ok, I'll try doing a contribution to Heka core then. If they don't accept it I'll send a pull request to you.
There is also a distant possibility that my design suites nor Heka upstream nor your vision -- in that case I'll just leave a comment here for you.

I'm not planning to support Heka versions lower than 0.10 so I was going to use read_message instead of read_next_field too.
What is the story about JSON number precision? I'm afraid I don't understand what is that ticket about.

@timurb
Copy link
Contributor Author

timurb commented Sep 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants