Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript overrides for derived getters shouldn't also have a setter. #32

Open
ikeough opened this issue Feb 2, 2018 · 0 comments
Open

Comments

@ikeough
Copy link
Collaborator

ikeough commented Feb 2, 2018

To represent derived attributes in Typescript, we currently need to include a get and a set, otherwise the setting of the property via the constructor will fail with a warning that the class has only a getter. Of course, we don't want a setter because these attributes are derived. We should only have a getter which calls the corresponding function to return the correct data. This needs a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant